* [PATCH] Staging: greybus: Remove a space because line is too long
@ 2021-04-12 14:13 PEGGY TAWAH
2021-04-12 14:20 ` [Outreachy kernel] " Julia Lawall
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: PEGGY TAWAH @ 2021-04-12 14:13 UTC (permalink / raw)
To: outreachy-kernel, Vaibhav Hiremath, Johan Hovold, Alex Elder,
Greg Kroah-Hartman
checkpatch complained of line 182 too long in greybus driver,so i removed some spaces. CHECK: line length of 101 exceeds 100 colums
Signed-off-by: PEGGY TAWAH <tawahpeggy98@gmail.com>
---
drivers/staging/greybus/arche-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index e374dfc0c92f..1bfec5fae849 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -179,7 +179,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
if (arche_pdata->wake_detect_state !=
WD_STATE_COLDBOOT_START) {
arche_platform_set_wake_detect_state(arche_pdata,
- WD_STATE_COLDBOOT_TRIG);
+ WD_STATE_COLDBOOT_TRIG);
spin_unlock_irqrestore(&arche_pdata->wake_lock,
flags);
return IRQ_WAKE_THREAD;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: greybus: Remove a space because line is too long
2021-04-12 14:13 [PATCH] Staging: greybus: Remove a space because line is too long PEGGY TAWAH
@ 2021-04-12 14:20 ` Julia Lawall
2021-04-12 14:22 ` Matthew Wilcox
2021-04-12 14:23 ` Greg Kroah-Hartman
2 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2021-04-12 14:20 UTC (permalink / raw)
To: PEGGY TAWAH
Cc: outreachy-kernel, Vaibhav Hiremath, Johan Hovold, Alex Elder,
Greg Kroah-Hartman
On Mon, 12 Apr 2021, PEGGY TAWAH wrote:
> checkpatch complained of line 182 too long in greybus driver,so i removed some spaces. CHECK: line length of 101 exceeds 100 colums
It would be good for the lines of the log message to stay within around 70
characters. The message will be slightly indented by git.
>
> Signed-off-by: PEGGY TAWAH <tawahpeggy98@gmail.com>
Only one space after the Signed-off-by:
julia
> ---
> drivers/staging/greybus/arche-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index e374dfc0c92f..1bfec5fae849 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -179,7 +179,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
> if (arche_pdata->wake_detect_state !=
> WD_STATE_COLDBOOT_START) {
> arche_platform_set_wake_detect_state(arche_pdata,
> - WD_STATE_COLDBOOT_TRIG);
> + WD_STATE_COLDBOOT_TRIG);
> spin_unlock_irqrestore(&arche_pdata->wake_lock,
> flags);
> return IRQ_WAKE_THREAD;
> --
> 2.17.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210412141329.GA31738%40peggy-Lenovo-V130-15IKB.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: greybus: Remove a space because line is too long
2021-04-12 14:13 [PATCH] Staging: greybus: Remove a space because line is too long PEGGY TAWAH
2021-04-12 14:20 ` [Outreachy kernel] " Julia Lawall
@ 2021-04-12 14:22 ` Matthew Wilcox
2021-04-12 14:23 ` Greg Kroah-Hartman
2 siblings, 0 replies; 5+ messages in thread
From: Matthew Wilcox @ 2021-04-12 14:22 UTC (permalink / raw)
To: PEGGY TAWAH
Cc: outreachy-kernel, Vaibhav Hiremath, Johan Hovold, Alex Elder,
Greg Kroah-Hartman
On Mon, Apr 12, 2021 at 10:13:34AM -0400, PEGGY TAWAH wrote:
> checkpatch complained of line 182 too long in greybus driver,so i removed some spaces. CHECK: line length of 101 exceeds 100 colums
... next, we're going to have people complaining that the argument
doesn't line up with the opening '('.
The underlying problem is that the indentation is too deep. Something
should probably be factored out into its own function, allowing the
indentation to start again at a single tab.
I'd suggest this probably looks like:
if (gpiod_get_value(arche_pdata->wake_detect)) {
if (!arche_platform_wake_boot_init(arche_pdata)) {
spin_unlock_irqrestore(&arche_pdata->wake_lock, flags);
return IRQ_WAKE_THREAD;
}
}
... and let you write arche_platform_wake_boot_init().
> Signed-off-by: PEGGY TAWAH <tawahpeggy98@gmail.com>
>
> ---
> drivers/staging/greybus/arche-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index e374dfc0c92f..1bfec5fae849 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -179,7 +179,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
> if (arche_pdata->wake_detect_state !=
> WD_STATE_COLDBOOT_START) {
> arche_platform_set_wake_detect_state(arche_pdata,
> - WD_STATE_COLDBOOT_TRIG);
> + WD_STATE_COLDBOOT_TRIG);
> spin_unlock_irqrestore(&arche_pdata->wake_lock,
> flags);
> return IRQ_WAKE_THREAD;
> --
> 2.17.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210412141329.GA31738%40peggy-Lenovo-V130-15IKB.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: greybus: Remove a space because line is too long
2021-04-12 14:13 [PATCH] Staging: greybus: Remove a space because line is too long PEGGY TAWAH
2021-04-12 14:20 ` [Outreachy kernel] " Julia Lawall
2021-04-12 14:22 ` Matthew Wilcox
@ 2021-04-12 14:23 ` Greg Kroah-Hartman
2021-04-12 17:18 ` PEGGY TAWAH
2 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-04-12 14:23 UTC (permalink / raw)
To: PEGGY TAWAH; +Cc: outreachy-kernel, Vaibhav Hiremath, Johan Hovold, Alex Elder
On Mon, Apr 12, 2021 at 10:13:34AM -0400, PEGGY TAWAH wrote:
> checkpatch complained of line 182 too long in greybus driver,so i removed some spaces. CHECK: line length of 101 exceeds 100 colums
Please line-wrap your changelog text.
>
> Signed-off-by: PEGGY TAWAH <tawahpeggy98@gmail.com>
Please use lower case letters where needed.
Also you did not cc: the proper mailing lists, please read the
instructions again.
>
> ---
> drivers/staging/greybus/arche-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index e374dfc0c92f..1bfec5fae849 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -179,7 +179,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
> if (arche_pdata->wake_detect_state !=
> WD_STATE_COLDBOOT_START) {
> arche_platform_set_wake_detect_state(arche_pdata,
> - WD_STATE_COLDBOOT_TRIG);
> + WD_STATE_COLDBOOT_TRIG);
> spin_unlock_irqrestore(&arche_pdata->wake_lock,
> flags);
> return IRQ_WAKE_THREAD;
> --
> 2.17.1
>
>
Your patch is whitespace damaged and can not be applied at all :(
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: greybus: Remove a space because line is too long
2021-04-12 14:23 ` Greg Kroah-Hartman
@ 2021-04-12 17:18 ` PEGGY TAWAH
0 siblings, 0 replies; 5+ messages in thread
From: PEGGY TAWAH @ 2021-04-12 17:18 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1441 bytes --]
Okay thank you all.
working on fixes to match the changes stated.
On Monday, April 12, 2021 at 10:23:42 AM UTC-4 gregkh wrote:
> On Mon, Apr 12, 2021 at 10:13:34AM -0400, PEGGY TAWAH wrote:
> > checkpatch complained of line 182 too long in greybus driver,so i
> removed some spaces. CHECK: line length of 101 exceeds 100 colums
>
> Please line-wrap your changelog text.
>
> >
> > Signed-off-by: PEGGY TAWAH <tawahp...@gmail.com>
>
> Please use lower case letters where needed.
>
> Also you did not cc: the proper mailing lists, please read the
> instructions again.
>
>
> >
> > ---
> > drivers/staging/greybus/arche-platform.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/arche-platform.c
> b/drivers/staging/greybus/arche-platform.c
> > index e374dfc0c92f..1bfec5fae849 100644
> > --- a/drivers/staging/greybus/arche-platform.c
> > +++ b/drivers/staging/greybus/arche-platform.c
> > @@ -179,7 +179,7 @@ static irqreturn_t arche_platform_wd_irq(int irq,
> void *devid)
> > if (arche_pdata->wake_detect_state !=
> > WD_STATE_COLDBOOT_START) {
> > arche_platform_set_wake_detect_state(arche_pdata,
> > - WD_STATE_COLDBOOT_TRIG);
> > + WD_STATE_COLDBOOT_TRIG);
> > spin_unlock_irqrestore(&arche_pdata->wake_lock,
> > flags);
> > return IRQ_WAKE_THREAD;
> > --
> > 2.17.1
> >
> >
>
> Your patch is whitespace damaged and can not be applied at all :(
>
[-- Attachment #1.2: Type: text/html, Size: 2256 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-12 17:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 14:13 [PATCH] Staging: greybus: Remove a space because line is too long PEGGY TAWAH
2021-04-12 14:20 ` [Outreachy kernel] " Julia Lawall
2021-04-12 14:22 ` Matthew Wilcox
2021-04-12 14:23 ` Greg Kroah-Hartman
2021-04-12 17:18 ` PEGGY TAWAH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.