From: Dave Hansen <dave.hansen@intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
luto@kernel.org, peterz@infradead.org
Cc: ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
hpa@zytor.com, linux-kernel@vger.kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
thomas.lendacky@amd.com, x86@kernel.org
Subject: Re: [PATCHv4 3/3] x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page
Date: Wed, 15 Jun 2022 16:34:48 -0700 [thread overview]
Message-ID: <db63853f-dbd8-7593-032d-e674046bff8e@intel.com> (raw)
In-Reply-To: <20220615225200.lflv4tbqus6lnj5u@black.fi.intel.com>
On 6/15/22 15:52, Kirill A. Shutemov wrote:
>> + vaddr = (unsigned long)insn_get_addr_ref(&insn, regs);
>> + if (vaddr / PAGE_SIZE != (vaddr + size) / PAGE_SIZE)
> Oops. I just realized it has off-by-one. It supposed to be:
>
> if (vaddr / PAGE_SIZE != (vaddr + size - 1) / PAGE_SIZE)
That was bugging me. Glad you caught this.
Wouldn't this be more obviously correct?
if (ALIGN_DOWN(vaddr, PAGE_SIZE) !=
ALIGN_DOWN(vaddr + size, PAGE_SIZE))
...
I don't think we have a PAGE_ALIGN_DOWN().
next prev parent reply other threads:[~2022-06-15 23:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 12:01 [PATCHv4 0/3] An updated version of the load_unaligned_zeropad() fix Kirill A. Shutemov
2022-06-14 12:01 ` [PATCHv4 1/3] x86/tdx: Fix early #VE handling Kirill A. Shutemov
2022-06-17 21:53 ` [tip: x86/urgent] " tip-bot2 for Kirill A. Shutemov
2022-06-14 12:01 ` [PATCHv4 2/3] x86/tdx: Clarify RIP adjustments in #VE handler Kirill A. Shutemov
2022-06-17 21:53 ` [tip: x86/urgent] " tip-bot2 for Kirill A. Shutemov
2022-06-14 12:01 ` [PATCHv4 3/3] x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page Kirill A. Shutemov
2022-06-15 15:27 ` Dave Hansen
2022-06-15 17:10 ` Kirill A. Shutemov
2022-06-15 21:55 ` Dave Hansen
2022-06-15 22:43 ` Kirill A. Shutemov
2022-06-15 22:49 ` Dave Hansen
2022-06-15 23:16 ` Kirill A. Shutemov
2022-06-15 18:12 ` Dave Hansen
2022-06-15 22:32 ` Kirill A. Shutemov
2022-06-15 22:36 ` Dave Hansen
2022-06-15 23:16 ` Kirill A. Shutemov
2022-06-15 22:52 ` Kirill A. Shutemov
2022-06-15 23:34 ` Dave Hansen [this message]
2022-06-16 1:19 ` Kirill A. Shutemov
2022-06-16 6:35 ` David Laight
2022-06-17 21:53 ` [tip: x86/urgent] " tip-bot2 for Kirill A. Shutemov
2022-06-17 22:41 ` tip-bot2 for Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db63853f-dbd8-7593-032d-e674046bff8e@intel.com \
--to=dave.hansen@intel.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.