All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Nicolas Frayer <nfrayer@baylibre.com>, <nm@ti.com>,
	<kristo@kernel.org>, <ssantosh@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<jassisinghbrar@gmail.com>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <khilman@baylibre.com>, <glaroque@baylibre.com>
Subject: Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
Date: Thu, 24 Nov 2022 19:59:39 +0530	[thread overview]
Message-ID: <db869c2f-d34f-1ce5-22f9-634a8454ee79@ti.com> (raw)
In-Reply-To: <20221122202245.449198-2-nfrayer@baylibre.com>



On 23/11/22 1:52 am, Nicolas Frayer wrote:
> In order to build ti mailbox and ti sci as modules,
> remove their automatic selection by ARCH_K3
> 

$Subject: s/Removed/Remove,
s/ti/TI
s/sci/SCI

> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> ---
>  arch/arm64/Kconfig.platforms | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 912529ac58b3..5f16eb498dbf 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -126,8 +126,6 @@ config ARCH_K3
>  	select PM_GENERIC_DOMAINS if PM
>  	select MAILBOX
>  	select SOC_TI
> -	select TI_MESSAGE_MANAGER
> -	select TI_SCI_PROTOCOL
>  	select TI_SCI_INTR_IRQCHIP
>  	select TI_SCI_INTA_IRQCHIP
>  	help


Why not use "imply" instead of "select". This should allow TI_SCI*
drivers to be built as modules if required. Would make 2/3 and 3/3
redundant.

Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
so not a great idea to post as a single series.

Regards
Vignesh

WARNING: multiple messages have this Message-ID (diff)
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Nicolas Frayer <nfrayer@baylibre.com>, <nm@ti.com>,
	<kristo@kernel.org>, <ssantosh@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<jassisinghbrar@gmail.com>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <khilman@baylibre.com>, <glaroque@baylibre.com>
Subject: Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
Date: Thu, 24 Nov 2022 19:59:39 +0530	[thread overview]
Message-ID: <db869c2f-d34f-1ce5-22f9-634a8454ee79@ti.com> (raw)
In-Reply-To: <20221122202245.449198-2-nfrayer@baylibre.com>



On 23/11/22 1:52 am, Nicolas Frayer wrote:
> In order to build ti mailbox and ti sci as modules,
> remove their automatic selection by ARCH_K3
> 

$Subject: s/Removed/Remove,
s/ti/TI
s/sci/SCI

> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> ---
>  arch/arm64/Kconfig.platforms | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 912529ac58b3..5f16eb498dbf 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -126,8 +126,6 @@ config ARCH_K3
>  	select PM_GENERIC_DOMAINS if PM
>  	select MAILBOX
>  	select SOC_TI
> -	select TI_MESSAGE_MANAGER
> -	select TI_SCI_PROTOCOL
>  	select TI_SCI_INTR_IRQCHIP
>  	select TI_SCI_INTA_IRQCHIP
>  	help


Why not use "imply" instead of "select". This should allow TI_SCI*
drivers to be built as modules if required. Would make 2/3 and 3/3
redundant.

Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
so not a great idea to post as a single series.

Regards
Vignesh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-24 14:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 20:22 [PATCH 0/3] arm64: arch_k3: Removed ti mailbox and sci select Nicolas Frayer
2022-11-22 20:22 ` Nicolas Frayer
2022-11-22 20:22 ` [PATCH 1/3] " Nicolas Frayer
2022-11-22 20:22   ` Nicolas Frayer
2022-11-24 14:29   ` Vignesh Raghavendra [this message]
2022-11-24 14:29     ` Vignesh Raghavendra
2022-11-25 10:36     ` Nicolas Frayer
2022-11-25 10:36       ` Nicolas Frayer
2022-11-22 20:22 ` [PATCH 2/3] mailbox: config: ti-msgmgr: Default set to ARCH_K3 for TI msg manager Nicolas Frayer
2022-11-22 20:22   ` Nicolas Frayer
2022-11-22 20:22 ` [PATCH 3/3] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver Nicolas Frayer
2022-11-22 20:22   ` Nicolas Frayer
2022-11-22 22:46 ` [PATCH 0/3] arm64: arch_k3: Removed ti mailbox and sci select Kevin Hilman
2022-11-22 22:46   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db869c2f-d34f-1ce5-22f9-634a8454ee79@ti.com \
    --to=vigneshr@ti.com \
    --cc=catalin.marinas@arm.com \
    --cc=glaroque@baylibre.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=khilman@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfrayer@baylibre.com \
    --cc=nm@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.