[U-Boot] [PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[U-Boot] [PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[Schrempf Frieder]

From: Frieder Schrempf <frieder.schrempf@kontron.de>

The 24MHz oscillator clock is referenced by "clock-osc-24m" and not
"osc_24m".

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 drivers/clk/imx/clk-imx8mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index 091b092bbb..a05dac7c7a 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -74,7 +74,7 @@ static const char *sys_pll3_bypass_sels[] = {"sys_pll3", "sys_pll3_ref_sel", };
 static const char *imx8mm_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m", "sys_pll2_1000m",
 					"sys_pll1_800m", "sys_pll1_400m", "audio_pll1_out", "sys_pll3_out", };
 
-static const char *imx8mm_ahb_sels[] = {"osc_24m", "sys_pll1_133m", "sys_pll1_800m", "sys_pll1_400m",
+static const char *imx8mm_ahb_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_800m", "sys_pll1_400m",
 					"sys_pll2_125m", "sys_pll3_out", "audio_pll1_out", "video_pll1_out", };
 
 static const char *imx8mm_enet_axi_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_250m",
-- 
2.17.1

[U-Boot] [PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[Fabio Estevam]

Hi Frieder,

On Wed, Oct 23, 2019 at 1:36 PM Schrempf Frieder
<frieder.schrempf@kontron.de> wrote:
>
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> The 24MHz oscillator clock is referenced by "clock-osc-24m" and not
> "osc_24m".

Is the kernel clock driver also wrong then?

[U-Boot] [PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[Peng Fan]

> Subject: Re: [PATCH] clk: imx: imx8mm: Fix the first root clock in
> imx8mm_ahb_sels[]
> 
> Hi Frieder,
> 
> On Wed, Oct 23, 2019 at 1:36 PM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
> >
> > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >
> > The 24MHz oscillator clock is referenced by "clock-osc-24m" and not
> > "osc_24m".
> 
> Is the kernel clock driver also wrong then?

No, kernel is right. It is U-Boot CCF specific.

Regards,
Peng.

[U-Boot] [PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[Peng Fan]

> Subject: [PATCH] clk: imx: imx8mm: Fix the first root clock in
> imx8mm_ahb_sels[]
> 
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> The 24MHz oscillator clock is referenced by "clock-osc-24m" and not
> "osc_24m".
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
>  drivers/clk/imx/clk-imx8mm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index 091b092bbb..a05dac7c7a 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -74,7 +74,7 @@ static const char *sys_pll3_bypass_sels[] = {"sys_pll3",
> "sys_pll3_ref_sel", };  static const char *imx8mm_a53_sels[] =
> {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m", "sys_pll2_1000m",
>  					"sys_pll1_800m", "sys_pll1_400m", "audio_pll1_out",
> "sys_pll3_out", };
> 
> -static const char *imx8mm_ahb_sels[] = {"osc_24m", "sys_pll1_133m",
> "sys_pll1_800m", "sys_pll1_400m",
> +static const char *imx8mm_ahb_sels[] = {"clock-osc-24m",
> +"sys_pll1_133m", "sys_pll1_800m", "sys_pll1_400m",
>  					"sys_pll2_125m", "sys_pll3_out", "audio_pll1_out",
> "video_pll1_out", };
> 
>  static const char *imx8mm_enet_axi_sels[] = {"clock-osc-24m",
> "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_250m",

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> --
> 2.17.1

[U-Boot] [PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[Schrempf Frieder]

On 23.10.19 18:36, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> The 24MHz oscillator clock is referenced by "clock-osc-24m" and not
> "osc_24m".
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Just for completeness:
Fixes: f62ec5c4bba2 ("clk: imx: add i.MX8MM clk driver")

> ---
>   drivers/clk/imx/clk-imx8mm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index 091b092bbb..a05dac7c7a 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -74,7 +74,7 @@ static const char *sys_pll3_bypass_sels[] = {"sys_pll3", "sys_pll3_ref_sel", };
>   static const char *imx8mm_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m", "sys_pll2_1000m",
>   					"sys_pll1_800m", "sys_pll1_400m", "audio_pll1_out", "sys_pll3_out", };
>   
> -static const char *imx8mm_ahb_sels[] = {"osc_24m", "sys_pll1_133m", "sys_pll1_800m", "sys_pll1_400m",
> +static const char *imx8mm_ahb_sels[] = {"clock-osc-24m", "sys_pll1_133m", "sys_pll1_800m", "sys_pll1_400m",
>   					"sys_pll2_125m", "sys_pll3_out", "audio_pll1_out", "video_pll1_out", };
>   
>   static const char *imx8mm_enet_axi_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_250m",
> 

[U-Boot] [PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[Fabio Estevam]

On Wed, Oct 23, 2019 at 10:11 PM Peng Fan <peng.fan@nxp.com> wrote:

> No, kernel is right. It is U-Boot CCF specific.

Can we make U-Boot to handle the same clock name as in kernel?

[U-Boot] [PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[Peng Fan]

> Subject: Re: [PATCH] clk: imx: imx8mm: Fix the first root clock in
> imx8mm_ahb_sels[]
> 
> On Wed, Oct 23, 2019 at 10:11 PM Peng Fan <peng.fan@nxp.com> wrote:
> 
> > No, kernel is right. It is U-Boot CCF specific.
> 
> Can we make U-Boot to handle the same clock name as in kernel?

Let's try. But this patch is bug fix, so need first in.

Regards,
Peng.

[PATCH] clk: imx: imx8mm: Fix the first root clock in imx8mm_ahb_sels[]

[Stefano Babic]

On 25/10/19 03:39, Peng Fan wrote:
>> Subject: Re: [PATCH] clk: imx: imx8mm: Fix the first root clock in
>> imx8mm_ahb_sels[]
>>
>> On Wed, Oct 23, 2019 at 10:11 PM Peng Fan <peng.fan@nxp.com> wrote:
>>
>>> No, kernel is right. It is U-Boot CCF specific.
>>
>> Can we make U-Boot to handle the same clock name as in kernel?
> 
> Let's try. But this patch is bug fix, so need first in.
> 

Agree, I pick it up for 2020.01

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================