All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Sandipan Das <sandipan@linux.ibm.com>,
	shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	mhiramat@kernel.org, aneesh.kumar@linux.ibm.com,
	kamalesh@linux.vnet.ibm.com,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/2] selftests: vm: Do not override definition of ARCH
Date: Fri, 10 Apr 2020 09:57:26 -0600	[thread overview]
Message-ID: <dbaeecdc-6145-50ca-b874-9f3ed11c927b@linuxfoundation.org> (raw)
In-Reply-To: <87lfp9zvl4.fsf@mpe.ellerman.id.au>

On 2/10/20 7:49 PM, Michael Ellerman wrote:
> Sandipan Das <sandipan@linux.ibm.com> writes:
>> Independent builds of the vm selftests is currently broken
>> because commit 7549b3364201 overrides the value of ARCH with
>> the machine name from uname. This does not always match the
>> architecture names used for tasks like header installation.
>>

In the interest not adding more delays to this patch, I fixed up
the commit log for the following error and applied it. I hope to
send this up for next rc.

ERROR: Please use git commit description style 'commit <12+ chars of 
sha1> ("<title line>")' - ie: 'commit 7549b3364201 ("selftests: vm: 
Build/Run 64bit tests only on 64bit arch")'
#93:
because commit 7549b3364201 overrides the value of ARCH with


The fixed up now looks as follows:

Independent builds of the vm selftests is currently broken because
commit 7549b3364201 ("selftests: vm: Build/Run 64bit tests only on
64bit arch") overrides the value of ARCH with the machine name from
uname. This does not always match the architecture names used for
tasks like header installation.

Please make sure to run checkpatch with --strict to catch these
kinds of errors in the future.

thanks,
-- Shuah

WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <skhan@linuxfoundation.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Sandipan Das <sandipan@linux.ibm.com>,
	shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: aneesh.kumar@linux.ibm.com, kamalesh@linux.vnet.ibm.com,
	linux-mm@kvack.org, mhiramat@kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] selftests: vm: Do not override definition of ARCH
Date: Fri, 10 Apr 2020 09:57:26 -0600	[thread overview]
Message-ID: <dbaeecdc-6145-50ca-b874-9f3ed11c927b@linuxfoundation.org> (raw)
In-Reply-To: <87lfp9zvl4.fsf@mpe.ellerman.id.au>

On 2/10/20 7:49 PM, Michael Ellerman wrote:
> Sandipan Das <sandipan@linux.ibm.com> writes:
>> Independent builds of the vm selftests is currently broken
>> because commit 7549b3364201 overrides the value of ARCH with
>> the machine name from uname. This does not always match the
>> architecture names used for tasks like header installation.
>>

In the interest not adding more delays to this patch, I fixed up
the commit log for the following error and applied it. I hope to
send this up for next rc.

ERROR: Please use git commit description style 'commit <12+ chars of 
sha1> ("<title line>")' - ie: 'commit 7549b3364201 ("selftests: vm: 
Build/Run 64bit tests only on 64bit arch")'
#93:
because commit 7549b3364201 overrides the value of ARCH with


The fixed up now looks as follows:

Independent builds of the vm selftests is currently broken because
commit 7549b3364201 ("selftests: vm: Build/Run 64bit tests only on
64bit arch") overrides the value of ARCH with the machine name from
uname. This does not always match the architecture names used for
tasks like header installation.

Please make sure to run checkpatch with --strict to catch these
kinds of errors in the future.

thanks,
-- Shuah

  reply	other threads:[~2020-04-10 15:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30  7:01 [PATCH 0/2] selftests: vm: Build fixes for powerpc64 Sandipan Das
2020-01-30  7:01 ` Sandipan Das
2020-01-30  7:01 ` [PATCH 1/2] selftests: vm: Do not override definition of ARCH Sandipan Das
2020-01-30  7:01   ` Sandipan Das
2020-02-11  2:49   ` Michael Ellerman
2020-02-11  2:49     ` Michael Ellerman
2020-04-10 15:57     ` Shuah Khan [this message]
2020-04-10 15:57       ` Shuah Khan
2020-01-30  7:01 ` [PATCH 2/2] selftests: vm: Fix 64-bit test builds for powerpc64le Sandipan Das
2020-01-30  7:01   ` Sandipan Das
2020-02-11  2:50   ` Michael Ellerman
2020-02-11  2:50     ` Michael Ellerman
2020-03-31 14:37 ` [PATCH 0/2] selftests: vm: Build fixes for powerpc64 Shuah Khan
2020-03-31 14:37   ` Shuah Khan
2020-04-01  3:37   ` Michael Ellerman
2020-04-01  3:37     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbaeecdc-6145-50ca-b874-9f3ed11c927b@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mhiramat@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=sandipan@linux.ibm.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.