From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <quic_wgong@quicinc.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Cc: ath11k@lists.infradead.org
Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi
Date: Mon, 17 Oct 2022 10:14:21 +0200 [thread overview]
Message-ID: <dbb569976328b5442c6373a8aaacfec9a157ac56.camel@sipsolutions.net> (raw)
In-Reply-To: <191042d8-7781-808f-71aa-db76ed763bec@quicinc.com>
On Mon, 2022-10-17 at 16:12 +0800, Wen Gong wrote:
> > >
> > I guess valid links wasn't set at that point yet?
> >
> > Anyway should also move out of rate_control_rate_init() and probably
> > into something like ieee80211_assoc_config_link()? That already does
> > some rx_nss calculations which is probably not great ...
>
> OK. I will test with my change internal now. And replace to use upstream
> change
>
> after someone fix it.
>
Well, I think you should try to fix it and submit the patch, I'm not
going to do it in the short term ... :)
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <quic_wgong@quicinc.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Cc: ath11k@lists.infradead.org
Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi
Date: Mon, 17 Oct 2022 10:14:21 +0200 [thread overview]
Message-ID: <dbb569976328b5442c6373a8aaacfec9a157ac56.camel@sipsolutions.net> (raw)
In-Reply-To: <191042d8-7781-808f-71aa-db76ed763bec@quicinc.com>
On Mon, 2022-10-17 at 16:12 +0800, Wen Gong wrote:
> > >
> > I guess valid links wasn't set at that point yet?
> >
> > Anyway should also move out of rate_control_rate_init() and probably
> > into something like ieee80211_assoc_config_link()? That already does
> > some rx_nss calculations which is probably not great ...
>
> OK. I will test with my change internal now. And replace to use upstream
> change
>
> after someone fix it.
>
Well, I think you should try to fix it and submit the patch, I'm not
going to do it in the short term ... :)
johannes
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-10-17 8:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 4:37 mlo rx nss value 0 of wifi Wen Gong
2022-09-13 4:37 ` Wen Gong
2022-09-28 15:15 ` Wen Gong
2022-09-28 15:15 ` Wen Gong
2022-10-17 7:10 ` wifi: mac80211: " Wen Gong
2022-10-17 7:10 ` Wen Gong
2022-10-17 7:48 ` Johannes Berg
2022-10-17 7:48 ` Johannes Berg
2022-10-17 7:49 ` Johannes Berg
2022-10-17 7:49 ` Johannes Berg
2022-10-17 8:00 ` Wen Gong
2022-10-17 8:00 ` Wen Gong
2022-10-17 8:02 ` Johannes Berg
2022-10-17 8:02 ` Johannes Berg
2022-10-17 8:12 ` Wen Gong
2022-10-17 8:12 ` Wen Gong
2022-10-17 8:14 ` Johannes Berg [this message]
2022-10-17 8:14 ` Johannes Berg
2022-10-18 8:45 ` Wen Gong
2022-10-18 8:45 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbb569976328b5442c6373a8aaacfec9a157ac56.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.