* [U-Boot] [PATCH] common: bootm: Document fake bootm sub-command
@ 2015-01-15 8:53 Michal Simek
2015-01-15 14:25 ` Simon Glass
2015-02-02 18:58 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 6+ messages in thread
From: Michal Simek @ 2015-01-15 8:53 UTC (permalink / raw)
To: u-boot
Fake option is enabled only when CONFIG_TRACE is
enabled in common/bootm.c:do_boot_states().
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
common/cmd_bootm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 67233600b157..48199bfff3ed 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -185,6 +185,9 @@ static char bootm_help_text[] =
"\tcmdline - OS specific command line processing/setup\n"
"\tbdt - OS specific bd_t processing\n"
"\tprep - OS specific prep before relocation or go\n"
+#if defined(CONFIG_TRACE)
+ "\tfake - OS specific fake start without go\n"
+#endif
"\tgo - start OS";
#endif
--
1.8.2.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150115/02548599/attachment.pgp>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] common: bootm: Document fake bootm sub-command
2015-01-15 8:53 [U-Boot] [PATCH] common: bootm: Document fake bootm sub-command Michal Simek
@ 2015-01-15 14:25 ` Simon Glass
2015-01-15 14:55 ` Michal Simek
2015-02-02 18:58 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Simon Glass @ 2015-01-15 14:25 UTC (permalink / raw)
To: u-boot
Hi Michal,
On 15 January 2015 at 01:53, Michal Simek <michal.simek@xilinx.com> wrote:
> Fake option is enabled only when CONFIG_TRACE is
> enabled in common/bootm.c:do_boot_states().
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> common/cmd_bootm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 67233600b157..48199bfff3ed 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -185,6 +185,9 @@ static char bootm_help_text[] =
> "\tcmdline - OS specific command line processing/setup\n"
> "\tbdt - OS specific bd_t processing\n"
> "\tprep - OS specific prep before relocation or go\n"
> +#if defined(CONFIG_TRACE)
> + "\tfake - OS specific fake start without go\n"
> +#endif
nit: I think it should be 'OS-specific'
> "\tgo - start OS";
> #endif
Regards,
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] common: bootm: Document fake bootm sub-command
2015-01-15 14:25 ` Simon Glass
@ 2015-01-15 14:55 ` Michal Simek
2015-01-15 14:57 ` Simon Glass
0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2015-01-15 14:55 UTC (permalink / raw)
To: u-boot
On 01/15/2015 03:25 PM, Simon Glass wrote:
> Hi Michal,
>
> On 15 January 2015 at 01:53, Michal Simek <michal.simek@xilinx.com> wrote:
>> Fake option is enabled only when CONFIG_TRACE is
>> enabled in common/bootm.c:do_boot_states().
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> common/cmd_bootm.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
>> index 67233600b157..48199bfff3ed 100644
>> --- a/common/cmd_bootm.c
>> +++ b/common/cmd_bootm.c
>> @@ -185,6 +185,9 @@ static char bootm_help_text[] =
>> "\tcmdline - OS specific command line processing/setup\n"
>> "\tbdt - OS specific bd_t processing\n"
>> "\tprep - OS specific prep before relocation or go\n"
>> +#if defined(CONFIG_TRACE)
>> + "\tfake - OS specific fake start without go\n"
>> +#endif
>
> nit: I think it should be 'OS-specific'
Just following what it is written above but follow-up cleanup patch
can be submitted.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150115/14b3c46b/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] common: bootm: Document fake bootm sub-command
2015-01-15 14:55 ` Michal Simek
@ 2015-01-15 14:57 ` Simon Glass
2015-01-21 9:22 ` Michal Simek
0 siblings, 1 reply; 6+ messages in thread
From: Simon Glass @ 2015-01-15 14:57 UTC (permalink / raw)
To: u-boot
On 15 January 2015 at 07:55, Michal Simek <monstr@monstr.eu> wrote:
> On 01/15/2015 03:25 PM, Simon Glass wrote:
>> Hi Michal,
>>
>> On 15 January 2015 at 01:53, Michal Simek <michal.simek@xilinx.com> wrote:
>>> Fake option is enabled only when CONFIG_TRACE is
>>> enabled in common/bootm.c:do_boot_states().
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>> ---
>>>
>>> common/cmd_bootm.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
>>> index 67233600b157..48199bfff3ed 100644
>>> --- a/common/cmd_bootm.c
>>> +++ b/common/cmd_bootm.c
>>> @@ -185,6 +185,9 @@ static char bootm_help_text[] =
>>> "\tcmdline - OS specific command line processing/setup\n"
>>> "\tbdt - OS specific bd_t processing\n"
>>> "\tprep - OS specific prep before relocation or go\n"
>>> +#if defined(CONFIG_TRACE)
>>> + "\tfake - OS specific fake start without go\n"
>>> +#endif
>>
>> nit: I think it should be 'OS-specific'
>
> Just following what it is written above but follow-up cleanup patch
> can be submitted.
OK.
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] common: bootm: Document fake bootm sub-command
2015-01-15 14:57 ` Simon Glass
@ 2015-01-21 9:22 ` Michal Simek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2015-01-21 9:22 UTC (permalink / raw)
To: u-boot
Hi Tom,
On 01/15/2015 03:57 PM, Simon Glass wrote:
> On 15 January 2015 at 07:55, Michal Simek <monstr@monstr.eu> wrote:
>> On 01/15/2015 03:25 PM, Simon Glass wrote:
>>> Hi Michal,
>>>
>>> On 15 January 2015 at 01:53, Michal Simek <michal.simek@xilinx.com> wrote:
>>>> Fake option is enabled only when CONFIG_TRACE is
>>>> enabled in common/bootm.c:do_boot_states().
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>> common/cmd_bootm.c | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
>>>> index 67233600b157..48199bfff3ed 100644
>>>> --- a/common/cmd_bootm.c
>>>> +++ b/common/cmd_bootm.c
>>>> @@ -185,6 +185,9 @@ static char bootm_help_text[] =
>>>> "\tcmdline - OS specific command line processing/setup\n"
>>>> "\tbdt - OS specific bd_t processing\n"
>>>> "\tprep - OS specific prep before relocation or go\n"
>>>> +#if defined(CONFIG_TRACE)
>>>> + "\tfake - OS specific fake start without go\n"
>>>> +#endif
>>>
>>> nit: I think it should be 'OS-specific'
>>
>> Just following what it is written above but follow-up cleanup patch
>> can be submitted.
>
> OK.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
Can you please apply this patch?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150121/8b58b69d/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] common: bootm: Document fake bootm sub-command
2015-01-15 8:53 [U-Boot] [PATCH] common: bootm: Document fake bootm sub-command Michal Simek
2015-01-15 14:25 ` Simon Glass
@ 2015-02-02 18:58 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2015-02-02 18:58 UTC (permalink / raw)
To: u-boot
On Thu, Jan 15, 2015 at 09:53:13AM +0100, Michal Simek wrote:
> Fake option is enabled only when CONFIG_TRACE is
> enabled in common/bootm.c:do_boot_states().
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150202/83a54cc1/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-02 18:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-15 8:53 [U-Boot] [PATCH] common: bootm: Document fake bootm sub-command Michal Simek
2015-01-15 14:25 ` Simon Glass
2015-01-15 14:55 ` Michal Simek
2015-01-15 14:57 ` Simon Glass
2015-01-21 9:22 ` Michal Simek
2015-02-02 18:58 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.