[PATCH] staging: rtl8192e: rename Channel to channel style

[PATCH] staging: rtl8192e: rename Channel to channel style

[himadri18.07]

[-- Attachment #1.1: Type: text/plain, Size: 1480 bytes --]

This patch fixes the checkpatch.pl warning:
        CHECK: Avoid CamelCase: <Channel>

Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
 drivers/staging/rtl8192e/dot11d.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/dot11d.c 
b/drivers/staging/rtl8192e/dot11d.c
index a1c096124683..687deac19796 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++ b/drivers/staging/rtl8192e/dot11d.c
@@ -15,7 +15,7 @@
 #include "dot11d.h"

 struct channel_list {
-       u8      Channel[32];
+       u8      channel[32];
        u8      Len;
 };

@@ -66,11 +66,11 @@ void Dot11d_Channelmap(u8 channel_plan, struct 
rtllib_device *ieee)
                memset(GET_DOT11D_INFO(ieee)->channel_map, 0,
                       sizeof(GET_DOT11D_INFO(ieee)->channel_map));
                for (i = 0; i < ChannelPlan[channel_plan].Len; i++) {
-                       if (ChannelPlan[channel_plan].Channel[i] < min_chan 
||
-                           ChannelPlan[channel_plan].Channel[i] > max_chan)
+                       if (ChannelPlan[channel_plan].channel[i] < min_chan 
||
+                           ChannelPlan[channel_plan].channel[i] > max_chan)
                                break;
                        GET_DOT11D_INFO(ieee)->channel_map[ChannelPlan
-                                       [channel_plan].Channel[i]] = 1;
+                                       [channel_plan].channel[i]] = 1;
                }
        }

[-- Attachment #1.2: Type: text/html, Size: 2103 bytes --]

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: rename Channel to channel style

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 2701 bytes --]

Hello,

Thanks for the patch, but it's not the time of the outreachy application
period now.  The application period for the ext round will open in
February: https://www.outreachy.org/

You are welcome to submit this patch in the normal way for the Linux
kernel.  You can see who to send it to using the get_maintainers command
described in the outreachy tutorial.

julia

On Tue, 1 Jan 2019, himadri18.07@gmail.com wrote:

> This patch fixes the checkpatch.pl warning:
>         CHECK: Avoid CamelCase: <Channel>
>
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/dot11d.c
> b/drivers/staging/rtl8192e/dot11d.c
> index a1c096124683..687deac19796 100644
> --- a/drivers/staging/rtl8192e/dot11d.c
> +++ b/drivers/staging/rtl8192e/dot11d.c
> @@ -15,7 +15,7 @@
>  #include "dot11d.h"
>
>  struct channel_list {
> -       u8      Channel[32];
> +       u8      channel[32];
>         u8      Len;
>  };
>
> @@ -66,11 +66,11 @@ void Dot11d_Channelmap(u8 channel_plan, struct
> rtllib_device *ieee)
>                 memset(GET_DOT11D_INFO(ieee)->channel_map, 0,
>                        sizeof(GET_DOT11D_INFO(ieee)->channel_map));
>                 for (i = 0; i < ChannelPlan[channel_plan].Len; i++) {
> -                       if (ChannelPlan[channel_plan].Channel[i] < min_chan
> ||
> -                           ChannelPlan[channel_plan].Channel[i] > max_chan)
> +                       if (ChannelPlan[channel_plan].channel[i] < min_chan
> ||
> +                           ChannelPlan[channel_plan].channel[i] > max_chan)
>                                 break;
>                         GET_DOT11D_INFO(ieee)->channel_map[ChannelPlan
> -                                       [channel_plan].Channel[i]] = 1;
> +                                       [channel_plan].channel[i]] = 1;
>                 }
>         }
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/dc077f72-2857-4ed2-809b-
> cff2f5c32cf3%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: rename Channel to channel style

[Himanshu Jha]

On Tue, Jan 01, 2019 at 06:52:44AM -0800, himadri18.07@gmail.com wrote:
> This patch fixes the checkpatch.pl warning:

"This patch... That patch..."

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

>         CHECK: Avoid CamelCase: <Channel>
> 
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---

That patch seems broken as you sent as an attachement
through Gmail ?

Tabs are converted to spaces.

When sending a new patch send either using Mutt as explained
in the tutorial or `git send-email` whichever suits you better.

+ suggestion from Julia.

>  drivers/staging/rtl8192e/dot11d.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.c 
> b/drivers/staging/rtl8192e/dot11d.c
> index a1c096124683..687deac19796 100644
> --- a/drivers/staging/rtl8192e/dot11d.c
> +++ b/drivers/staging/rtl8192e/dot11d.c
> @@ -15,7 +15,7 @@
>  #include "dot11d.h"
> 
>  struct channel_list {
> -       u8      Channel[32];
> +       u8      channel[32];
>         u8      Len;
>  };
> 
> @@ -66,11 +66,11 @@ void Dot11d_Channelmap(u8 channel_plan, struct 
> rtllib_device *ieee)
>                 memset(GET_DOT11D_INFO(ieee)->channel_map, 0,
>                        sizeof(GET_DOT11D_INFO(ieee)->channel_map));
>                 for (i = 0; i < ChannelPlan[channel_plan].Len; i++) {
> -                       if (ChannelPlan[channel_plan].Channel[i] < min_chan 
> ||
> -                           ChannelPlan[channel_plan].Channel[i] > max_chan)
> +                       if (ChannelPlan[channel_plan].channel[i] < min_chan 
> ||
> +                           ChannelPlan[channel_plan].channel[i] > max_chan)
>                                 break;
>                         GET_DOT11D_INFO(ieee)->channel_map[ChannelPlan
> -                                       [channel_plan].Channel[i]] = 1;
> +                                       [channel_plan].channel[i]] = 1;
>                 }
>         }
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/dc077f72-2857-4ed2-809b-cff2f5c32cf3%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.


-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology