All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerald BAEZA <gerald.baeza@st.com>
To: "acme@kernel.org" <arnaldo.melo@gmail.com>,
	Andi Kleen <ak@linux.intel.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"alexander.shishkin@linux.intel.com" 
	<alexander.shishkin@linux.intel.com>,
	"jolsa@redhat.com" <jolsa@redhat.com>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>
Subject: RE: perf tool issue following 'perf stat: Fix --no-scale' patch integration
Date: Thu, 22 Aug 2019 07:17:41 +0000	[thread overview]
Message-ID: <dc163c5ae1d3418c95e02e13a6205719@SFHDAG5NODE1.st.com> (raw)
In-Reply-To: <20190821195451.GG3929@kernel.org>

Hello Arnaldo and Andi

Indeed, 'aligned(8)' instead of 'aligned(64)'.
Thanks for your quick feedbacks and I am going to prepare the patch.

Gérald
 


> Em Wed, Aug 21, 2019 at 09:26:35AM -0700, Andi Kleen escreveu:
> > >
> > >    +             char contents[] __attribute__((aligned(64)));
> >
> > I think you want aligned(8). The parameter is bytes, not bits.
> >
> > >
> > >
> > >    But the xyarray structure is generic so I think this patch cannot be the
> > >    final one.
> >
> > I think it's fine actually to just apply this generically (with 8). It
> > will only waste a few bytes on other 32bit architectures and should be
> > a nop on 64bit, not worth doing anything more sophisticated.
> >
> > I would just submit a patch to do that.
> 
> Agreed.
> 
> - Arnaldo

WARNING: multiple messages have this Message-ID (diff)
From: Gerald BAEZA <gerald.baeza@st.com>
To: "acme@kernel.org" <arnaldo.melo@gmail.com>,
	Andi Kleen <ak@linux.intel.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Alexandre TORGUE <alexandre.torgue@st.com>,
	"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
	"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"alexander.shishkin@linux.intel.com"
	<alexander.shishkin@linux.intel.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"jolsa@redhat.com" <jolsa@redhat.com>
Subject: RE: perf tool issue following 'perf stat: Fix --no-scale' patch integration
Date: Thu, 22 Aug 2019 07:17:41 +0000	[thread overview]
Message-ID: <dc163c5ae1d3418c95e02e13a6205719@SFHDAG5NODE1.st.com> (raw)
In-Reply-To: <20190821195451.GG3929@kernel.org>

Hello Arnaldo and Andi

Indeed, 'aligned(8)' instead of 'aligned(64)'.
Thanks for your quick feedbacks and I am going to prepare the patch.

Gérald
 


> Em Wed, Aug 21, 2019 at 09:26:35AM -0700, Andi Kleen escreveu:
> > >
> > >    +             char contents[] __attribute__((aligned(64)));
> >
> > I think you want aligned(8). The parameter is bytes, not bits.
> >
> > >
> > >
> > >    But the xyarray structure is generic so I think this patch cannot be the
> > >    final one.
> >
> > I think it's fine actually to just apply this generically (with 8). It
> > will only waste a few bytes on other 32bit architectures and should be
> > a nop on 64bit, not worth doing anything more sophisticated.
> >
> > I would just submit a patch to do that.
> 
> Agreed.
> 
> - Arnaldo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

       reply	other threads:[~2019-08-22  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f686372a96ea490785c0a76cc96b3434@SFHDAG5NODE1.st.com>
     [not found] ` <20190821162635.GB36669@tassilo.jf.intel.com>
     [not found]   ` <20190821195451.GG3929@kernel.org>
2019-08-22  7:17     ` Gerald BAEZA [this message]
2019-08-22  7:17       ` perf tool issue following 'perf stat: Fix --no-scale' patch integration Gerald BAEZA
2019-08-21 14:58 Gerald BAEZA
2019-08-21 14:58 ` Gerald BAEZA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc163c5ae1d3418c95e02e13a6205719@SFHDAG5NODE1.st.com \
    --to=gerald.baeza@st.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.torgue@st.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.