From: Marc Zyngier <marc.zyngier@arm.com>
To: Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, christoffer.dall@linaro.org,
vijayak@caviumnetworks.com, Vijaya.Kumar@cavium.com,
peter.maydell@linaro.org, linux-arm-kernel@lists.infradead.org,
drjones@redhat.com, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org
Cc: andre.przywara@arm.com, pbonzini@redhat.com, dgilbert@redhat.com,
Prasun.Kapoor@cavium.com
Subject: Re: [RFC 07/13] KVM: arm64: ITS: Change entry_size and indirect bit in BASER
Date: Thu, 12 Jan 2017 17:05:29 +0000 [thread overview]
Message-ID: <dc26dc19-313b-375b-0d9b-f4ff411a914f@arm.com> (raw)
In-Reply-To: <1484236613-24633-8-git-send-email-eric.auger@redhat.com>
On 12/01/17 15:56, Eric Auger wrote:
> Change the device table entry_size to 16 bytes instead of 8.
> We also Store the device and collection device in the its
> struct.
>
> The patch also clears the indirect bit for the device BASER.
> The indirect bit is set as read-only.
Err... Why? We *really* want to continue supporting indirect tables, as
this is a massive memory saver for the guest.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>
> ---
>
> TODO: investigate support of 2 level tables, ie. enabling
> Indirect = 1. Support of 2 level tables is implementation
> defined.
Clearly, that's a regression. What exactly is the issue that decided you
to disable it?
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 07/13] KVM: arm64: ITS: Change entry_size and indirect bit in BASER
Date: Thu, 12 Jan 2017 17:05:29 +0000 [thread overview]
Message-ID: <dc26dc19-313b-375b-0d9b-f4ff411a914f@arm.com> (raw)
In-Reply-To: <1484236613-24633-8-git-send-email-eric.auger@redhat.com>
On 12/01/17 15:56, Eric Auger wrote:
> Change the device table entry_size to 16 bytes instead of 8.
> We also Store the device and collection device in the its
> struct.
>
> The patch also clears the indirect bit for the device BASER.
> The indirect bit is set as read-only.
Err... Why? We *really* want to continue supporting indirect tables, as
this is a massive memory saver for the guest.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>
> ---
>
> TODO: investigate support of 2 level tables, ie. enabling
> Indirect = 1. Support of 2 level tables is implementation
> defined.
Clearly, that's a regression. What exactly is the issue that decided you
to disable it?
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2017-01-12 17:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 15:56 [RFC 00/13] vITS save/restore Eric Auger
2017-01-12 15:56 ` Eric Auger
2017-01-12 15:56 ` [RFC 01/13] KVM: arm/arm64: Add vITS save/restore API documentation Eric Auger
2017-01-12 16:52 ` Marc Zyngier
2017-01-12 16:52 ` Marc Zyngier
2017-01-13 9:07 ` Auger Eric
2017-01-13 9:07 ` Auger Eric
2017-01-13 9:46 ` Marc Zyngier
2017-01-13 9:46 ` Marc Zyngier
2017-01-30 16:15 ` Auger Eric
2017-01-30 16:15 ` Auger Eric
2017-02-03 14:00 ` Peter Maydell
2017-02-03 14:00 ` Peter Maydell
2017-02-03 14:51 ` Marc Zyngier
2017-02-03 14:51 ` Marc Zyngier
2017-01-12 15:56 ` [RFC 02/13] arm/arm64: vgic: turn vgic_find_mmio_region into public Eric Auger
2017-01-12 15:56 ` [RFC 03/13] KVM: arm64: ITS: KVM_DEV_ARM_VGIC_GRP_ITS_REGS group Eric Auger
2017-01-12 15:56 ` [RFC 04/13] KVM: arm64: ITS: Implement vgic_its_has_attr_regs and attr_regs_access Eric Auger
2017-01-12 15:56 ` [RFC 05/13] KVM: arm64: ITS: Implement vgic_mmio_uaccess_write_its_creadr Eric Auger
2017-01-12 15:56 ` [RFC 06/13] KVM: arm64: ITS: Expose ITT_Entry_Size in GITS_TYPER Eric Auger
2017-01-12 17:06 ` Andre Przywara
2017-01-12 17:06 ` Andre Przywara
2017-01-13 8:31 ` Auger Eric
2017-01-13 8:31 ` Auger Eric
2017-01-12 15:56 ` [RFC 07/13] KVM: arm64: ITS: Change entry_size and indirect bit in BASER Eric Auger
2017-01-12 17:05 ` Marc Zyngier [this message]
2017-01-12 17:05 ` Marc Zyngier
2017-01-13 8:57 ` Auger Eric
2017-01-13 8:57 ` Auger Eric
2017-01-13 9:22 ` Marc Zyngier
2017-01-13 9:22 ` Marc Zyngier
2017-01-12 15:56 ` [RFC 08/13] KVM: arm64: ITS: On MAPD interpret and store itt_addr and size Eric Auger
2017-01-12 15:56 ` [RFC 09/13] KVM: arm64: ITS: KVM_DEV_ARM_VGIC_GRP_ITS_TABLES group Eric Auger
2017-01-12 15:56 ` [RFC 10/13] KVM: arm64: ITS: vgic_its_alloc_itte/device Eric Auger
2017-01-12 15:56 ` [RFC 11/13] KVM: arm64: ITS: Collection table save/restore Eric Auger
2017-01-12 15:56 ` [RFC 12/13] KVM: arm64: ITS: Device and translation table flush Eric Auger
2017-01-12 15:56 ` [RFC 13/13] KVM: arm64: ITS: Pending table save/restore Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc26dc19-313b-375b-0d9b-f4ff411a914f@arm.com \
--to=marc.zyngier@arm.com \
--cc=Prasun.Kapoor@cavium.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=andre.przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=vijayak@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.