Re: [PATCH v3 5/8] hw/mips/fuloong2e: Remove unused env entry

From: BALATON Zoltan via <qemu-devel@nongnu.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	qemu-devel@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH v3 5/8] hw/mips/fuloong2e: Remove unused env entry
Date: Thu, 24 Dec 2020 09:24:32 +0100 (CET)	[thread overview]
Message-ID: <dc4f6c6-ae89-4f43-1f88-8380c7ebd78f@eik.bme.hu> (raw)
In-Reply-To: <20201224031750.52146-6-jiaxun.yang@flygoat.com>

On Thu, 24 Dec 2020, Jiaxun Yang wrote:
> modetty is not handled by kernel and the parameter
> here seems unreasonable.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> v3: Bring busclock back
> ---
> hw/mips/fuloong2e.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c
> index d846ef7b00..c4843dd15e 100644
> --- a/hw/mips/fuloong2e.c
> +++ b/hw/mips/fuloong2e.c
> @@ -159,10 +159,8 @@ static uint64_t load_kernel(CPUMIPSState *env)
>     }
>
>     /* Setup minimum environment variables */
> -    prom_set(prom_buf, index++, "busclock=33000000");

Commit message does not mention removing this as well. Was this 
unintentionally left here?

Regards,
BALATON Zoltan

>     prom_set(prom_buf, index++, "cpuclock=100000000");
>     prom_set(prom_buf, index++, "memsize=%"PRIi64, loaderparams.ram_size / MiB);
> -    prom_set(prom_buf, index++, "modetty0=38400n8r");
>     prom_set(prom_buf, index++, NULL);
>
>     rom_add_blob_fixed("prom", prom_buf, prom_size, ENVP_PADDR);
>