* [PATCH] net: bridge: constify attribute_group structures.
@ 2017-06-29 11:10 ` Arvind Yadav
0 siblings, 0 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-06-29 11:09 UTC (permalink / raw)
To: stephen, davem, bridge; +Cc: netdev, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2645 896 0 3541 dd5 net/bridge/br_sysfs_br.o
File size After adding 'const':
text data bss dec hex filename
2701 832 0 3533 dcd net/bridge/br_sysfs_br.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
net/bridge/br_sysfs_br.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
index 0b5dd60..723f25e 100644
--- a/net/bridge/br_sysfs_br.c
+++ b/net/bridge/br_sysfs_br.c
@@ -865,7 +865,7 @@ static ssize_t vlan_stats_enabled_store(struct device *d,
NULL
};
-static struct attribute_group bridge_group = {
+static const struct attribute_group bridge_group = {
.name = SYSFS_BRIDGE_ATTR,
.attrs = bridge_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Bridge] [PATCH] net: bridge: constify attribute_group structures.
@ 2017-06-29 11:10 ` Arvind Yadav
0 siblings, 0 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-06-29 11:10 UTC (permalink / raw)
To: stephen, davem, bridge; +Cc: netdev, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2645 896 0 3541 dd5 net/bridge/br_sysfs_br.o
File size After adding 'const':
text data bss dec hex filename
2701 832 0 3533 dcd net/bridge/br_sysfs_br.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
net/bridge/br_sysfs_br.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
index 0b5dd60..723f25e 100644
--- a/net/bridge/br_sysfs_br.c
+++ b/net/bridge/br_sysfs_br.c
@@ -865,7 +865,7 @@ static ssize_t vlan_stats_enabled_store(struct device *d,
NULL
};
-static struct attribute_group bridge_group = {
+static const struct attribute_group bridge_group = {
.name = SYSFS_BRIDGE_ATTR,
.attrs = bridge_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: bridge: constify attribute_group structures.
2017-06-29 11:10 ` [Bridge] " Arvind Yadav
(?)
@ 2017-06-29 19:50 ` David Miller
-1 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-06-29 19:50 UTC (permalink / raw)
To: arvind.yadav.cs; +Cc: stephen, bridge, netdev, linux-kernel
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Thu, 29 Jun 2017 16:39:38 +0530
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2645 896 0 3541 dd5 net/bridge/br_sysfs_br.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2701 832 0 3533 dcd net/bridge/br_sysfs_br.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: bridge: constify attribute_group structures.
@ 2017-06-29 19:50 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-06-29 19:50 UTC (permalink / raw)
To: arvind.yadav.cs; +Cc: netdev, bridge, linux-kernel
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Thu, 29 Jun 2017 16:39:38 +0530
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2645 896 0 3541 dd5 net/bridge/br_sysfs_br.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2701 832 0 3533 dcd net/bridge/br_sysfs_br.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bridge] [PATCH] net: bridge: constify attribute_group structures.
@ 2017-06-29 19:50 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-06-29 19:50 UTC (permalink / raw)
To: arvind.yadav.cs; +Cc: netdev, bridge, linux-kernel
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Thu, 29 Jun 2017 16:39:38 +0530
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2645 896 0 3541 dd5 net/bridge/br_sysfs_br.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2701 832 0 3533 dcd net/bridge/br_sysfs_br.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-29 19:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 11:09 [PATCH] net: bridge: constify attribute_group structures Arvind Yadav
2017-06-29 11:10 ` [Bridge] " Arvind Yadav
2017-06-29 19:50 ` David Miller
2017-06-29 19:50 ` [Bridge] " David Miller
2017-06-29 19:50 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.