* [net-next][PATCH] tcp: probe timer MUST not less than 5 minuter for tcp PMTU
@ 2018-06-01 11:03 Li RongQing
2018-06-02 10:19 ` Eric Dumazet
2018-06-04 14:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Li RongQing @ 2018-06-01 11:03 UTC (permalink / raw)
To: netdev
RFC4821 say: The value for this timer MUST NOT be less than
5 minutes and is recommended to be 10 minutes, per RFC 1981.
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
net/ipv4/sysctl_net_ipv4.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index d2eed3ddcb0a..ed8952bb6874 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -47,6 +47,7 @@ static int tcp_syn_retries_max = MAX_TCP_SYNCNT;
static int ip_ping_group_range_min[] = { 0, 0 };
static int ip_ping_group_range_max[] = { GID_T_MAX, GID_T_MAX };
static int comp_sack_nr_max = 255;
+static int tcp_probe_interval_min = 300;
/* obsolete */
static int sysctl_tcp_low_latency __read_mostly;
@@ -711,7 +712,8 @@ static struct ctl_table ipv4_net_table[] = {
.data = &init_net.ipv4.sysctl_tcp_probe_interval,
.maxlen = sizeof(int),
.mode = 0644,
- .proc_handler = proc_dointvec,
+ .proc_handler = proc_dointvec_minmax,
+ .extra1 = &tcp_probe_interval_min,
},
{
.procname = "igmp_link_local_mcast_reports",
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next][PATCH] tcp: probe timer MUST not less than 5 minuter for tcp PMTU
2018-06-01 11:03 [net-next][PATCH] tcp: probe timer MUST not less than 5 minuter for tcp PMTU Li RongQing
@ 2018-06-02 10:19 ` Eric Dumazet
2018-06-04 14:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2018-06-02 10:19 UTC (permalink / raw)
To: Li RongQing, netdev
On 06/01/2018 07:03 AM, Li RongQing wrote:
> RFC4821 say: The value for this timer MUST NOT be less than
> 5 minutes and is recommended to be 10 minutes, per RFC 1981.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> net/ipv4/sysctl_net_ipv4.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
> index d2eed3ddcb0a..ed8952bb6874 100644
> --- a/net/ipv4/sysctl_net_ipv4.c
> +++ b/net/ipv4/sysctl_net_ipv4.c
> @@ -47,6 +47,7 @@ static int tcp_syn_retries_max = MAX_TCP_SYNCNT;
> static int ip_ping_group_range_min[] = { 0, 0 };
> static int ip_ping_group_range_max[] = { GID_T_MAX, GID_T_MAX };
> static int comp_sack_nr_max = 255;
> +static int tcp_probe_interval_min = 300;
>
> /* obsolete */
> static int sysctl_tcp_low_latency __read_mostly;
> @@ -711,7 +712,8 @@ static struct ctl_table ipv4_net_table[] = {
> .data = &init_net.ipv4.sysctl_tcp_probe_interval,
> .maxlen = sizeof(int),
> .mode = 0644,
> - .proc_handler = proc_dointvec,
> + .proc_handler = proc_dointvec_minmax,
> + .extra1 = &tcp_probe_interval_min,
> },
> {
> .procname = "igmp_link_local_mcast_reports",
>
Note that this change would stop people from being able to have packetdrill
tests which would run in a reasonable amount of time.
I do not believe linux kernel must enforce such a limit.
It is up to the admin to set a value here really, depending on the environment
the host is running in.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next][PATCH] tcp: probe timer MUST not less than 5 minuter for tcp PMTU
2018-06-01 11:03 [net-next][PATCH] tcp: probe timer MUST not less than 5 minuter for tcp PMTU Li RongQing
2018-06-02 10:19 ` Eric Dumazet
@ 2018-06-04 14:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-06-04 14:59 UTC (permalink / raw)
To: lirongqing; +Cc: netdev
From: Li RongQing <lirongqing@baidu.com>
Date: Fri, 1 Jun 2018 19:03:59 +0800
> RFC4821 say: The value for this timer MUST NOT be less than
> 5 minutes and is recommended to be 10 minutes, per RFC 1981.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
As Eric stated, admins should be allowed to set this however they
wish (f.e. for specialized tests).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-04 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-01 11:03 [net-next][PATCH] tcp: probe timer MUST not less than 5 minuter for tcp PMTU Li RongQing
2018-06-02 10:19 ` Eric Dumazet
2018-06-04 14:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.