From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Viorel Suman <viorel.suman@nxp.com> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Dong Aisheng <aisheng.dong@nxp.com>, Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>, Stefan Agner <stefan@agner.ch>, Pengutronix Kernel Team <kernel@pengutronix.de>, Linus Walleij <linus.walleij@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, Sascha Hauer <s.hauer@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, Abel Vesa <abelvesa@kernel.org>, Oliver Graute <oliver.graute@kococonnector.com>, Mirela Rabulea <mirela.rabulea@nxp.com>, Peng Fan <peng.fan@nxp.com>, Liu Ying <victor.liu@nxp.com>, Ming Qian <ming.qian@nxp.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abel Vesa <abel.vesa@nxp.com> Subject: Re: [PATCH v5 10/14] dt-bindings: firmware: Add fsl,scu yaml file Date: Mon, 27 Jun 2022 14:06:19 +0200 [thread overview] Message-ID: <dca6534e-2601-a943-b6a8-2593f7fc64eb@linaro.org> (raw) In-Reply-To: <20220627114949.pg7az36fz4jrwebp@fsr-ub1664-116> On 27/06/2022 13:49, Viorel Suman wrote: > On 22-06-24 12:25:44, Krzysztof Kozlowski wrote: >> On 16/06/2022 18:42, Viorel Suman wrote: >>> From: Abel Vesa <abel.vesa@nxp.com> >>> >>> In order to replace the fsl,scu txt file from bindings/arm/freescale, >>> we need to split it between the right subsystems. This patch adds the >>> fsl,scu.yaml in the firmware bindings folder. This one is only for >>> the main SCU node. The old txt file will be removed only after all >>> the child nodes have been properly switch to yaml. >>> >>> Signed-off-by: Abel Vesa <abel.vesa@nxp.com> >>> Signed-off-by: Viorel Suman <viorel.suman@nxp.com> >>> --- >>> .../devicetree/bindings/firmware/fsl,scu.yaml | 170 ++++++++++++++++++ >>> 1 file changed, 170 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/firmware/fsl,scu.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml > > [...] > >>> +properties: >>> + $nodename: >>> + const: 'scu' >> >> Why enforcing node name? Second point is that node names should be >> generic, so I wonder what "SCU" exactly means and whether it is generic? >> > > It stands for "System Control Unit" - looks generic to me. Nope, it's specific, just like other scu - Snoop Control Unit. What's more, reusing the same acronym leads to confusions. If it was generic, then I expect it to be present in several other places, but it's not (except the other SCU). Generic name is for example "system-controller". > I guess a reason to enforce it - need to check with Abel - might be > the need to group multiple SCU implementations under a common known name. Device bindings do not enforce the names, unless it's really needed, and I doubt there is a need here. Just drop it and rename nodes in DTS to something generic. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Viorel Suman <viorel.suman@nxp.com> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Dong Aisheng <aisheng.dong@nxp.com>, Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>, Stefan Agner <stefan@agner.ch>, Pengutronix Kernel Team <kernel@pengutronix.de>, Linus Walleij <linus.walleij@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, Sascha Hauer <s.hauer@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, Abel Vesa <abelvesa@kernel.org>, Oliver Graute <oliver.graute@kococonnector.com>, Mirela Rabulea <mirela.rabulea@nxp.com>, Peng Fan <peng.fan@nxp.com>, Liu Ying <victor.liu@nxp.com>, Ming Qian <ming.qian@nxp.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abel Vesa <abel.vesa@nxp.com> Subject: Re: [PATCH v5 10/14] dt-bindings: firmware: Add fsl,scu yaml file Date: Mon, 27 Jun 2022 14:06:19 +0200 [thread overview] Message-ID: <dca6534e-2601-a943-b6a8-2593f7fc64eb@linaro.org> (raw) In-Reply-To: <20220627114949.pg7az36fz4jrwebp@fsr-ub1664-116> On 27/06/2022 13:49, Viorel Suman wrote: > On 22-06-24 12:25:44, Krzysztof Kozlowski wrote: >> On 16/06/2022 18:42, Viorel Suman wrote: >>> From: Abel Vesa <abel.vesa@nxp.com> >>> >>> In order to replace the fsl,scu txt file from bindings/arm/freescale, >>> we need to split it between the right subsystems. This patch adds the >>> fsl,scu.yaml in the firmware bindings folder. This one is only for >>> the main SCU node. The old txt file will be removed only after all >>> the child nodes have been properly switch to yaml. >>> >>> Signed-off-by: Abel Vesa <abel.vesa@nxp.com> >>> Signed-off-by: Viorel Suman <viorel.suman@nxp.com> >>> --- >>> .../devicetree/bindings/firmware/fsl,scu.yaml | 170 ++++++++++++++++++ >>> 1 file changed, 170 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/firmware/fsl,scu.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml > > [...] > >>> +properties: >>> + $nodename: >>> + const: 'scu' >> >> Why enforcing node name? Second point is that node names should be >> generic, so I wonder what "SCU" exactly means and whether it is generic? >> > > It stands for "System Control Unit" - looks generic to me. Nope, it's specific, just like other scu - Snoop Control Unit. What's more, reusing the same acronym leads to confusions. If it was generic, then I expect it to be present in several other places, but it's not (except the other SCU). Generic name is for example "system-controller". > I guess a reason to enforce it - need to check with Abel - might be > the need to group multiple SCU implementations under a common known name. Device bindings do not enforce the names, unless it's really needed, and I doubt there is a need here. Just drop it and rename nodes in DTS to something generic. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-27 12:08 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-16 16:42 [PATCH v5 00/14] dt-bindings: arm: freescale: Switch fsl,scu from txt to yaml Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-16 16:42 ` [PATCH v5 01/14] arm64: dts: freescale: imx8qxp: Fix thermal zone name for cpu0 Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-16 16:42 ` [PATCH v5 02/14] dt-bindings: clk: imx: Add fsl,scu-clk yaml file Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:05 ` Krzysztof Kozlowski 2022-06-24 10:05 ` Krzysztof Kozlowski 2022-06-16 16:42 ` [PATCH v5 03/14] dt-bindings: pinctrl: imx: Add fsl,scu-iomux " Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:09 ` Krzysztof Kozlowski 2022-06-24 10:09 ` Krzysztof Kozlowski 2022-06-16 16:42 ` [PATCH v5 04/14] dt-bindings: input: Add fsl,scu-key " Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:14 ` Krzysztof Kozlowski 2022-06-24 10:14 ` Krzysztof Kozlowski 2022-06-16 16:42 ` [PATCH v5 05/14] dt-bindings: nvmem: Add fsl,scu-ocotp " Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:15 ` Krzysztof Kozlowski 2022-06-24 10:15 ` Krzysztof Kozlowski 2022-06-16 16:42 ` [PATCH v5 06/14] dt-bindings: power: Add fsl,scu-pd " Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:16 ` Krzysztof Kozlowski 2022-06-24 10:16 ` Krzysztof Kozlowski 2022-06-16 16:42 ` [PATCH v5 07/14] dt-bindings: rtc: Add fsl,scu-rtc " Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:17 ` Krzysztof Kozlowski 2022-06-24 10:17 ` Krzysztof Kozlowski 2022-06-16 16:42 ` [PATCH v5 08/14] dt-bindings: thermal: Add fsl,scu-thermal " Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:18 ` Krzysztof Kozlowski 2022-06-24 10:18 ` Krzysztof Kozlowski 2022-06-16 16:42 ` [PATCH v5 09/14] dt-bindings: watchdog: Add fsl,scu-wdt " Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:19 ` Krzysztof Kozlowski 2022-06-24 10:19 ` Krzysztof Kozlowski 2022-06-16 16:42 ` [PATCH v5 10/14] dt-bindings: firmware: Add fsl,scu " Viorel Suman 2022-06-16 16:42 ` Viorel Suman 2022-06-24 10:25 ` Krzysztof Kozlowski 2022-06-24 10:25 ` Krzysztof Kozlowski 2022-06-27 11:49 ` Viorel Suman 2022-06-27 11:49 ` Viorel Suman 2022-06-27 12:06 ` Krzysztof Kozlowski [this message] 2022-06-27 12:06 ` Krzysztof Kozlowski 2022-06-16 16:43 ` [PATCH v5 11/14] arm64: dts: freescale: imx8: Fix power controller name Viorel Suman 2022-06-16 16:43 ` Viorel Suman 2022-06-16 16:43 ` [PATCH v5 12/14] arm64: dts: freescale: imx8qxp: Add fallback compatible for clock controller Viorel Suman 2022-06-16 16:43 ` Viorel Suman 2022-06-16 16:43 ` [PATCH v5 13/14] arm64: dts: freescale: imx8qxp: Fix the keys node name Viorel Suman 2022-06-16 16:43 ` Viorel Suman 2022-06-16 16:43 ` [PATCH v5 14/14] dt-bindings: arm: freescale: Remove fsl,scu txt file Viorel Suman 2022-06-16 16:43 ` Viorel Suman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dca6534e-2601-a943-b6a8-2593f7fc64eb@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=a.zummo@towertech.it \ --cc=abel.vesa@nxp.com \ --cc=abelvesa@kernel.org \ --cc=aisheng.dong@nxp.com \ --cc=alexandre.belloni@bootlin.com \ --cc=amitk@kernel.org \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=ming.qian@nxp.com \ --cc=mirela.rabulea@nxp.com \ --cc=mturquette@baylibre.com \ --cc=oliver.graute@kococonnector.com \ --cc=peng.fan@nxp.com \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=stefan@agner.ch \ --cc=victor.liu@nxp.com \ --cc=viorel.suman@nxp.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.