* status="ok" treated as disabled by DM
@ 2021-08-19 11:03 Roger Quadros
2021-08-19 11:37 ` Nishanth Menon
0 siblings, 1 reply; 3+ messages in thread
From: Roger Quadros @ 2021-08-19 11:03 UTC (permalink / raw)
To: simon Glass; +Cc: U-Boot, Lokesh Vutla, Nishanth Menon
Hi,
If the device tree node has status="ok" then the u-boot DM will treat the device as disabled.
There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound.
What is the right fix?
1) make u-boot DM to treat satus="ok" as enabled.
2) fix device tree by changing "ok" to "okay".
cheers,
-roger
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: status="ok" treated as disabled by DM
2021-08-19 11:03 status="ok" treated as disabled by DM Roger Quadros
@ 2021-08-19 11:37 ` Nishanth Menon
2021-08-20 10:01 ` Roger Quadros
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2021-08-19 11:37 UTC (permalink / raw)
To: Roger Quadros; +Cc: simon Glass, U-Boot, Lokesh Vutla
On 14:03-20210819, Roger Quadros wrote:
> Hi,
>
> If the device tree node has status="ok" then the u-boot DM will treat the device as disabled.
> There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound.
>
> What is the right fix?
> 1) make u-boot DM to treat satus="ok" as enabled.
> 2) fix device tree by changing "ok" to "okay".
>
> cheers,
> -roger
https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36
I believe, the correct fix is (2) change the dt to "okay".
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: status="ok" treated as disabled by DM
2021-08-19 11:37 ` Nishanth Menon
@ 2021-08-20 10:01 ` Roger Quadros
0 siblings, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2021-08-20 10:01 UTC (permalink / raw)
To: Nishanth Menon; +Cc: simon Glass, U-Boot, Lokesh Vutla
On 19/08/2021 14:37, Nishanth Menon wrote:
> On 14:03-20210819, Roger Quadros wrote:
>> Hi,
>>
>> If the device tree node has status="ok" then the u-boot DM will treat the device as disabled.
>> There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound.
>>
>> What is the right fix?
>> 1) make u-boot DM to treat satus="ok" as enabled.
>> 2) fix device tree by changing "ok" to "okay".
>>
>> cheers,
>> -roger
> https://github.com/devicetree-org/dt-schema/blob/master/schemas/dt-core.yaml#L36
>
>
> I believe, the correct fix is (2) change the dt to "okay".
>
Also in u-boot code it does mention to fix DT node status to "okay".
https://elixir.bootlin.com/u-boot/v2021.07/source/lib/fdtdec.c#L278
--
cheers,
-roger
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-20 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 11:03 status="ok" treated as disabled by DM Roger Quadros
2021-08-19 11:37 ` Nishanth Menon
2021-08-20 10:01 ` Roger Quadros
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.