[PATCH] block: mark blkdev_fsync static

[PATCH] block: mark blkdev_fsync static

[Christoph Hellwig]

blkdev_fsync is only used inside of block_dev.c since the
removal of the raw drіver.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/block_dev.c     | 4 ++--
 include/linux/fs.h | 4 ----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 7b8deda57e74..45df6cbccf12 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -689,7 +689,8 @@ static loff_t block_llseek(struct file *file, loff_t offset, int whence)
 	return retval;
 }
 	
-int blkdev_fsync(struct file *filp, loff_t start, loff_t end, int datasync)
+static int blkdev_fsync(struct file *filp, loff_t start, loff_t end,
+		int datasync)
 {
 	struct inode *bd_inode = bdev_file_inode(filp);
 	struct block_device *bdev = I_BDEV(bd_inode);
@@ -710,7 +711,6 @@ int blkdev_fsync(struct file *filp, loff_t start, loff_t end, int datasync)
 
 	return error;
 }
-EXPORT_SYMBOL(blkdev_fsync);
 
 /**
  * bdev_read_page() - Start reading a page from a block device
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 96a0affa7b2d..0e49b0e9b943 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3249,10 +3249,6 @@ ssize_t vfs_iocb_iter_read(struct file *file, struct kiocb *iocb,
 ssize_t vfs_iocb_iter_write(struct file *file, struct kiocb *iocb,
 			    struct iov_iter *iter);
 
-/* fs/block_dev.c */
-extern int blkdev_fsync(struct file *filp, loff_t start, loff_t end,
-			int datasync);
-
 /* fs/splice.c */
 extern ssize_t generic_file_splice_read(struct file *, loff_t *,
 		struct pipe_inode_info *, size_t, unsigned int);
-- 
2.30.2

Re: [PATCH] block: mark blkdev_fsync static

[Jens Axboe]

On 8/24/21 9:18 AM, Christoph Hellwig wrote:
> blkdev_fsync is only used inside of block_dev.c since the
> removal of the raw drіver.

Applied, thanks.

-- 
Jens Axboe