From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property
Date: Wed, 31 Aug 2022 10:52:38 +0300 [thread overview]
Message-ID: <dcd25b00-f2e6-311c-fc1d-6175158f32b3@linaro.org> (raw)
In-Reply-To: <20220831073622.5bp3ftf3fkea5rdk@pali>
On 31/08/2022 10:36, Pali Rohár wrote:
> On Wednesday 31 August 2022 10:31:22 Krzysztof Kozlowski wrote:
>> On 31/08/2022 02:00, Pali Rohár wrote:
>>> This new optional priority property allows to specify custom priority level
>>> of reset device. Default level was always 192.
>>
>> You still did not explain why do we need this. You only explained what
>> you did here, which is obvious and visible from the diff. What you
>> should explain is why you are doing it, what problem you are solving.
>>
>> Best regards,
>> Krzysztof
>
> Look at patch 3/3, thanks.
This commit should explain it why you add new property. Some other
commits going via different trees/branches and ending up in entirely
different time/place in history do not really count.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Marek Behún" <kabel@kernel.org>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property
Date: Wed, 31 Aug 2022 10:52:38 +0300 [thread overview]
Message-ID: <dcd25b00-f2e6-311c-fc1d-6175158f32b3@linaro.org> (raw)
In-Reply-To: <20220831073622.5bp3ftf3fkea5rdk@pali>
On 31/08/2022 10:36, Pali Rohár wrote:
> On Wednesday 31 August 2022 10:31:22 Krzysztof Kozlowski wrote:
>> On 31/08/2022 02:00, Pali Rohár wrote:
>>> This new optional priority property allows to specify custom priority level
>>> of reset device. Default level was always 192.
>>
>> You still did not explain why do we need this. You only explained what
>> you did here, which is obvious and visible from the diff. What you
>> should explain is why you are doing it, what problem you are solving.
>>
>> Best regards,
>> Krzysztof
>
> Look at patch 3/3, thanks.
This commit should explain it why you add new property. Some other
commits going via different trees/branches and ending up in entirely
different time/place in history do not really count.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-31 7:53 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 10:29 [PATCH 1/3] dt-bindings: reset: syscon-reboot: Add priority property Pali Rohár
2022-08-20 10:29 ` Pali Rohár
2022-08-20 10:29 ` [PATCH 2/3] power: reset: syscon-reboot: Add support for specifying priority Pali Rohár
2022-08-20 10:29 ` Pali Rohár
2022-08-20 10:29 ` [PATCH 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot Pali Rohár
2022-08-20 10:29 ` Pali Rohár
2022-08-21 20:21 ` [PATCH 1/3] dt-bindings: reset: syscon-reboot: Add priority property Rob Herring
2022-08-21 20:21 ` Rob Herring
2022-08-22 12:47 ` Rob Herring
2022-08-22 12:47 ` Rob Herring
2022-08-22 13:50 ` Pali Rohár
2022-08-22 13:50 ` Pali Rohár
2022-09-02 20:37 ` Rob Herring
2022-09-07 12:27 ` Krzysztof Kozlowski
2022-08-30 23:00 ` [PATCH v2 " Pali Rohár
2022-08-30 23:00 ` Pali Rohár
2022-08-30 23:00 ` [PATCH v2 2/3] power: reset: syscon-reboot: Add support for specifying priority Pali Rohár
2022-08-30 23:00 ` Pali Rohár
2022-08-30 23:00 ` [PATCH v2 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot Pali Rohár
2022-08-30 23:00 ` Pali Rohár
2022-08-31 7:26 ` [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property Arnd Bergmann
2022-09-02 20:40 ` Rob Herring
2022-08-31 7:31 ` Krzysztof Kozlowski
2022-08-31 7:31 ` Krzysztof Kozlowski
2022-08-31 7:36 ` Pali Rohár
2022-08-31 7:36 ` Pali Rohár
2022-08-31 7:52 ` Krzysztof Kozlowski [this message]
2022-08-31 7:52 ` Krzysztof Kozlowski
2022-08-31 8:17 ` [PATCH v3 " Pali Rohár
2022-08-31 8:17 ` Pali Rohár
2022-08-31 8:17 ` [PATCH v3 2/3] power: reset: syscon-reboot: Add support for specifying priority Pali Rohár
2022-08-31 8:17 ` Pali Rohár
2022-08-31 8:17 ` [PATCH v3 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot Pali Rohár
2022-08-31 8:17 ` Pali Rohár
2022-09-07 12:38 ` [PATCH v3 1/3] dt-bindings: reset: syscon-reboot: Add priority property Krzysztof Kozlowski
2022-09-07 12:38 ` Krzysztof Kozlowski
2022-09-07 16:33 ` Pali Rohár
2022-09-07 16:33 ` Pali Rohár
2022-09-08 7:26 ` Krzysztof Kozlowski
2022-09-08 7:26 ` Krzysztof Kozlowski
2022-12-26 11:45 ` [PATCH v4 " Pali Rohár
2022-12-26 11:45 ` [PATCH v4 2/3] power: reset: syscon-reboot: Add support for specifying priority Pali Rohár
2022-12-26 11:45 ` [PATCH v4 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot Pali Rohár
2022-12-26 11:45 ` Pali Rohár
2023-02-09 0:10 ` Pali Rohár
2023-02-09 0:10 ` Pali Rohár
2023-02-18 12:05 ` Pali Rohár
2023-02-18 12:05 ` Pali Rohár
2023-02-20 0:55 ` Michael Ellerman
2023-02-20 0:55 ` Michael Ellerman
2022-12-26 12:02 ` [PATCH v4 1/3] dt-bindings: reset: syscon-reboot: Add priority property Krzysztof Kozlowski
2022-12-26 18:23 ` Rob Herring
2023-01-22 11:27 ` Pali Rohár
2023-02-03 12:16 ` Sebastian Reichel
2023-02-03 12:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd25b00-f2e6-311c-fc1d-6175158f32b3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.