platform_ops.malloc() vs. realloc()

platform_ops.malloc() vs. realloc()

[Geert Uytterhoeven]

arch/powerpc/boot/ops.h has:

| /* Platform specific operations */
| struct platform_ops {
|         void    (*fixups)(void);
|         void    (*image_hdr)(const void *);
|         void *  (*malloc)(u32 size);
|         void    (*free)(void *ptr);
|         void *  (*realloc)(void *ptr, unsigned long size);
|         void    (*exit)(void);
| };

Is there a specific reason why the size parameters of malloc() and realloc()
differ in type?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

Re: platform_ops.malloc() vs. realloc()

[David Gibson]

On Thu, Feb 22, 2007 at 11:14:36AM +0100, Geert Uytterhoeven wrote:
> 
> arch/powerpc/boot/ops.h has:
> 
> | /* Platform specific operations */
> | struct platform_ops {
> |         void    (*fixups)(void);
> |         void    (*image_hdr)(const void *);
> |         void *  (*malloc)(u32 size);
> |         void    (*free)(void *ptr);
> |         void *  (*realloc)(void *ptr, unsigned long size);
> |         void    (*exit)(void);
> | };
> 
> Is there a specific reason why the size parameters of malloc() and realloc()
> differ in type?

Not as far as I'm aware, I believe it's just a wart.  The zImage is
always compiler 32-bit, so they're actually the same thing.  I'm
actually hoping to get rid of malloc() and realloc() at some point.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: platform_ops.malloc() vs. realloc()

[Segher Boessenkool]

> |         void *  (*malloc)(u32 size);

> |         void *  (*realloc)(void *ptr, unsigned long size);

> Is there a specific reason why the size parameters of malloc() and 
> realloc()
> differ in type?

There are good arguments to prefer either u32 or unsigned
long, so maybe the current situation is a compromise ;-P


Segher