* [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone
@ 2019-11-15 12:42 Jiri Benc
2019-11-15 13:08 ` Toke Høiland-Jørgensen
2019-11-15 22:06 ` Daniel Borkmann
0 siblings, 2 replies; 6+ messages in thread
From: Jiri Benc @ 2019-11-15 12:42 UTC (permalink / raw)
To: bpf, netdev; +Cc: Alan Maguire
The actual test to run is test_xdping.sh, which is already in TEST_PROGS.
The xdping program alone is not runnable with 'make run_tests', it
immediatelly fails due to missing arguments.
Move xdping to TEST_GEN_PROGS_EXTENDED in order to be built but not run.
Fixes: cd5385029f1d ("selftests/bpf: measure RTT from xdp using xdping")
Cc: Alan Maguire <alan.maguire@oracle.com>
Signed-off-by: Jiri Benc <jbenc@redhat.com>
---
tools/testing/selftests/bpf/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index 6889c19a628c..99193a241bc7 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -29,7 +29,7 @@ TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test
test_sock test_btf test_sockmap get_cgroup_id_user test_socket_cookie \
test_cgroup_storage test_select_reuseport test_section_names \
test_netcnt test_tcpnotify_user test_sock_fields test_sysctl test_hashmap \
- test_btf_dump test_cgroup_attach xdping
+ test_btf_dump test_cgroup_attach
BPF_OBJ_FILES = $(patsubst %.c,%.o, $(notdir $(wildcard progs/*.c)))
TEST_GEN_FILES = $(BPF_OBJ_FILES)
@@ -82,7 +82,7 @@ TEST_PROGS_EXTENDED := with_addr.sh \
# Compile but not part of 'make run_tests'
TEST_GEN_PROGS_EXTENDED = test_libbpf_open test_sock_addr test_skb_cgroup_id_user \
flow_dissector_load test_flow_dissector test_tcp_check_syncookie_user \
- test_lirc_mode2_user
+ test_lirc_mode2_user xdping
include ../lib.mk
--
2.18.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone
2019-11-15 12:42 [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone Jiri Benc
@ 2019-11-15 13:08 ` Toke Høiland-Jørgensen
2019-11-15 14:03 ` Alan Maguire
2019-11-15 22:06 ` Daniel Borkmann
1 sibling, 1 reply; 6+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-11-15 13:08 UTC (permalink / raw)
To: Jiri Benc, bpf, netdev; +Cc: Alan Maguire
Jiri Benc <jbenc@redhat.com> writes:
> The actual test to run is test_xdping.sh, which is already in TEST_PROGS.
> The xdping program alone is not runnable with 'make run_tests', it
> immediatelly fails due to missing arguments.
>
> Move xdping to TEST_GEN_PROGS_EXTENDED in order to be built but not run.
>
> Fixes: cd5385029f1d ("selftests/bpf: measure RTT from xdp using xdping")
> Cc: Alan Maguire <alan.maguire@oracle.com>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone
2019-11-15 13:08 ` Toke Høiland-Jørgensen
@ 2019-11-15 14:03 ` Alan Maguire
0 siblings, 0 replies; 6+ messages in thread
From: Alan Maguire @ 2019-11-15 14:03 UTC (permalink / raw)
To: Toke Høiland-Jørgensen; +Cc: Jiri Benc, bpf, netdev, Alan Maguire
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On Fri, 15 Nov 2019, Toke Høiland-Jørgensen wrote:
> Jiri Benc <jbenc@redhat.com> writes:
>
> > The actual test to run is test_xdping.sh, which is already in TEST_PROGS.
> > The xdping program alone is not runnable with 'make run_tests', it
> > immediatelly fails due to missing arguments.
> >
> > Move xdping to TEST_GEN_PROGS_EXTENDED in order to be built but not run.
> >
> > Fixes: cd5385029f1d ("selftests/bpf: measure RTT from xdp using xdping")
> > Cc: Alan Maguire <alan.maguire@oracle.com>
> > Signed-off-by: Jiri Benc <jbenc@redhat.com>
>
> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
>
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone
2019-11-15 12:42 [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone Jiri Benc
2019-11-15 13:08 ` Toke Høiland-Jørgensen
@ 2019-11-15 22:06 ` Daniel Borkmann
2019-11-18 8:18 ` Jiri Benc
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Borkmann @ 2019-11-15 22:06 UTC (permalink / raw)
To: Jiri Benc, bpf, netdev; +Cc: Alan Maguire
On 11/15/19 1:42 PM, Jiri Benc wrote:
> The actual test to run is test_xdping.sh, which is already in TEST_PROGS.
> The xdping program alone is not runnable with 'make run_tests', it
> immediatelly fails due to missing arguments.
>
> Move xdping to TEST_GEN_PROGS_EXTENDED in order to be built but not run.
>
> Fixes: cd5385029f1d ("selftests/bpf: measure RTT from xdp using xdping")
> Cc: Alan Maguire <alan.maguire@oracle.com>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
Any objections if I take this to bpf-next as otherwise this will create an ugly
merge conflict between bpf and bpf-next given selftests have been heavily reworked
in there.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone
2019-11-15 22:06 ` Daniel Borkmann
@ 2019-11-18 8:18 ` Jiri Benc
2019-11-18 9:39 ` Daniel Borkmann
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Benc @ 2019-11-18 8:18 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: bpf, netdev, Alan Maguire
On Fri, 15 Nov 2019 23:06:13 +0100, Daniel Borkmann wrote:
> Any objections if I take this to bpf-next as otherwise this will create an ugly
> merge conflict between bpf and bpf-next given selftests have been heavily reworked
> in there.
Should I resend against bpf-next?
Jiri
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone
2019-11-18 8:18 ` Jiri Benc
@ 2019-11-18 9:39 ` Daniel Borkmann
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Borkmann @ 2019-11-18 9:39 UTC (permalink / raw)
To: Jiri Benc; +Cc: bpf, netdev, Alan Maguire
On 11/18/19 9:18 AM, Jiri Benc wrote:
> On Fri, 15 Nov 2019 23:06:13 +0100, Daniel Borkmann wrote:
>> Any objections if I take this to bpf-next as otherwise this will create an ugly
>> merge conflict between bpf and bpf-next given selftests have been heavily reworked
>> in there.
>
> Should I resend against bpf-next?
I can take care of it today, no need.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-18 9:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 12:42 [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone Jiri Benc
2019-11-15 13:08 ` Toke Høiland-Jørgensen
2019-11-15 14:03 ` Alan Maguire
2019-11-15 22:06 ` Daniel Borkmann
2019-11-18 8:18 ` Jiri Benc
2019-11-18 9:39 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.