From: Randy Dunlap <rdunlap@infradead.org> To: Masahiro Yamada <masahiroy@kernel.org> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Michal Marek <michal.lkml@markovi.net>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, linux-um@lists.infradead.org Subject: Re: [PATCH] uml: fix W=1 missing-include-dirs warnings Date: Thu, 15 Apr 2021 09:03:39 -0700 [thread overview] Message-ID: <dd054f33-beb8-317c-87f0-81badf087aa2@infradead.org> (raw) In-Reply-To: <CAK7LNAS2C1drA+v9q-mYHAbO3+4zjEdF_SJkBDtCXRExLX9u6w@mail.gmail.com> On 4/15/21 12:04 AM, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:02 PM Randy Dunlap <rdunlap@infradead.org> wrote: >> >> On 4/14/21 11:52 PM, Masahiro Yamada wrote: >>> On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap <rdunlap@infradead.org> wrote: >>>> >>>> Currently when using "W=1" with UML builds, there are over 700 warnings >>>> like so: >>>> >>>> CC arch/um/drivers/stderr_console.o >>>> cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] >>>> >>>> but arch/um/ does not have include/uapi/ at all, so don't >>>> include arch/um/include/uapi/ in USERINCLUDE for UML. >> >> >>>> Option 4: simply mkdir arch/um/include/uapi >>>> That's what I did first, just as a test, and it works. >>> >>> >>> I like Option 4. >>> >>> But, you cannot do "mkdir -p arch/um/include/uapi" at build-time >>> because the build system should not touch the source tree(, which >>> might be read-only) >>> for O= building. >>> >>> How about adding >>> >>> arch/um/include/uapi/asm/Kbuild, >>> >>> which is just having a SPDX one-liner? >> >> Wow! :) >> That's what Al Viro suggested also. >> I'll submit that patch later today (Thursday my time). >> >> thanks. >> -- >> ~Randy >> > > > BTW, after fixing this UML problem, > can we move -Wmissing-include-dirs to the top Makefile? I don't see why not. And eventually remove this one: fs/btrfs/Makefile:subdir-ccflags-y += -Wmissing-include-dirs > Is there any other source of -Wmissing-include-dirs > warnings? I can't give a full answer on that; only that I haven't seen any others and also that all other arch/*/include/ do have a uapi/ subdir. -- ~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: Masahiro Yamada <masahiroy@kernel.org> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Michal Marek <michal.lkml@markovi.net>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, linux-um@lists.infradead.org Subject: Re: [PATCH] uml: fix W=1 missing-include-dirs warnings Date: Thu, 15 Apr 2021 09:03:39 -0700 [thread overview] Message-ID: <dd054f33-beb8-317c-87f0-81badf087aa2@infradead.org> (raw) In-Reply-To: <CAK7LNAS2C1drA+v9q-mYHAbO3+4zjEdF_SJkBDtCXRExLX9u6w@mail.gmail.com> On 4/15/21 12:04 AM, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:02 PM Randy Dunlap <rdunlap@infradead.org> wrote: >> >> On 4/14/21 11:52 PM, Masahiro Yamada wrote: >>> On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap <rdunlap@infradead.org> wrote: >>>> >>>> Currently when using "W=1" with UML builds, there are over 700 warnings >>>> like so: >>>> >>>> CC arch/um/drivers/stderr_console.o >>>> cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] >>>> >>>> but arch/um/ does not have include/uapi/ at all, so don't >>>> include arch/um/include/uapi/ in USERINCLUDE for UML. >> >> >>>> Option 4: simply mkdir arch/um/include/uapi >>>> That's what I did first, just as a test, and it works. >>> >>> >>> I like Option 4. >>> >>> But, you cannot do "mkdir -p arch/um/include/uapi" at build-time >>> because the build system should not touch the source tree(, which >>> might be read-only) >>> for O= building. >>> >>> How about adding >>> >>> arch/um/include/uapi/asm/Kbuild, >>> >>> which is just having a SPDX one-liner? >> >> Wow! :) >> That's what Al Viro suggested also. >> I'll submit that patch later today (Thursday my time). >> >> thanks. >> -- >> ~Randy >> > > > BTW, after fixing this UML problem, > can we move -Wmissing-include-dirs to the top Makefile? I don't see why not. And eventually remove this one: fs/btrfs/Makefile:subdir-ccflags-y += -Wmissing-include-dirs > Is there any other source of -Wmissing-include-dirs > warnings? I can't give a full answer on that; only that I haven't seen any others and also that all other arch/*/include/ do have a uapi/ subdir. -- ~Randy _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2021-04-15 16:04 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-14 19:26 [PATCH] uml: fix W=1 missing-include-dirs warnings Randy Dunlap 2021-04-14 19:26 ` Randy Dunlap 2021-04-15 6:52 ` Masahiro Yamada 2021-04-15 6:52 ` Masahiro Yamada 2021-04-15 7:01 ` Randy Dunlap 2021-04-15 7:01 ` Randy Dunlap 2021-04-15 7:04 ` Masahiro Yamada 2021-04-15 7:04 ` Masahiro Yamada 2021-04-15 16:03 ` Randy Dunlap [this message] 2021-04-15 16:03 ` Randy Dunlap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dd054f33-beb8-317c-87f0-81badf087aa2@infradead.org \ --to=rdunlap@infradead.org \ --cc=anton.ivanov@cambridgegreys.com \ --cc=jdike@addtoit.com \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-um@lists.infradead.org \ --cc=masahiroy@kernel.org \ --cc=michal.lkml@markovi.net \ --cc=richard@nod.at \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.