All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH 3/3] memory: restrict XENMEM_remove_from_physmap to translated guests
Date: Mon, 8 Apr 2019 12:58:56 +0100	[thread overview]
Message-ID: <dd1d63dd-0eda-b66a-fa89-160220e65912@arm.com> (raw)
In-Reply-To: <5C7E798E020000780021BB43@prv1-mh.provo.novell.com>

Hi Jan,

On 3/5/19 1:28 PM, Jan Beulich wrote:
> @@ -298,7 +298,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_add_to_physm
>   
>   /*
>    * Unmaps the page appearing at a particular GPFN from the specified guest's
> - * pseudophysical address space.
> + * physical address space (translated guests only).

While you modify the comment, can you replace GPFN with GFN?

Other than that:

Reviewed-by: Julien Grall <julien.grall@arm.com>

Cheer,s

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
Subject: Re: [Xen-devel] [PATCH 3/3] memory: restrict XENMEM_remove_from_physmap to translated guests
Date: Mon, 8 Apr 2019 12:58:56 +0100	[thread overview]
Message-ID: <dd1d63dd-0eda-b66a-fa89-160220e65912@arm.com> (raw)
Message-ID: <20190408115856.szWE13h-7yPaui-pN1x4sxSsvCY3C6EAMtYRiMtdfts@z> (raw)
In-Reply-To: <5C7E798E020000780021BB43@prv1-mh.provo.novell.com>

Hi Jan,

On 3/5/19 1:28 PM, Jan Beulich wrote:
> @@ -298,7 +298,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_add_to_physm
>   
>   /*
>    * Unmaps the page appearing at a particular GPFN from the specified guest's
> - * pseudophysical address space.
> + * physical address space (translated guests only).

While you modify the comment, can you replace GPFN with GFN?

Other than that:

Reviewed-by: Julien Grall <julien.grall@arm.com>

Cheer,s

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-04-08 11:59 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 13:21 [PATCH 0/3] today's XSAs assorted 4.12 candidate follow-up Jan Beulich
2019-03-05 13:25 ` [PATCH 1/3] x86/mm: fix #GP(0) in switch_cr3_cr4() Jan Beulich
2019-03-05 13:58   ` Andrew Cooper
2019-03-05 13:26 ` [PATCH 2/3] IOMMU/x86: make page type checks consistent when mapping pages Jan Beulich
2019-05-13 13:44   ` George Dunlap
2019-05-13 13:44     ` [Xen-devel] " George Dunlap
2019-05-13 13:59     ` Jan Beulich
2019-05-13 13:59       ` [Xen-devel] " Jan Beulich
2019-05-14 11:17     ` Jan Beulich
2019-05-14 11:17       ` [Xen-devel] " Jan Beulich
     [not found] ` <5C7E78B0020000780021BB1E@suse.com>
2019-03-05 13:28   ` [PATCH 1/3] x86/mm: fix #GP(0) in switch_cr3_cr4() Juergen Gross
2019-03-05 13:28 ` [PATCH 3/3] memory: restrict XENMEM_remove_from_physmap to translated guests Jan Beulich
2019-04-02 10:26   ` Julien Grall
2019-04-02 16:10     ` Jan Beulich
2019-04-08 11:47       ` Julien Grall
2019-04-08 11:47         ` [Xen-devel] " Julien Grall
2019-04-08 14:29         ` Jan Beulich
2019-04-08 14:29           ` [Xen-devel] " Jan Beulich
2019-04-09  9:50           ` Julien Grall
2019-04-09  9:50             ` [Xen-devel] " Julien Grall
2019-04-09 12:21             ` Jan Beulich
2019-04-09 12:21               ` [Xen-devel] " Jan Beulich
2019-04-14 16:33               ` Julien Grall
2019-04-14 16:33                 ` [Xen-devel] " Julien Grall
2019-04-25 10:36                 ` Jan Beulich
2019-04-25 10:36                   ` [Xen-devel] " Jan Beulich
2019-04-08 11:58   ` Julien Grall [this message]
2019-04-08 11:58     ` Julien Grall
2019-04-08 14:02     ` Jan Beulich
2019-04-08 14:02       ` [Xen-devel] " Jan Beulich
2019-04-08 16:10       ` Julien Grall
2019-04-08 16:10         ` [Xen-devel] " Julien Grall
2019-05-13  8:06   ` Ping: " Jan Beulich
2019-05-13  8:06     ` [Xen-devel] " Jan Beulich
2019-05-13 14:35   ` George Dunlap
2019-05-13 14:35     ` [Xen-devel] " George Dunlap
2019-05-13 15:13     ` Jan Beulich
2019-05-13 15:13       ` [Xen-devel] " Jan Beulich
     [not found] ` <5C7E78F6020000780021BB21@suse.com>
2019-03-05 13:50   ` [PATCH 2/3] IOMMU/x86: make page type checks consistent when mapping pages Juergen Gross
2019-03-05 15:21     ` Jan Beulich
     [not found] ` <5C7E798E020000780021BB43@suse.com>
2019-03-05 13:53   ` [PATCH 3/3] memory: restrict XENMEM_remove_from_physmap to translated guests Juergen Gross
2019-03-05 15:22     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd1d63dd-0eda-b66a-fa89-160220e65912@arm.com \
    --to=julien.grall@arm.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.