* [PATCH] sandbox: Use dbus-launch instead of dbus-run-session
@ 2016-09-18 22:32 Laurent Bigonville
2016-09-19 12:31 ` Petr Lautrbach
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Bigonville @ 2016-09-18 22:32 UTC (permalink / raw)
To: selinux
From: Laurent Bigonville <bigon@bigon.be>
According to dbus upstream: "dbus-launch is fairly horrible code,
complicated by the historical need for it to support X11 autolaunching,
so the D-Bus maintainers would like to move it out of the critical path
and minimize its use."
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836289
---
policycoreutils/sandbox/sandbox | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/policycoreutils/sandbox/sandbox b/policycoreutils/sandbox/sandbox
index 726ba9b..f537dc6 100644
--- a/policycoreutils/sandbox/sandbox
+++ b/policycoreutils/sandbox/sandbox
@@ -285,7 +285,7 @@ class Sandbox:
/usr/bin/test -r ~/.xmodmap && /usr/bin/xmodmap ~/.xmodmap
%s &
WM_PID=$!
-dbus-launch --exit-with-session %s
+dbus-run-session -- %s
kill -TERM $WM_PID 2> /dev/null
""" % (command, wm, command))
fd.close()
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sandbox: Use dbus-launch instead of dbus-run-session
2016-09-18 22:32 [PATCH] sandbox: Use dbus-launch instead of dbus-run-session Laurent Bigonville
@ 2016-09-19 12:31 ` Petr Lautrbach
0 siblings, 0 replies; 2+ messages in thread
From: Petr Lautrbach @ 2016-09-19 12:31 UTC (permalink / raw)
To: Laurent Bigonville, selinux
On 09/19/2016 12:32 AM, Laurent Bigonville wrote:
> From: Laurent Bigonville <bigon@bigon.be>
>
> According to dbus upstream: "dbus-launch is fairly horrible code,
> complicated by the historical need for it to support X11 autolaunching,
> so the D-Bus maintainers would like to move it out of the critical path
> and minimize its use."
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836289
dbus-run-session was introduced in dbus-1.8.0. This change would break
systems with older dbus, e.g., rhel-7 ships dbus-1.6.12.
Would it make sense to do a test whether dbus-run-session is available
or not?
Petr
> ---
> policycoreutils/sandbox/sandbox | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/policycoreutils/sandbox/sandbox b/policycoreutils/sandbox/sandbox
> index 726ba9b..f537dc6 100644
> --- a/policycoreutils/sandbox/sandbox
> +++ b/policycoreutils/sandbox/sandbox
> @@ -285,7 +285,7 @@ class Sandbox:
> /usr/bin/test -r ~/.xmodmap && /usr/bin/xmodmap ~/.xmodmap
> %s &
> WM_PID=$!
> -dbus-launch --exit-with-session %s
> +dbus-run-session -- %s
> kill -TERM $WM_PID 2> /dev/null
> """ % (command, wm, command))
> fd.close()
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-19 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18 22:32 [PATCH] sandbox: Use dbus-launch instead of dbus-run-session Laurent Bigonville
2016-09-19 12:31 ` Petr Lautrbach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.