* [PATCH] mt76: use skb_pad() instead of __skb_pad()
@ 2018-09-25 19:52 ` Hauke Mehrtens
0 siblings, 0 replies; 4+ messages in thread
From: Hauke Mehrtens @ 2018-09-25 19:52 UTC (permalink / raw)
To: kvalo, lorenzo.bianconi
Cc: linux-mediatek, linux-wireless, matthias.bgg, Hauke Mehrtens
mt76 uses __skb_pad() with free_on_error set to true, this is the same
as calling skb_pad().
This patch does not change any functionality, but it makes it easier to
backport this driver in backports, because skb_pad() is also available
in older kernel versions.
Fixes: b40b15e1521f ("mt76: add usb support to mt76 layer")
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/net/wireless/mediatek/mt76/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c
index 7780b07543bb..e03de13f5afe 100644
--- a/drivers/net/wireless/mediatek/mt76/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/usb.c
@@ -535,7 +535,7 @@ int mt76u_skb_dma_info(struct sk_buff *skb, int port, u32 flags)
}
if (unlikely(pad)) {
- if (__skb_pad(last, pad, true))
+ if (skb_pad(last, pad))
return -ENOMEM;
__skb_put(last, pad);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mt76: use skb_pad() instead of __skb_pad()
@ 2018-09-25 19:52 ` Hauke Mehrtens
0 siblings, 0 replies; 4+ messages in thread
From: Hauke Mehrtens @ 2018-09-25 19:52 UTC (permalink / raw)
To: kvalo-sgV2jX0FEOL9JmXXK+q4OQ, lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w, Hauke Mehrtens
mt76 uses __skb_pad() with free_on_error set to true, this is the same
as calling skb_pad().
This patch does not change any functionality, but it makes it easier to
backport this driver in backports, because skb_pad() is also available
in older kernel versions.
Fixes: b40b15e1521f ("mt76: add usb support to mt76 layer")
Signed-off-by: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
---
drivers/net/wireless/mediatek/mt76/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c
index 7780b07543bb..e03de13f5afe 100644
--- a/drivers/net/wireless/mediatek/mt76/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/usb.c
@@ -535,7 +535,7 @@ int mt76u_skb_dma_info(struct sk_buff *skb, int port, u32 flags)
}
if (unlikely(pad)) {
- if (__skb_pad(last, pad, true))
+ if (skb_pad(last, pad))
return -ENOMEM;
__skb_put(last, pad);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mt76: use skb_pad() instead of __skb_pad()
@ 2018-09-26 15:35 ` Felix Fietkau
0 siblings, 0 replies; 4+ messages in thread
From: Felix Fietkau @ 2018-09-26 15:35 UTC (permalink / raw)
To: Hauke Mehrtens, kvalo, lorenzo.bianconi
Cc: linux-mediatek, linux-wireless, matthias.bgg
On 2018-09-25 21:52, Hauke Mehrtens wrote:
> mt76 uses __skb_pad() with free_on_error set to true, this is the same
> as calling skb_pad().
> This patch does not change any functionality, but it makes it easier to
> backport this driver in backports, because skb_pad() is also available
> in older kernel versions.
>
> Fixes: b40b15e1521f ("mt76: add usb support to mt76 layer")
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Merged, thanks.
- Felix
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mt76: use skb_pad() instead of __skb_pad()
@ 2018-09-26 15:35 ` Felix Fietkau
0 siblings, 0 replies; 4+ messages in thread
From: Felix Fietkau @ 2018-09-26 15:35 UTC (permalink / raw)
To: Hauke Mehrtens, kvalo-sgV2jX0FEOL9JmXXK+q4OQ,
lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w
On 2018-09-25 21:52, Hauke Mehrtens wrote:
> mt76 uses __skb_pad() with free_on_error set to true, this is the same
> as calling skb_pad().
> This patch does not change any functionality, but it makes it easier to
> backport this driver in backports, because skb_pad() is also available
> in older kernel versions.
>
> Fixes: b40b15e1521f ("mt76: add usb support to mt76 layer")
> Signed-off-by: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
Merged, thanks.
- Felix
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-26 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-25 19:52 [PATCH] mt76: use skb_pad() instead of __skb_pad() Hauke Mehrtens
2018-09-25 19:52 ` Hauke Mehrtens
2018-09-26 15:35 ` Felix Fietkau
2018-09-26 15:35 ` Felix Fietkau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.