* [Intel-wired-lan] [PATCH net v3 0/3] iavf: Fix init and watchdog state machines
@ 2021-06-18 9:03 Mateusz Palczewski
2021-06-18 9:27 ` Stefan Assmann
0 siblings, 1 reply; 3+ messages in thread
From: Mateusz Palczewski @ 2021-06-18 9:03 UTC (permalink / raw)
To: intel-wired-lan
Use single state machine for driver initialization
and for service initialized driver. The init state
machine implemented in init_task() is merged
into the watchdog_task(). The init_task() function
is removed.
---
v3: Added new file to patch series
v2: Splitted the patch into 2 to make them smaller
---
Jan Sokolowski (3):
iavf: Refactor iavf state machine tracking
iavf: Add __IAVF_INIT_FAILED state
iavf: Fix init and watchdog state machines
drivers/net/ethernet/intel/iavf/iavf.h | 12 +-
drivers/net/ethernet/intel/iavf/iavf_main.c | 188 +++++++++---------
.../net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +-
3 files changed, 103 insertions(+), 99 deletions(-)
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH net v3 0/3] iavf: Fix init and watchdog state machines
2021-06-18 9:03 [Intel-wired-lan] [PATCH net v3 0/3] iavf: Fix init and watchdog state machines Mateusz Palczewski
@ 2021-06-18 9:27 ` Stefan Assmann
2021-06-18 21:51 ` Nguyen, Anthony L
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Assmann @ 2021-06-18 9:27 UTC (permalink / raw)
To: intel-wired-lan
On 2021-06-18 11:03, Mateusz Palczewski wrote:
> Use single state machine for driver initialization
> and for service initialized driver. The init state
> machine implemented in init_task() is merged
> into the watchdog_task(). The init_task() function
> is removed.
Since this is code refactoring I think this should be applied via
net-next.
> ---
> v3: Added new file to patch series
Thanks for splitting the patches up!
Stefan
> v2: Splitted the patch into 2 to make them smaller
> ---
>
> Jan Sokolowski (3):
> iavf: Refactor iavf state machine tracking
> iavf: Add __IAVF_INIT_FAILED state
> iavf: Fix init and watchdog state machines
>
> drivers/net/ethernet/intel/iavf/iavf.h | 12 +-
> drivers/net/ethernet/intel/iavf/iavf_main.c | 188 +++++++++---------
> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +-
> 3 files changed, 103 insertions(+), 99 deletions(-)
>
> --
> 2.27.0
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH net v3 0/3] iavf: Fix init and watchdog state machines
2021-06-18 9:27 ` Stefan Assmann
@ 2021-06-18 21:51 ` Nguyen, Anthony L
0 siblings, 0 replies; 3+ messages in thread
From: Nguyen, Anthony L @ 2021-06-18 21:51 UTC (permalink / raw)
To: intel-wired-lan
On Fri, 2021-06-18 at 11:27 +0200, Stefan Assmann wrote:
> On 2021-06-18 11:03, Mateusz Palczewski wrote:
> > Use single state machine for driver initialization
> > and for service initialized driver. The init state
> > machine implemented in init_task() is merged
> > into the watchdog_task(). The init_task() function
> > is removed.
>
> Since this is code refactoring I think this should be applied via
> net-next.
I agree with Stefan. This seems like a better fit for net-next unless
you have a specific bug/issue you are resolving. If so, please include
that in the descriptions and put the fix in net patches with refactors
in net-next patches.
Also, are you using the correct tree and branch? Rebasing before you
send these? This does not apply to either tree (net-queue or next-
queue).
> > ---
> > v3: Added new file to patch series
>
> Thanks for splitting the patches up!
>
> Stefan
>
> > v2: Splitted the patch into 2 to make them smaller
> > ---
> >
> > Jan Sokolowski (3):
> > iavf: Refactor iavf state machine tracking
> > iavf: Add __IAVF_INIT_FAILED state
> > iavf: Fix init and watchdog state machines
> >
> > drivers/net/ethernet/intel/iavf/iavf.h | 12 +-
> > drivers/net/ethernet/intel/iavf/iavf_main.c | 188 +++++++++-----
> > ----
> > .../net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +-
> > 3 files changed, 103 insertions(+), 99 deletions(-)
> >
> > --
> > 2.27.0
> >
> > _______________________________________________
> > Intel-wired-lan mailing list
> > Intel-wired-lan at osuosl.org
> > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
> >
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-18 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 9:03 [Intel-wired-lan] [PATCH net v3 0/3] iavf: Fix init and watchdog state machines Mateusz Palczewski
2021-06-18 9:27 ` Stefan Assmann
2021-06-18 21:51 ` Nguyen, Anthony L
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.