All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Kalle Valo <kvalo@kernel.org>,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	ath10k <ath10k@lists.infradead.org>
Cc: wireless <linux-wireless@vger.kernel.org>,
	DT <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Pierre-Hugues Husson <phhusson@freebox.fr>
Subject: [PATCH 2/2] wifi: ath10k: work around missing MSA_READY indicator
Date: Wed, 28 Feb 2024 14:25:45 +0100	[thread overview]
Message-ID: <dd4b3fa0-b7f6-4115-ba12-5e5154ae9a79@freebox.fr> (raw)
In-Reply-To: <14daa98e-7fd3-4ebb-87bb-5d2c1fba679f@freebox.fr>

From: Pierre-Hugues Husson <phhusson@freebox.fr>

On our APQ8998 device, driver never receives MSA_READY indicator.
We only seem to receive FW_READY and PIN_CONNECT indicators.
Not waiting for the MSA_READY indicator seems to fix the WiFi.

Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
---
 drivers/net/wireless/ath/ath10k/qmi.c | 5 +++++
 drivers/net/wireless/ath/ath10k/qmi.h | 1 +
 2 files changed, 6 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 38e939f572a9e..c7724a3588549 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -1040,6 +1040,8 @@ static void ath10k_qmi_driver_event_work(struct work_struct *work)
 		switch (event->type) {
 		case ATH10K_QMI_EVENT_SERVER_ARRIVE:
 			ath10k_qmi_event_server_arrive(qmi);
+			if (qmi->skip_msa_ready)
+				ath10k_qmi_event_msa_ready(qmi);
 			break;
 		case ATH10K_QMI_EVENT_SERVER_EXIT:
 			ath10k_qmi_event_server_exit(qmi);
@@ -1077,6 +1079,9 @@ int ath10k_qmi_init(struct ath10k *ar, u32 msa_size)
 	if (of_property_read_bool(dev->of_node, "qcom,msa-fixed-perm"))
 		qmi->msa_fixed_perm = true;
 
+	if (of_property_read_bool(dev->of_node, "qcom,no-msa-ready-indicator"))
+		qmi->skip_msa_ready = true;
+
 	ret = qmi_handle_init(&qmi->qmi_hdl,
 			      WLFW_BDF_DOWNLOAD_REQ_MSG_V01_MAX_MSG_LEN,
 			      &ath10k_qmi_ops, qmi_msg_handler);
diff --git a/drivers/net/wireless/ath/ath10k/qmi.h b/drivers/net/wireless/ath/ath10k/qmi.h
index 89464239fe96a..3622714a405bb 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.h
+++ b/drivers/net/wireless/ath/ath10k/qmi.h
@@ -107,6 +107,7 @@ struct ath10k_qmi {
 	char fw_build_timestamp[MAX_TIMESTAMP_LEN + 1];
 	struct ath10k_qmi_cal_data cal_data[MAX_NUM_CAL_V01];
 	bool msa_fixed_perm;
+	bool skip_msa_ready;
 	enum ath10k_qmi_state state;
 };
 
-- 
2.34.1


      parent reply	other threads:[~2024-02-28 13:27 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 13:22 [PATCH 0/2] Work around missing MSA_READY indicator from ath10k FW Marc Gonzalez
2024-02-28 13:24 ` [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop Marc Gonzalez
2024-02-28 14:03   ` Kalle Valo
2024-02-28 16:12     ` Marc Gonzalez
2024-02-28 16:37       ` Kalle Valo
2024-02-28 17:19         ` Marc Gonzalez
2024-03-01  8:10           ` Kalle Valo
2024-03-04 15:51             ` Marc Gonzalez
2024-03-05 14:31               ` Kalle Valo
2024-03-05 17:32                 ` Marc Gonzalez
2024-03-05 19:20                   ` Kalle Valo
2024-03-13 15:09                     ` Marc Gonzalez
2024-03-13 15:48                       ` Konrad Dybcio
2024-03-13 15:53                       ` Dmitry Baryshkov
2024-03-14 12:31                         ` Marc Gonzalez
2024-03-14 12:52                           ` Dmitry Baryshkov
2024-03-18 16:56                         ` Marc Gonzalez
2024-03-19 13:47                           ` Marc Gonzalez
2024-03-19 14:39                             ` Marc Gonzalez
2024-03-19 17:05                               ` Marc Gonzalez
2024-03-26 15:04                       ` Marc Gonzalez
2024-03-26 17:45                         ` Marc Gonzalez
2024-03-26 17:51                           ` Dmitry Baryshkov
2024-03-26 20:21                             ` Jeff Johnson
2024-03-28 17:09                               ` Marc Gonzalez
2024-02-29 18:40         ` Conor Dooley
2024-02-29 19:46           ` Jeff Johnson
2024-03-07 15:29             ` Marc Gonzalez
2024-03-07 16:46               ` Jeff Johnson
2024-03-14 14:33                 ` Jeff Johnson
2024-03-14 17:52                   ` Marc Gonzalez
2024-03-14 19:28                     ` Jeff Johnson
2024-03-04 16:21           ` Marc Gonzalez
2024-03-04 19:34             ` Conor Dooley
2024-03-04 19:37               ` Dmitry Baryshkov
2024-03-04 19:45                 ` Conor Dooley
2024-03-04 19:59                   ` Dmitry Baryshkov
2024-03-04 20:17                     ` Conor Dooley
2024-03-04 20:21                       ` Dmitry Baryshkov
2024-03-05  8:04                         ` Krzysztof Kozlowski
2024-03-05 13:41               ` Marc Gonzalez
2024-03-05 15:02             ` Kalle Valo
2024-03-05 14:45           ` Kalle Valo
2024-02-28 14:59   ` Jeff Johnson
2024-02-28 16:00     ` Marc Gonzalez
2024-02-29 15:49     ` Marc Gonzalez
2024-02-28 13:25 ` Marc Gonzalez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd4b3fa0-b7f6-4115-ba12-5e5154ae9a79@freebox.fr \
    --to=mgonzalez@freebox.fr \
    --cc=ath10k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=phhusson@freebox.fr \
    --cc=quic_jjohnson@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.