Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Kalle Valo <kvalo@kernel.org>,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	ath10k <ath10k@lists.infradead.org>,
	wireless <linux-wireless@vger.kernel.org>,
	DT <devicetree@vger.kernel.org>,
	Pierre-Hugues Husson <phhusson@freebox.fr>,
	Jami Kettunen <jamipkettunen@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop
Date: Wed, 13 Mar 2024 16:09:07 +0100	[thread overview]
Message-ID: <fb0ffdd9-923a-4191-8304-583243ad528b@freebox.fr> (raw)
In-Reply-To: <87h6hk7aee.fsf@kernel.org>

[ Dropping the DT fellows ]

On 05/03/2024 20:20, Kalle Valo wrote:

> Marc Gonzalez wrote:
> 
>> I need to build a kernel + rootfs + FW to test the proposed solution,
>> then I can spin a formal submission.
> 
> Yeah, please do test this to make sure we are not missing anything :)

I used buildroot ( https://buildroot.org ) to generate a kernel + rootfs
for my board (a variation of qcom/msm8998-mtp.dts)

Not sure if I must use the vendor FW blobs? Or if I can use the blobs
from linux-firmware-20240115.tar.xz (as supported by BR2).

All I see from the ath10k driver (with debugging cranked to the max) is:

[    0.539801] ath10k_snoc 18800000.wifi: Adding to iommu group 0
[    0.541941] ath10k_snoc 18800000.wifi: snoc xo-cal-data return -22
[    0.543633] ath10k_snoc 18800000.wifi: supply vdd-3.3-ch1 not found, using dummy regulator
[    0.544002] ath10k_snoc 18800000.wifi: qmi msa.paddr: 0x0000000094400000 , msa.vaddr: 0x(____ptrval____)
[    0.544271] ath10k_snoc 18800000.wifi: snoc probe

# ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: enp1s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
    link/ether 34:27:92:82:48:ec brd ff:ff:ff:ff:ff:ff

No wlan device at this point.

I got shell-shock from reading these setup steps:

https://wiki.postmarketos.org/wiki/Qualcomm_Snapdragon_835_(MSM8998)#WLAN
https://github.com/jhugo/linux/blob/5.5rc2_wifi/README

Jeffrey, Bjorn, Konrad,
Has someone written idiot-proof (such as myself) steps to enable
the ath10k core on a msm8998 board?

I'm still not quite sure where linux-firmware.git fits into all this.

Regards