From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org Cc: plai@codeaurora.org, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, lgirdwood@gmail.com, bgoswami@codeaurora.org Subject: Re: [PATCH v6 00/22] ASoC: qcom: Add AudioReach support Date: Wed, 15 Sep 2021 11:32:29 -0500 [thread overview] Message-ID: <dd55eeae-0fd9-1faf-12b5-deaaf1a035b4@linux.intel.com> (raw) In-Reply-To: <20210915131333.19047-1-srinivas.kandagatla@linaro.org> On 9/15/21 8:13 AM, Srinivas Kandagatla wrote: > Many thanks for reviewing v5. This version addresses all the comments > raised as part of v5 review. Much improved indeed, but still a couple of issues and nit-picks. The one thing I didn't see before is the use of an 'audioreach.bin' topology file, retrieved with request_firmware(). That hard-coded name seems problematic for a signal processing framework precisely geared to topology changes (I kept the description below for context), and will prevent the use of a common setup on different platforms, even when they only differ by the form-factor and processing graph. That doesn't seem to scale, does it? Or did I miss something? In the SOF example, we have an initial set of tables based on which codec/amps are used and DMI identifiers; the topology name is overridden at boot time to account for hardware variability and changes in processing. > This patchset adds ASoC driver support to configure signal processing > framework ("AudioReach") which is integral part of Qualcomm next > generation audio SDK and will be deployed on upcoming Qualcomm chipsets. > It makes use of ASoC Topology to load graphs on to the DSP which is then > managed by APM (Audio Processing Manager) service to prepare/start/stop. > > Here is simplified high-level block diagram of AudioReach: > > ___________________________________________________________ > | CPU (Application Processor) | > | +---------+ +---------+ +----------+ | > | | q6apm | | q6apm | | q6apm | | > | | dais | <------> | | <-----> |lpass-dais| | > | +---------+ +---------+ +----------+ | > | ^ ^ | > | | | +---------+ | > | +---------+ v +---------->|topology | | > | | q6prm | +---------+ | | | > | | |<-------->| GPR | +---------+ | > | +---------+ +---------+ | > | ^ ^ | > | | | | > | +----------+ | | > | | q6prm | | | > | |lpass-clks| | | > | +----------+ | | > |____________________________|______________________________| > | > | RPMSG (IPC over GLINK) > ____________________________|______________________________ > | | | > | +-----------------------+ | > | | | | > | v v q6 (Audio DSP) | > |+-----+ +----------------------------------+ | > || PRM | | APM (Audio Processing Manager) | | > |+-----+ | . Graph Management | | > | | . Command Handing | | > | | . Event Management | | > | | ... | | > | +----------------------------------+ | > | ^ | > |____________________________|______________________________| > | > | LPASS AIF > ____________________________|______________________________ > | | Audio I/O | > | v | > | +--------------------------------------------------+ | > | | Audio devices | | > | | CODEC | HDMI-TX | PCM | SLIMBUS | I2S |MI2S |...| | > | | | | > | +--------------------------------------------------+ | > |___________________________________________________________| > > AudioReach has constructs of sub-graph, container and modules. > Each sub-graph can have N containers and each Container can have N Modules > and connections between them can be linear or non-linear. > An audio function can be realized with one or many connected > sub-graphs. There are also control/event paths between modules that can > be wired up while building graph to achieve various control mechanism > between modules. These concepts of Sub-Graph, Containers and Modules > are represented in ASoC topology. > > Here is simple I2S graph with a Write Shared Memory and a > Volume control module within a single Subgraph (1) with one Container (1) > and 5 modules. > > ____________________________________________________________ > | Sub-Graph [1] | > | _______________________________________________________ | > | | Container [1] | | > | | [WR_SH] -> [PCM DEC] -> [PCM CONV] -> [VOL]-> [I2S-EP]| | > | |_______________________________________________________| | > |____________________________________________________________| > > For now this graph is split into two subgraphs to achieve dpcm like below: > ________________________________________________ _________________ > | Sub-Graph [1] | | Sub-Graph [2] | > | ____________________________________________ | | _____________ | > | | Container [1] | | | |Container [2]| | > | | [WR_SH] -> [PCM DEC] -> [PCM CONV] -> [VOL]| | | | [I2S-EP] | | > | |____________________________________________| | | |_____________| | > |________________________________________________| |_________________| > > _________________ > | Sub-Graph [3] | > | _____________ | > | |Container [3]| | > | | [DMA-EP] | | > | |_____________| | > |_________________| > > > This patchset adds very minimal support for AudioReach which includes > supporting sub-graphs containing CODEC DMA ports and simple PCM > Decoder/Encoder and Logger Modules. Additional capabilities will > be built over time to expose features offered by AudioReach. > > This patchset is Tested on SM8250 SoC based Qualcomm Robotics Platform RB5 > and SM9250 MTP with WSA881X Smart Speaker Amplifiers, DMICs connected via > VA Macro and WCD938x Codec connected via TX and RX Macro and HDMI audio > via I2S.
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, tiwai@suse.de, plai@codeaurora.org, lgirdwood@gmail.com Subject: Re: [PATCH v6 00/22] ASoC: qcom: Add AudioReach support Date: Wed, 15 Sep 2021 11:32:29 -0500 [thread overview] Message-ID: <dd55eeae-0fd9-1faf-12b5-deaaf1a035b4@linux.intel.com> (raw) In-Reply-To: <20210915131333.19047-1-srinivas.kandagatla@linaro.org> On 9/15/21 8:13 AM, Srinivas Kandagatla wrote: > Many thanks for reviewing v5. This version addresses all the comments > raised as part of v5 review. Much improved indeed, but still a couple of issues and nit-picks. The one thing I didn't see before is the use of an 'audioreach.bin' topology file, retrieved with request_firmware(). That hard-coded name seems problematic for a signal processing framework precisely geared to topology changes (I kept the description below for context), and will prevent the use of a common setup on different platforms, even when they only differ by the form-factor and processing graph. That doesn't seem to scale, does it? Or did I miss something? In the SOF example, we have an initial set of tables based on which codec/amps are used and DMI identifiers; the topology name is overridden at boot time to account for hardware variability and changes in processing. > This patchset adds ASoC driver support to configure signal processing > framework ("AudioReach") which is integral part of Qualcomm next > generation audio SDK and will be deployed on upcoming Qualcomm chipsets. > It makes use of ASoC Topology to load graphs on to the DSP which is then > managed by APM (Audio Processing Manager) service to prepare/start/stop. > > Here is simplified high-level block diagram of AudioReach: > > ___________________________________________________________ > | CPU (Application Processor) | > | +---------+ +---------+ +----------+ | > | | q6apm | | q6apm | | q6apm | | > | | dais | <------> | | <-----> |lpass-dais| | > | +---------+ +---------+ +----------+ | > | ^ ^ | > | | | +---------+ | > | +---------+ v +---------->|topology | | > | | q6prm | +---------+ | | | > | | |<-------->| GPR | +---------+ | > | +---------+ +---------+ | > | ^ ^ | > | | | | > | +----------+ | | > | | q6prm | | | > | |lpass-clks| | | > | +----------+ | | > |____________________________|______________________________| > | > | RPMSG (IPC over GLINK) > ____________________________|______________________________ > | | | > | +-----------------------+ | > | | | | > | v v q6 (Audio DSP) | > |+-----+ +----------------------------------+ | > || PRM | | APM (Audio Processing Manager) | | > |+-----+ | . Graph Management | | > | | . Command Handing | | > | | . Event Management | | > | | ... | | > | +----------------------------------+ | > | ^ | > |____________________________|______________________________| > | > | LPASS AIF > ____________________________|______________________________ > | | Audio I/O | > | v | > | +--------------------------------------------------+ | > | | Audio devices | | > | | CODEC | HDMI-TX | PCM | SLIMBUS | I2S |MI2S |...| | > | | | | > | +--------------------------------------------------+ | > |___________________________________________________________| > > AudioReach has constructs of sub-graph, container and modules. > Each sub-graph can have N containers and each Container can have N Modules > and connections between them can be linear or non-linear. > An audio function can be realized with one or many connected > sub-graphs. There are also control/event paths between modules that can > be wired up while building graph to achieve various control mechanism > between modules. These concepts of Sub-Graph, Containers and Modules > are represented in ASoC topology. > > Here is simple I2S graph with a Write Shared Memory and a > Volume control module within a single Subgraph (1) with one Container (1) > and 5 modules. > > ____________________________________________________________ > | Sub-Graph [1] | > | _______________________________________________________ | > | | Container [1] | | > | | [WR_SH] -> [PCM DEC] -> [PCM CONV] -> [VOL]-> [I2S-EP]| | > | |_______________________________________________________| | > |____________________________________________________________| > > For now this graph is split into two subgraphs to achieve dpcm like below: > ________________________________________________ _________________ > | Sub-Graph [1] | | Sub-Graph [2] | > | ____________________________________________ | | _____________ | > | | Container [1] | | | |Container [2]| | > | | [WR_SH] -> [PCM DEC] -> [PCM CONV] -> [VOL]| | | | [I2S-EP] | | > | |____________________________________________| | | |_____________| | > |________________________________________________| |_________________| > > _________________ > | Sub-Graph [3] | > | _____________ | > | |Container [3]| | > | | [DMA-EP] | | > | |_____________| | > |_________________| > > > This patchset adds very minimal support for AudioReach which includes > supporting sub-graphs containing CODEC DMA ports and simple PCM > Decoder/Encoder and Logger Modules. Additional capabilities will > be built over time to expose features offered by AudioReach. > > This patchset is Tested on SM8250 SoC based Qualcomm Robotics Platform RB5 > and SM9250 MTP with WSA881X Smart Speaker Amplifiers, DMICs connected via > VA Macro and WCD938x Codec connected via TX and RX Macro and HDMI audio > via I2S.
next prev parent reply other threads:[~2021-09-15 16:34 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-15 13:13 [PATCH v6 00/22] ASoC: qcom: Add AudioReach support Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 01/22] soc: dt-bindings: qcom: apr: convert to yaml Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 02/22] soc: dt-bindings: qcom: apr: deprecate qcom,apr-domain property Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 02/22] soc: dt-bindings: qcom: apr: deprecate qcom, apr-domain property Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 03/22] soc: qcom: apr: make code more reuseable Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 04/22] soc: dt-bindings: qcom: add gpr bindings Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-16 20:03 ` Rob Herring 2021-09-16 20:03 ` Rob Herring 2021-09-15 13:13 ` [PATCH v6 05/22] soc: qcom: apr: Add GPR support Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 15:47 ` Pierre-Louis Bossart 2021-09-15 15:47 ` Pierre-Louis Bossart 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 06/22] ASoC: dt-bindings: move LPASS dai related bindings out of q6afe Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 07/22] ASoC: dt-bindings: move LPASS clocks " Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 08/22] ASoC: dt-bindings: rename q6afe.h to q6dsp-lpass-ports.h Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 09/22] ASoC: qdsp6: q6afe-dai: move lpass audio ports to common file Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 10/22] ASoC: qdsp6: q6afe-clocks: move audio-clocks " Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 11/22] ASoC: dt-bindings: q6dsp: add q6apm-lpass-dai compatible Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 12/22] ASoC: dt-bindings: lpass-clocks: add q6prm clocks compatible Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 13/22] ASoC: dt-bindings: add q6apm digital audio stream bindings Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-16 20:05 ` Rob Herring 2021-09-16 20:05 ` Rob Herring 2021-09-15 13:13 ` [PATCH v6 14/22] ASoC: qdsp6: audioreach: add basic pkt alloc support Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 15:54 ` Pierre-Louis Bossart 2021-09-15 15:54 ` Pierre-Louis Bossart 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 15/22] ASoC: qdsp6: audioreach: add q6apm support Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 16:02 ` Pierre-Louis Bossart 2021-09-15 16:02 ` Pierre-Louis Bossart 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 16/22] ASoC: qdsp6: audioreach: add module configuration command helpers Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 16:11 ` Pierre-Louis Bossart 2021-09-15 16:11 ` Pierre-Louis Bossart 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-16 15:40 ` Pierre-Louis Bossart 2021-09-16 15:40 ` Pierre-Louis Bossart 2021-09-15 13:13 ` [PATCH v6 17/22] ASoC: qdsp6: audioreach: add Kconfig and Makefile Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 18/22] ASoC: qdsp6: audioreach: add topology support Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 16:22 ` Pierre-Louis Bossart 2021-09-15 16:22 ` Pierre-Louis Bossart 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-16 15:02 ` Srinivas Kandagatla 2021-09-16 16:28 ` Pierre-Louis Bossart 2021-09-16 16:28 ` Pierre-Louis Bossart 2021-09-15 13:13 ` [PATCH v6 19/22] ASoC: qdsp6: audioreach: add q6apm-dai support Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 20/22] ASoC: qdsp6: audioreach: add q6apm lpass dai support Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 21/22] ASoC: qdsp6: audioreach: add q6prm support Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 13:13 ` [PATCH v6 22/22] ASoC: qdsp6: audioreach: add support for q6prm-clocks Srinivas Kandagatla 2021-09-15 13:13 ` Srinivas Kandagatla 2021-09-15 16:32 ` Pierre-Louis Bossart [this message] 2021-09-15 16:32 ` [PATCH v6 00/22] ASoC: qcom: Add AudioReach support Pierre-Louis Bossart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dd55eeae-0fd9-1faf-12b5-deaaf1a035b4@linux.intel.com \ --to=pierre-louis.bossart@linux.intel.com \ --cc=alsa-devel@alsa-project.org \ --cc=bgoswami@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=perex@perex.cz \ --cc=plai@codeaurora.org \ --cc=robh@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.