From: Markus Elfring <Markus.Elfring@web.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
Kangjie Lu <kjlu@umn.edu>
Subject: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
Date: Sun, 31 May 2020 10:03:19 +0200 [thread overview]
Message-ID: <dd729c13-fbc8-22e7-7d8e-e3e126f66943@web.de> (raw)
> When gk20a_clk_ctor() returns an error code, pointer "clk"
> should be released.
Such an information is reasonable.
> It's the same when gm20b_clk_new() returns from elsewhere following this call.
I suggest to reconsider the interpretation of the software situation once more.
Can it be that the allocated clock object should be kept usable even after
a successful return from this function?
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>, Kangjie Lu <kjlu@umn.edu>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
Date: Sun, 31 May 2020 08:03:19 +0000 [thread overview]
Message-ID: <dd729c13-fbc8-22e7-7d8e-e3e126f66943@web.de> (raw)
> When gk20a_clk_ctor() returns an error code, pointer "clk"
> should be released.
Such an information is reasonable.
> It's the same when gm20b_clk_new() returns from elsewhere following this call.
I suggest to reconsider the interpretation of the software situation once more.
Can it be that the allocated clock object should be kept usable even after
a successful return from this function?
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>, Kangjie Lu <kjlu@umn.edu>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
Date: Sun, 31 May 2020 10:03:19 +0200 [thread overview]
Message-ID: <dd729c13-fbc8-22e7-7d8e-e3e126f66943@web.de> (raw)
> When gk20a_clk_ctor() returns an error code, pointer "clk"
> should be released.
Such an information is reasonable.
> It's the same when gm20b_clk_new() returns from elsewhere following this call.
I suggest to reconsider the interpretation of the software situation once more.
Can it be that the allocated clock object should be kept usable even after
a successful return from this function?
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-05-31 8:03 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 8:03 Markus Elfring [this message]
2020-05-31 8:03 ` [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new() Markus Elfring
2020-05-31 8:03 ` Markus Elfring
2020-05-31 8:23 ` dinghao.liu
2020-05-31 8:23 ` dinghao.liu
2020-05-31 8:23 ` dinghao.liu
2020-05-31 8:38 ` Markus Elfring
2020-05-31 8:38 ` Markus Elfring
2020-05-31 8:38 ` Markus Elfring
2020-05-31 8:38 ` Markus Elfring
2020-05-31 8:52 ` dinghao.liu
2020-05-31 8:52 ` dinghao.liu
2020-05-31 8:52 ` dinghao.liu
2020-05-31 9:00 ` Markus Elfring
2020-05-31 9:00 ` Markus Elfring
2020-05-31 9:00 ` Markus Elfring
2020-05-31 9:15 ` dinghao.liu
2020-05-31 9:15 ` dinghao.liu
2020-05-31 9:15 ` dinghao.liu
2020-05-31 9:51 ` Markus Elfring
2020-05-31 9:51 ` Markus Elfring
2020-05-31 9:51 ` Markus Elfring
2020-05-31 9:51 ` Markus Elfring
2020-05-31 10:42 ` dinghao.liu
2020-05-31 10:42 ` dinghao.liu
2020-05-31 10:42 ` dinghao.liu
2020-05-31 12:14 ` drm/nouveau/clk/gm20b: Fix memory leaks after failed gk20a_clk_ctor() calls Markus Elfring
2020-05-31 12:14 ` Markus Elfring
2020-05-31 12:14 ` Markus Elfring
2020-05-31 12:14 ` Markus Elfring
2020-06-02 10:29 ` Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new() Dan Carpenter
2020-06-02 10:29 ` Dan Carpenter
2020-06-02 10:29 ` Dan Carpenter
2020-06-02 10:29 ` Dan Carpenter
2020-06-02 11:10 ` Markus Elfring
2020-06-02 11:10 ` Markus Elfring
2020-06-02 11:10 ` Markus Elfring
2020-06-02 11:10 ` Markus Elfring
2020-06-02 15:39 ` Dan Carpenter
2020-06-02 15:39 ` Dan Carpenter
2020-06-02 15:39 ` Dan Carpenter
2020-06-03 2:21 ` dinghao.liu
2020-06-03 2:21 ` dinghao.liu
2020-06-03 2:21 ` dinghao.liu
2020-06-03 5:04 ` drm/nouveau/clk/gm20b: Understanding challenges around gm20b_clk_new() Markus Elfring
2020-06-03 5:04 ` Markus Elfring
2020-06-03 5:04 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd729c13-fbc8-22e7-7d8e-e3e126f66943@web.de \
--to=markus.elfring@web.de \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.