All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: "Florian Fainelli" <f.fainelli@gmail.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"John Stultz" <john.stultz@linaro.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>
Cc: devel@driverdev.osuosl.org, Jon Medhurst <tixy@linaro.org>,
	Android Kernel Team <kernel-team@android.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Will Deacon <will.deacon@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
	Rohit kumar <rohit.kr@samsung.com>,
	Bryan Huntsman <bryanh@codeaurora.org>,
	Jeremy Gebben <jgebben@codeaurora.org>,
	Eun Taik Lee <eun.taik.lee@samsung.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	Mitchel Humpherys <mitchelh@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE
Date: Tue, 9 Aug 2016 17:13:04 -0700	[thread overview]
Message-ID: <dd9519ce-cd4f-4007-a88a-f184407ca565@redhat.com> (raw)
In-Reply-To: <afd22029-c60c-1c15-3293-4011b085e07e@gmail.com>

On 08/09/2016 02:56 PM, Florian Fainelli wrote:
> On 08/08/2016 10:49 AM, Laura Abbott wrote:
>> arm may need the kernel_force_cache APIs to guarantee data consistency.
>> Implement versions of these APIs based on the DMA APIs.
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>> ---
>>  arch/arm/include/asm/cacheflush.h |   4 ++
>>  arch/arm/mm/dma-mapping.c         | 119 --------------------------------------
>>  arch/arm/mm/flush.c               | 115 ++++++++++++++++++++++++++++++++++++
>
> Why is the code moved between dma-mapping.c and flush.c? It was not
> obvious while looking at these patches why this is needed.
>

I wanted to use the cache flushing routines from dma-mapping.c and
it seemed better to pull them out vs. trying to put more generic
cache flushing code in dma-mapping.c. flush.c seemed like an
appropriate place although I forgot about the dependency on CONFIG_MMU.
It can certainly remain in dma-mapping.c if deemed appropriate.

Thanks,
Laura

WARNING: multiple messages have this Message-ID (diff)
From: labbott@redhat.com (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE
Date: Tue, 9 Aug 2016 17:13:04 -0700	[thread overview]
Message-ID: <dd9519ce-cd4f-4007-a88a-f184407ca565@redhat.com> (raw)
In-Reply-To: <afd22029-c60c-1c15-3293-4011b085e07e@gmail.com>

On 08/09/2016 02:56 PM, Florian Fainelli wrote:
> On 08/08/2016 10:49 AM, Laura Abbott wrote:
>> arm may need the kernel_force_cache APIs to guarantee data consistency.
>> Implement versions of these APIs based on the DMA APIs.
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>> ---
>>  arch/arm/include/asm/cacheflush.h |   4 ++
>>  arch/arm/mm/dma-mapping.c         | 119 --------------------------------------
>>  arch/arm/mm/flush.c               | 115 ++++++++++++++++++++++++++++++++++++
>
> Why is the code moved between dma-mapping.c and flush.c? It was not
> obvious while looking at these patches why this is needed.
>

I wanted to use the cache flushing routines from dma-mapping.c and
it seemed better to pull them out vs. trying to put more generic
cache flushing code in dma-mapping.c. flush.c seemed like an
appropriate place although I forgot about the dependency on CONFIG_MMU.
It can certainly remain in dma-mapping.c if deemed appropriate.

Thanks,
Laura

  reply	other threads:[~2016-08-10  0:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 17:49 [RFCv2][PATCH 0/5] Cleanup Ion mapping/caching Laura Abbott
2016-08-08 17:49 ` Laura Abbott
2016-08-08 17:49 ` [RFCv2][PATCH 1/5] Documentation: Introduce kernel_force_cache_* APIs Laura Abbott
2016-08-08 17:49   ` Laura Abbott
2016-08-08 17:49 ` [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE Laura Abbott
2016-08-08 17:49   ` Laura Abbott
2016-08-09 21:56   ` Florian Fainelli
2016-08-09 21:56     ` Florian Fainelli
2016-08-10  0:13     ` Laura Abbott [this message]
2016-08-10  0:13       ` Laura Abbott
2016-08-10  0:20       ` Florian Fainelli
2016-08-10  0:20         ` Florian Fainelli
2016-08-10 23:22   ` Russell King - ARM Linux
2016-08-10 23:22     ` Russell King - ARM Linux
2016-08-16 20:39     ` Laura Abbott
2016-08-16 20:39       ` Laura Abbott
2016-08-08 17:49 ` [RFCv2][PATCH 3/5] arm64: " Laura Abbott
2016-08-08 17:49   ` Laura Abbott
2016-08-08 17:49 ` [RFCv2][PATCH 4/5] staging: android: ion: Convert to the kernel_force_cache APIs Laura Abbott
2016-08-08 17:49   ` Laura Abbott
2016-08-08 17:49 ` [RFCv2][PATCH 5/5] staging: ion: Add support for syncing with DMA_BUF_IOCTL_SYNC Laura Abbott
2016-08-08 17:49   ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd9519ce-cd4f-4007-a88a-f184407ca565@redhat.com \
    --to=labbott@redhat.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=arve@android.com \
    --cc=bryanh@codeaurora.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=devel@driverdev.osuosl.org \
    --cc=eun.taik.lee@samsung.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgebben@codeaurora.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mitchelh@codeaurora.org \
    --cc=riandrews@android.com \
    --cc=rohit.kr@samsung.com \
    --cc=sumit.semwal@linaro.org \
    --cc=tixy@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.