From: Guillaume Tucker <guillaume.tucker@collabora.com> To: "Ser, Simon" <simon.ser@intel.com>, "Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>, "Latvala, Petri" <petri.latvala@intel.com> Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org> Subject: Re: [PATCH i-g-t v3 2/4] gitlab-ci: add libatomic to docker images Date: Wed, 19 Jun 2019 09:09:06 +0100 [thread overview] Message-ID: <ddd054f0-8267-0961-e74b-056323a6c00a@collabora.com> (raw) In-Reply-To: <b19353c7c4b602b58aa3a326d6ed5a09fe7dd7c9.camel@intel.com> On 19/06/2019 07:50, Ser, Simon wrote: > On Tue, 2019-06-18 at 13:27 +0100, Guillaume Tucker wrote: >> Add libatomic to the Fedora docker image so it can link binaries that >> use __atomic_* functions. Also explicitly add libatomic1 to Debian >> docker images as it is needed in particular on non-x86 architectures >> for run-time linkage. > > Per "[PATCH i-g-t v3 1/4] meson: add libatomic dependency", do we need > libatomic for all of these images? I suppose it's safer to include it, so if the linker test in meson.build does happen to add the dependency it will actually work. Also as per an earlier comment: [PATCH i-g-t 2/4] gitlab-ci: add libatomic to Fedora docker image On 06/06/2019 08:26, Ser, Simon wrote: >> I wonder how does the libatomic gets installed implicitly in Debian. > It's a dependency of GCC. Probably a good idea to add it anyway? It's true that we may optimise this a bit by checking for every arch whether the test is expected to always pass or not and drop the libatomic1 sub-arch package for those that link fine without it. I suspect only the mips version really needs it, the CI jobs can help us confirm that. Does that seem worth doing? Guillaume >> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> >> --- >> >> Notes: >> v2: add libatomic1 in Debian docker images >> v3: add libatomic1 for non-x86 arches in Debian docker images >> >> Dockerfile.debian | 1 + >> Dockerfile.debian-arm64 | 1 + >> Dockerfile.debian-armhf | 1 + >> Dockerfile.fedora | 2 +- >> 4 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Dockerfile.debian b/Dockerfile.debian >> index b9c3be3945e0..d23591850c4e 100644 >> --- a/Dockerfile.debian >> +++ b/Dockerfile.debian >> @@ -6,6 +6,7 @@ RUN apt-get install -y \ >> flex \ >> bison \ >> pkg-config \ >> + libatomic1 \ >> libpciaccess-dev \ >> libkmod-dev \ >> libprocps-dev \ >> diff --git a/Dockerfile.debian-arm64 b/Dockerfile.debian-arm64 >> index 7b3a3c7ca803..c9fb28c804b8 100644 >> --- a/Dockerfile.debian-arm64 >> +++ b/Dockerfile.debian-arm64 >> @@ -14,6 +14,7 @@ RUN dpkg --add-architecture arm64 >> RUN apt-get update >> RUN apt-get install -y \ >> gcc-aarch64-linux-gnu \ >> + libatomic1:arm64 \ >> libpciaccess-dev:arm64 \ >> libkmod-dev:arm64 \ >> libprocps-dev:arm64 \ >> diff --git a/Dockerfile.debian-armhf b/Dockerfile.debian-armhf >> index c67a1e2acf6a..3a133d849d68 100644 >> --- a/Dockerfile.debian-armhf >> +++ b/Dockerfile.debian-armhf >> @@ -14,6 +14,7 @@ RUN dpkg --add-architecture armhf >> RUN apt-get update >> RUN apt-get install -y \ >> gcc-arm-linux-gnueabihf \ >> + libatomic1:armhf \ >> libpciaccess-dev:armhf \ >> libkmod-dev:armhf \ >> libprocps-dev:armhf \ >> diff --git a/Dockerfile.fedora b/Dockerfile.fedora >> index 6686e587613d..c84b412b0723 100644 >> --- a/Dockerfile.fedora >> +++ b/Dockerfile.fedora >> @@ -1,7 +1,7 @@ >> FROM fedora:30 >> >> RUN dnf install -y \ >> - gcc flex bison meson ninja-build xdotool \ >> + gcc flex bison libatomic meson ninja-build xdotool \ >> 'pkgconfig(libdrm)' \ >> 'pkgconfig(pciaccess)' \ >> 'pkgconfig(libkmod)' \ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Guillaume Tucker <guillaume.tucker@collabora.com> To: "Ser, Simon" <simon.ser@intel.com>, "Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>, "Latvala, Petri" <petri.latvala@intel.com> Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org> Subject: Re: [igt-dev] [PATCH i-g-t v3 2/4] gitlab-ci: add libatomic to docker images Date: Wed, 19 Jun 2019 09:09:06 +0100 [thread overview] Message-ID: <ddd054f0-8267-0961-e74b-056323a6c00a@collabora.com> (raw) In-Reply-To: <b19353c7c4b602b58aa3a326d6ed5a09fe7dd7c9.camel@intel.com> On 19/06/2019 07:50, Ser, Simon wrote: > On Tue, 2019-06-18 at 13:27 +0100, Guillaume Tucker wrote: >> Add libatomic to the Fedora docker image so it can link binaries that >> use __atomic_* functions. Also explicitly add libatomic1 to Debian >> docker images as it is needed in particular on non-x86 architectures >> for run-time linkage. > > Per "[PATCH i-g-t v3 1/4] meson: add libatomic dependency", do we need > libatomic for all of these images? I suppose it's safer to include it, so if the linker test in meson.build does happen to add the dependency it will actually work. Also as per an earlier comment: [PATCH i-g-t 2/4] gitlab-ci: add libatomic to Fedora docker image On 06/06/2019 08:26, Ser, Simon wrote: >> I wonder how does the libatomic gets installed implicitly in Debian. > It's a dependency of GCC. Probably a good idea to add it anyway? It's true that we may optimise this a bit by checking for every arch whether the test is expected to always pass or not and drop the libatomic1 sub-arch package for those that link fine without it. I suspect only the mips version really needs it, the CI jobs can help us confirm that. Does that seem worth doing? Guillaume >> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> >> --- >> >> Notes: >> v2: add libatomic1 in Debian docker images >> v3: add libatomic1 for non-x86 arches in Debian docker images >> >> Dockerfile.debian | 1 + >> Dockerfile.debian-arm64 | 1 + >> Dockerfile.debian-armhf | 1 + >> Dockerfile.fedora | 2 +- >> 4 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Dockerfile.debian b/Dockerfile.debian >> index b9c3be3945e0..d23591850c4e 100644 >> --- a/Dockerfile.debian >> +++ b/Dockerfile.debian >> @@ -6,6 +6,7 @@ RUN apt-get install -y \ >> flex \ >> bison \ >> pkg-config \ >> + libatomic1 \ >> libpciaccess-dev \ >> libkmod-dev \ >> libprocps-dev \ >> diff --git a/Dockerfile.debian-arm64 b/Dockerfile.debian-arm64 >> index 7b3a3c7ca803..c9fb28c804b8 100644 >> --- a/Dockerfile.debian-arm64 >> +++ b/Dockerfile.debian-arm64 >> @@ -14,6 +14,7 @@ RUN dpkg --add-architecture arm64 >> RUN apt-get update >> RUN apt-get install -y \ >> gcc-aarch64-linux-gnu \ >> + libatomic1:arm64 \ >> libpciaccess-dev:arm64 \ >> libkmod-dev:arm64 \ >> libprocps-dev:arm64 \ >> diff --git a/Dockerfile.debian-armhf b/Dockerfile.debian-armhf >> index c67a1e2acf6a..3a133d849d68 100644 >> --- a/Dockerfile.debian-armhf >> +++ b/Dockerfile.debian-armhf >> @@ -14,6 +14,7 @@ RUN dpkg --add-architecture armhf >> RUN apt-get update >> RUN apt-get install -y \ >> gcc-arm-linux-gnueabihf \ >> + libatomic1:armhf \ >> libpciaccess-dev:armhf \ >> libkmod-dev:armhf \ >> libprocps-dev:armhf \ >> diff --git a/Dockerfile.fedora b/Dockerfile.fedora >> index 6686e587613d..c84b412b0723 100644 >> --- a/Dockerfile.fedora >> +++ b/Dockerfile.fedora >> @@ -1,7 +1,7 @@ >> FROM fedora:30 >> >> RUN dnf install -y \ >> - gcc flex bison meson ninja-build xdotool \ >> + gcc flex bison libatomic meson ninja-build xdotool \ >> 'pkgconfig(libdrm)' \ >> 'pkgconfig(pciaccess)' \ >> 'pkgconfig(libkmod)' \ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-19 8:09 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-18 12:27 [PATCH i-g-t v3 0/4] Use C11 atomics Guillaume Tucker 2019-06-18 12:27 ` [igt-dev] " Guillaume Tucker 2019-06-18 12:27 ` [PATCH i-g-t v3 1/4] meson: add libatomic dependency Guillaume Tucker 2019-06-18 12:27 ` [Intel-gfx] " Guillaume Tucker 2019-06-18 13:20 ` Ser, Simon 2019-06-18 13:20 ` [igt-dev] " Ser, Simon 2019-06-18 13:59 ` Guillaume Tucker 2019-06-18 13:59 ` [igt-dev] " Guillaume Tucker 2019-06-18 14:37 ` Ser, Simon 2019-06-18 14:37 ` [igt-dev] " Ser, Simon 2019-06-18 16:03 ` Guillaume Tucker 2019-06-18 16:03 ` [igt-dev] " Guillaume Tucker 2019-06-19 6:42 ` Ser, Simon 2019-06-19 6:42 ` [igt-dev] " Ser, Simon 2019-06-19 7:24 ` Guillaume Tucker 2019-06-19 7:24 ` [igt-dev] " Guillaume Tucker 2019-06-18 12:27 ` [PATCH i-g-t v3 2/4] gitlab-ci: add libatomic to docker images Guillaume Tucker 2019-06-18 12:27 ` [igt-dev] " Guillaume Tucker 2019-06-19 6:50 ` Ser, Simon 2019-06-19 6:50 ` [igt-dev] " Ser, Simon 2019-06-19 8:09 ` Guillaume Tucker [this message] 2019-06-19 8:09 ` Guillaume Tucker 2019-06-18 12:27 ` [PATCH i-g-t v3 3/4] i915/gem_create: use atomic_* instead of __sync_* Guillaume Tucker 2019-06-18 12:27 ` [igt-dev] " Guillaume Tucker 2019-06-18 12:27 ` [PATCH i-g-t v3 4/4] tests/sw_sync: " Guillaume Tucker 2019-06-18 12:27 ` [Intel-gfx] " Guillaume Tucker 2019-06-18 13:31 ` [igt-dev] ✗ Fi.CI.BAT: failure for Use C11 atomics (rev2) Patchwork 2019-06-19 6:52 ` Ser, Simon 2019-06-19 7:02 ` Saarinen, Jani 2019-06-19 7:32 ` Peres, Martin 2019-06-19 7:46 ` Guillaume Tucker 2019-06-19 8:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Use C11 atomics (rev3) Patchwork 2019-06-19 21:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ddd054f0-8267-0961-e74b-056323a6c00a@collabora.com \ --to=guillaume.tucker@collabora.com \ --cc=arkadiusz.hiler@intel.com \ --cc=igt-dev@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=petri.latvala@intel.com \ --cc=simon.ser@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.