* [PATCH] build: fix grep invocation in cc-options
@ 2011-09-30 13:19 Ian Campbell
0 siblings, 0 replies; only message in thread
From: Ian Campbell @ 2011-09-30 13:19 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Campbell
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1317388735 -3600
# Node ID ddd1fcb1dff9f723d4f4c89f97ffef91b3e8a204
# Parent 222533abc1159bfa9c8cd522649c10079f6a6e9c
build: fix grep invocation in cc-options
Currently the build produces lots of
Usage: grep [OPTION]... PATTERN [FILE]...
Try `grep --help' for more information.
This is due to the "grep -- $(2)" in cc-options. It seems that the default of
reading stdin is disabled when using "--". I don't know if this is a bug in
grep or how it is supposed to be but we can work around it by explicitly
passing in "-"
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 222533abc115 -r ddd1fcb1dff9 Config.mk
--- a/Config.mk Fri Sep 30 14:10:25 2011 +0100
+++ b/Config.mk Fri Sep 30 14:18:55 2011 +0100
@@ -84,7 +84,7 @@ PYTHON_PREFIX_ARG ?= --install-layout=de
#
# Usage: cflags-y += $(call cc-option,$(CC),-march=winchip-c6,-march=i586)
cc-option = $(shell if test -z "`echo 'void*p=1;' | \
- $(1) $(2) -S -o /dev/null -xc - 2>&1 | grep -- $(2)`"; \
+ $(1) $(2) -S -o /dev/null -xc - 2>&1 | grep -- $(2) -`"; \
then echo "$(2)"; else echo "$(3)"; fi ;)
# cc-option-add: Add an option to compilation flags, but only if supported.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-09-30 13:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-30 13:19 [PATCH] build: fix grep invocation in cc-options Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.