All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net] tcp: fix syn cookied MPTCP request socket leak
Date: Mon, 14 Sep 2020 15:54:14 +0200	[thread overview]
Message-ID: <dde989490e00adfa9f2b56fd51736fd7b1880270.camel@redhat.com> (raw)
In-Reply-To: CA+WQbwuNsAFfnu2nnGPdmrU42_xJkA+GsbbV64kjkCMNKVXyAA@mail.gmail.com

[-- Attachment #1: Type: text/plain, Size: 2246 bytes --]

On Mon, 2020-09-14 at 17:34 +0800, Geliang Tang wrote:
> Hi Paolo,
> 
> Thanks for your patch. I tested it. It fixed the memory leak problem.
> But I got this
> selftest fail output:
> 
> 11 single subflow with syn cookies      syn[ ok ] - synack[ ok ] - ack[ ok ]
> 12 multiple subflows with syn cookies   syn[fail] got 1 JOIN[s] syn expected 2
>  - synack[fail] got 1 JOIN[s] synack expected 2
>  - ack[fail] got 1 JOIN[s] ack expected 2
> Server ns stats
> MPTcpExtMPCapableSYNRX          1                  0.0
> MPTcpExtMPCapableACKRX          1                  0.0
> MPTcpExtMPJoinSynRx             1                  0.0
> MPTcpExtMPJoinAckRx             1                  0.0
> Client ns stats
> MPTcpExtMPJoinSynAckRx          1                  0.0
> 13 subflows limited by server w cookies syn[fail] got 1 JOIN[s] syn expected 2
>  - synack[fail] got 1 JOIN[s] synack expected 2
>  - ack[ ok ]
> Server ns stats
> MPTcpExtMPCapableSYNRX          1                  0.0
> MPTcpExtMPCapableACKRX          1                  0.0
> MPTcpExtMPJoinSynRx             1                  0.0
> MPTcpExtMPJoinAckRx             1                  0.0
> Client ns stats
> MPTcpExtMPJoinSynAckRx          1                  0.0
> 14 signal address with syn cookies      syn[ ok ] - synack[ ok ] - ack[ ok ]
> 15 subflow and signal w cookies         syn[ ok ] - synack[ ok ] - ack[ ok ]
> 16 subflows and signal w. cookies       syn[fail] got 1 JOIN[s] syn expected 3
>  - synack[fail] got 1 JOIN[s] synack expected 3
>  - ack[fail] got 1 JOIN[s] ack expected 3
> Server ns stats
> MPTcpExtMPCapableSYNRX          1                  0.0
> MPTcpExtMPCapableACKRX          1                  0.0
> MPTcpExtMPJoinSynRx             1                  0.0
> MPTcpExtMPJoinAckRx             1                  0.0
> Client ns stats
> MPTcpExtMPJoinSynAckRx          1                  0.0

I sometime see similar errors, but they are quite unfrequent, and looks
tied to the self-test fragility: we use some hard-coded sleep to allow
for MPJ/ADD_ADDR handshake. If the VM running the test is my change
slowed down a bit, self-tests will fail.

Is the above failure reproducible for you?

Thanks,

Paolo

             reply	other threads:[~2020-09-14 13:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 13:54 Paolo Abeni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-10-02 22:35 [MPTCP] Re: [PATCH net] tcp: fix syn cookied MPTCP request socket leak David Miller
2020-09-15  3:03 Geliang Tang
2020-09-14  9:34 Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dde989490e00adfa9f2b56fd51736fd7b1880270.camel@redhat.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.