From: David Miller <davem at davemloft.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net] tcp: fix syn cookied MPTCP request socket leak
Date: Fri, 02 Oct 2020 15:35:15 -0700 [thread overview]
Message-ID: <20201002.153515.522963285806177264.davem@davemloft.net> (raw)
In-Reply-To: 867cc806e4dfeb200e84b37addff2e2847f44c0e.1601635086.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
From: Paolo Abeni <pabeni(a)redhat.com>
Date: Fri, 2 Oct 2020 12:39:44 +0200
> If a syn-cookies request socket don't pass MPTCP-level
> validation done in syn_recv_sock(), we need to release
> it immediately, or it will be leaked.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/89
> Fixes: 9466a1ccebbe ("mptcp: enable JOIN requests even if cookies are in use")
> Reported-and-tested-by: Geliang Tang <geliangtang(a)gmail.com>
> Reviewed-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
Applied, thank you.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, fw@strlen.de, mptcp@lists.01.org
Subject: Re: [PATCH net] tcp: fix syn cookied MPTCP request socket leak
Date: Fri, 02 Oct 2020 15:35:15 -0700 (PDT) [thread overview]
Message-ID: <20201002.153515.522963285806177264.davem@davemloft.net> (raw)
In-Reply-To: <867cc806e4dfeb200e84b37addff2e2847f44c0e.1601635086.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Fri, 2 Oct 2020 12:39:44 +0200
> If a syn-cookies request socket don't pass MPTCP-level
> validation done in syn_recv_sock(), we need to release
> it immediately, or it will be leaked.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/89
> Fixes: 9466a1ccebbe ("mptcp: enable JOIN requests even if cookies are in use")
> Reported-and-tested-by: Geliang Tang <geliangtang@gmail.com>
> Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied, thank you.
next reply other threads:[~2020-10-02 22:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 22:35 David Miller [this message]
2020-10-02 22:35 ` [PATCH net] tcp: fix syn cookied MPTCP request socket leak David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-10-02 10:39 [MPTCP] " Paolo Abeni
2020-10-02 10:39 ` Paolo Abeni
2020-09-15 3:03 [MPTCP] " Geliang Tang
2020-09-14 13:54 Paolo Abeni
2020-09-14 9:34 Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002.153515.522963285806177264.davem@davemloft.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.