All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] Added TMP421 type sensor's support in tiogapass
@ 2023-03-07 10:19 Karthikeyan Pasupathi
  2023-03-07 10:28 ` karthikeyan Pasupathi
  2023-03-07 10:28 ` Cédric Le Goater
  0 siblings, 2 replies; 5+ messages in thread
From: Karthikeyan Pasupathi @ 2023-03-07 10:19 UTC (permalink / raw)
  To: clg, peter.maydell, andrew, joel, qemu-arm, qemu-devel
  Cc: Karthikeyan Pasupathi

Added TMP421 type sensor support in tiogapass platform.

Tested: Tested and verified in tiogapass platform.

Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
---
 hw/arm/aspeed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index e985ce85e5..c1843693fa 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -545,7 +545,7 @@ static void tiogapass_bmc_i2c_init(AspeedMachineState *bmc)
     /* TMP421 */
     i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8), "tmp421", 0x1f);
     i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4f);
-    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4e); 
+    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4e);
 }
 
 static void create_pca9552(AspeedSoCState *soc, int bus_id, int addr)
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] Added TMP421 type sensor's support in tiogapass
  2023-03-07 10:19 [PATCH v1] Added TMP421 type sensor's support in tiogapass Karthikeyan Pasupathi
@ 2023-03-07 10:28 ` karthikeyan Pasupathi
  2023-03-07 10:28 ` Cédric Le Goater
  1 sibling, 0 replies; 5+ messages in thread
From: karthikeyan Pasupathi @ 2023-03-07 10:28 UTC (permalink / raw)
  To: clg, peter.maydell, andrew, joel, qemu-arm, qemu-devel

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

Hi Goater,
               please ignore this patch, I have missed something here and
I'll send
one more patch, sorry for the inconvenience.

Regards,
Karthikeyan P


On Tue, Mar 7, 2023 at 3:51 PM Karthikeyan Pasupathi <
pkarthikeyan1509@gmail.com> wrote:

> Added TMP421 type sensor support in tiogapass platform.
>
> Tested: Tested and verified in tiogapass platform.
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
>  hw/arm/aspeed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index e985ce85e5..c1843693fa 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -545,7 +545,7 @@ static void tiogapass_bmc_i2c_init(AspeedMachineState
> *bmc)
>      /* TMP421 */
>      i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8), "tmp421",
> 0x1f);
>      i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421",
> 0x4f);
> -    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421",
> 0x4e);
> +    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421",
> 0x4e);
>  }
>
>  static void create_pca9552(AspeedSoCState *soc, int bus_id, int addr)
> --
> 2.34.1
>
>

[-- Attachment #2: Type: text/html, Size: 1814 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] Added TMP421 type sensor's support in tiogapass
  2023-03-07 10:19 [PATCH v1] Added TMP421 type sensor's support in tiogapass Karthikeyan Pasupathi
  2023-03-07 10:28 ` karthikeyan Pasupathi
@ 2023-03-07 10:28 ` Cédric Le Goater
  1 sibling, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2023-03-07 10:28 UTC (permalink / raw)
  To: Karthikeyan Pasupathi, peter.maydell, andrew, joel, qemu-arm, qemu-devel

Hello Karthikeyan,

On 3/7/23 11:19, Karthikeyan Pasupathi wrote:
> Added TMP421 type sensor support in tiogapass platform.
> 
> Tested: Tested and verified in tiogapass platform.
> 
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
>   hw/arm/aspeed.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index e985ce85e5..c1843693fa 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -545,7 +545,7 @@ static void tiogapass_bmc_i2c_init(AspeedMachineState *bmc)
>       /* TMP421 */
>       i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8), "tmp421", 0x1f);
>       i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4f);
> -    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4e);
> +    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4e);
>   }
>   
>   static void create_pca9552(AspeedSoCState *soc, int bus_id, int addr)

This patch is only removing a white space at the end of a line. Is that expected ?
If so, the commit log should be changed.

Thanks,

C.


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] Added TMP421 type sensor's support in tiogapass
  2023-03-07 10:33 Karthikeyan Pasupathi
@ 2023-03-07 13:53 ` Cédric Le Goater
  0 siblings, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2023-03-07 13:53 UTC (permalink / raw)
  To: Karthikeyan Pasupathi, peter.maydell, andrew, joel, qemu-arm, qemu-devel

On 3/7/23 11:33, Karthikeyan Pasupathi wrote:
> Added TMP421 type sensor support in tiogapass platform.
> 
> Tested: Tested and verified in tiogapass platform.
> 
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> ---
>   hw/arm/aspeed.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 86601cb1a5..c1843693fa 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -542,6 +542,10 @@ static void tiogapass_bmc_i2c_init(AspeedMachineState *bmc)
>       at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 4), 0x54, 128 * KiB);
>       at24c_eeprom_init_rom(aspeed_i2c_get_bus(&soc->i2c, 6), 0x54, 128 * KiB,
>                             tiogapass_bmc_fruid, tiogapass_bmc_fruid_len);
> +    /* TMP421 */
> +    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8), "tmp421", 0x1f);
> +    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4f);
> +    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4e);
>   }
>   
>   static void create_pca9552(AspeedSoCState *soc, int bus_id, int addr)



^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH v1] Added TMP421 type sensor's support in tiogapass
@ 2023-03-07 10:33 Karthikeyan Pasupathi
  2023-03-07 13:53 ` Cédric Le Goater
  0 siblings, 1 reply; 5+ messages in thread
From: Karthikeyan Pasupathi @ 2023-03-07 10:33 UTC (permalink / raw)
  To: clg, peter.maydell, andrew, joel, qemu-arm, qemu-devel
  Cc: Karthikeyan Pasupathi

Added TMP421 type sensor support in tiogapass platform.

Tested: Tested and verified in tiogapass platform.

Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
---
 hw/arm/aspeed.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 86601cb1a5..c1843693fa 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -542,6 +542,10 @@ static void tiogapass_bmc_i2c_init(AspeedMachineState *bmc)
     at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 4), 0x54, 128 * KiB);
     at24c_eeprom_init_rom(aspeed_i2c_get_bus(&soc->i2c, 6), 0x54, 128 * KiB,
                           tiogapass_bmc_fruid, tiogapass_bmc_fruid_len);
+    /* TMP421 */
+    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8), "tmp421", 0x1f);
+    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4f);
+    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), "tmp421", 0x4e);
 }
 
 static void create_pca9552(AspeedSoCState *soc, int bus_id, int addr)
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-07 13:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 10:19 [PATCH v1] Added TMP421 type sensor's support in tiogapass Karthikeyan Pasupathi
2023-03-07 10:28 ` karthikeyan Pasupathi
2023-03-07 10:28 ` Cédric Le Goater
2023-03-07 10:33 Karthikeyan Pasupathi
2023-03-07 13:53 ` Cédric Le Goater

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.