All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485
@ 2022-07-29 12:10 Giulio Benetti
  2022-07-29 12:10 ` [Buildroot] [PATCH 2/2] package/mariadb: work around " Giulio Benetti
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Giulio Benetti @ 2022-07-29 12:10 UTC (permalink / raw)
  To: buildroot
  Cc: Giulio Benetti, Romain Naour, Thomas Petazzoni, Thomas De Schampheleire

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 toolchain/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index e6fabbfc74..6d12b6fed7 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -139,7 +139,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_7
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. This bug still
-# exists in gcc 9.x
+# exists in gcc 11.x
 config BR2_TOOLCHAIN_HAS_GCC_BUG_68485
 	bool
 	default y if BR2_microblaze
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 2/2] package/mariadb: work around gcc bug 68485
  2022-07-29 12:10 [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485 Giulio Benetti
@ 2022-07-29 12:10 ` Giulio Benetti
  2022-09-13 14:15   ` Peter Korsgaard
  2022-07-29 12:12 ` [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for " Thomas Petazzoni via buildroot
  2022-07-29 19:58 ` Thomas Petazzoni via buildroot
  2 siblings, 1 reply; 8+ messages in thread
From: Giulio Benetti @ 2022-07-29 12:10 UTC (permalink / raw)
  To: buildroot
  Cc: Giulio Benetti, Romain Naour, Thomas Petazzoni, Thomas De Schampheleire

With Microblaze Gcc version <= 11.x the build fails due to gcc bug 68485:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. The bug show up when
building mariadb with optimization but not when building with -O0. To
work around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_68458=y, we force using
-O0.

Fixes:
http://autobuild.buildroot.net/results/9b5/9b5dce4958b602c80140440addb1f072332e53c2/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/mariadb/mariadb.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/mariadb/mariadb.mk b/package/mariadb/mariadb.mk
index 06fd1484b6..4c855985b1 100644
--- a/package/mariadb/mariadb.mk
+++ b/package/mariadb/mariadb.mk
@@ -82,6 +82,10 @@ ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 MARIADB_CXXFLAGS += -latomic
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+MARIADB_CXXFLAGS += -O0
+endif
+
 MARIADB_CONF_OPTS += \
 	-DCMAKE_CXX_FLAGS="$(MARIADB_CXXFLAGS)" \
 	-DINSTALL_DOCDIR=share/doc/mariadb-$(MARIADB_VERSION) \
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485
  2022-07-29 12:10 [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485 Giulio Benetti
  2022-07-29 12:10 ` [Buildroot] [PATCH 2/2] package/mariadb: work around " Giulio Benetti
@ 2022-07-29 12:12 ` Thomas Petazzoni via buildroot
  2022-07-29 12:29   ` Giulio Benetti
  2022-07-29 19:58 ` Thomas Petazzoni via buildroot
  2 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-29 12:12 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Romain Naour, Thomas De Schampheleire, buildroot

On Fri, 29 Jul 2022 14:10:54 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

>  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. This bug still
> -# exists in gcc 9.x
> +# exists in gcc 11.x

What about the recently introduced gcc 12.x ? :-)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485
  2022-07-29 12:12 ` [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for " Thomas Petazzoni via buildroot
@ 2022-07-29 12:29   ` Giulio Benetti
  2022-07-29 12:33     ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 8+ messages in thread
From: Giulio Benetti @ 2022-07-29 12:29 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: Romain Naour, Thomas De Schampheleire, buildroot

On 29/07/22 14:12, Thomas Petazzoni via buildroot wrote:
> On Fri, 29 Jul 2022 14:10:54 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. This bug still
>> -# exists in gcc 9.x
>> +# exists in gcc 11.x
> 
> What about the recently introduced gcc 12.x ? :-)

You're right, gcc 12.x is still affected, do you want me to re-send?

-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485
  2022-07-29 12:29   ` Giulio Benetti
@ 2022-07-29 12:33     ` Thomas Petazzoni via buildroot
  2022-07-29 12:47       ` Giulio Benetti
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-29 12:33 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Romain Naour, Thomas De Schampheleire, buildroot

On Fri, 29 Jul 2022 14:29:53 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> On 29/07/22 14:12, Thomas Petazzoni via buildroot wrote:
> > On Fri, 29 Jul 2022 14:10:54 +0200
> > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> >   
> >>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. This bug still
> >> -# exists in gcc 9.x
> >> +# exists in gcc 11.x  
> > 
> > What about the recently introduced gcc 12.x ? :-)  
> 
> You're right, gcc 12.x is still affected, do you want me to re-send?

Not needed, will fix when applying. Thanks!


-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485
  2022-07-29 12:33     ` Thomas Petazzoni via buildroot
@ 2022-07-29 12:47       ` Giulio Benetti
  0 siblings, 0 replies; 8+ messages in thread
From: Giulio Benetti @ 2022-07-29 12:47 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: Romain Naour, Thomas De Schampheleire, buildroot



On 29/07/22 14:33, Thomas Petazzoni via buildroot wrote:
> On Fri, 29 Jul 2022 14:29:53 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> On 29/07/22 14:12, Thomas Petazzoni via buildroot wrote:
>>> On Fri, 29 Jul 2022 14:10:54 +0200
>>> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>>>    
>>>>    # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. This bug still
>>>> -# exists in gcc 9.x
>>>> +# exists in gcc 11.x
>>>
>>> What about the recently introduced gcc 12.x ? :-)
>>
>> You're right, gcc 12.x is still affected, do you want me to re-send?
> 
> Not needed, will fix when applying. Thanks!

Perfect, thank you!

-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485
  2022-07-29 12:10 [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485 Giulio Benetti
  2022-07-29 12:10 ` [Buildroot] [PATCH 2/2] package/mariadb: work around " Giulio Benetti
  2022-07-29 12:12 ` [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for " Thomas Petazzoni via buildroot
@ 2022-07-29 19:58 ` Thomas Petazzoni via buildroot
  2 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-29 19:58 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Romain Naour, Thomas De Schampheleire, buildroot

On Fri, 29 Jul 2022 14:10:54 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  toolchain/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both applied, but mentioning gcc 12 instead of gcc 11. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH 2/2] package/mariadb: work around gcc bug 68485
  2022-07-29 12:10 ` [Buildroot] [PATCH 2/2] package/mariadb: work around " Giulio Benetti
@ 2022-09-13 14:15   ` Peter Korsgaard
  0 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2022-09-13 14:15 UTC (permalink / raw)
  To: Giulio Benetti
  Cc: Romain Naour, Thomas De Schampheleire, Thomas Petazzoni, buildroot

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > With Microblaze Gcc version <= 11.x the build fails due to gcc bug 68485:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. The bug show up when
 > building mariadb with optimization but not when building with -O0. To
 > work around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_68458=y, we force using
 > -O0.

 > Fixes:
 > http://autobuild.buildroot.net/results/9b5/9b5dce4958b602c80140440addb1f072332e53c2/

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-09-13 14:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29 12:10 [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for gcc bug 68485 Giulio Benetti
2022-07-29 12:10 ` [Buildroot] [PATCH 2/2] package/mariadb: work around " Giulio Benetti
2022-09-13 14:15   ` Peter Korsgaard
2022-07-29 12:12 ` [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc version for " Thomas Petazzoni via buildroot
2022-07-29 12:29   ` Giulio Benetti
2022-07-29 12:33     ` Thomas Petazzoni via buildroot
2022-07-29 12:47       ` Giulio Benetti
2022-07-29 19:58 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.