All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Mario.Limonciello@dell.com>
To: <quasisec@google.com>
Cc: <dvhart@infradead.org>, <andy.shevchenko@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>, <luto@kernel.org>,
	<pali.rohar@gmail.com>, <rjw@rjwysocki.net>, <mjg59@google.com>,
	<hch@lst.de>, <greg@kroah.com>, <gnomes@lxorguk.ukuu.org.uk>
Subject: RE: [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface
Date: Wed, 1 Nov 2017 16:15:06 +0000	[thread overview]
Message-ID: <de1db88b582447e7a32a2825a656147b@ausx13mpc120.AMER.DELL.COM> (raw)
In-Reply-To: <CAD584itfGPCg_oVrHGR_-67ft5Ue4kkBbt3rMa0E1uBrQ=Gydg@mail.gmail.com>

> > +/* This structure may be modified by the firmware when we enter
> > + * system management mode through SMM, hence the volatiles
> > + */
> > +struct calling_interface_buffer {
> > +       __u16 class;
> 
> Hey Mario,
> 
> I just realized that there is a slight problem calling this identifier
> "class" for userspace that happens to be written in C++ that #includes
> this header as class is a reversed word.
> Perhaps we could rename it to class_ or something otherwise userspace
> has to shim with a C object and extern it with new identifiers to the
> C++ component, which is awkward.

Edward,

Ah darn, I wish we would have caught this earlier in the series development,
but it's better to do fix it now rather than after the uapi has been included in
a kernel.

Darren,

I think I should adjust the series for this change to
s/class/cmd_class; s/select/cmd_select/
.
As ->class is used in many patches in the series, it will require be better to
resend as v12 rather than a single patch that changes this one thing.

I'll send it later this afternoon.

Thanks,

WARNING: multiple messages have this Message-ID (diff)
From: <Mario.Limonciello@dell.com>
To: quasisec@google.com
Cc: dvhart@infradead.org, andy.shevchenko@gmail.com,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, luto@kernel.org,
	pali.rohar@gmail.com, rjw@rjwysocki.net, mjg59@google.com,
	hch@lst.de, greg@kroah.com, gnomes@lxorguk.ukuu.org.uk
Subject: RE: [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface
Date: Wed, 1 Nov 2017 16:15:06 +0000	[thread overview]
Message-ID: <de1db88b582447e7a32a2825a656147b@ausx13mpc120.AMER.DELL.COM> (raw)
In-Reply-To: <CAD584itfGPCg_oVrHGR_-67ft5Ue4kkBbt3rMa0E1uBrQ=Gydg@mail.gmail.com>

> > +/* This structure may be modified by the firmware when we enter
> > + * system management mode through SMM, hence the volatiles
> > + */
> > +struct calling_interface_buffer {
> > +       __u16 class;
> 
> Hey Mario,
> 
> I just realized that there is a slight problem calling this identifier
> "class" for userspace that happens to be written in C++ that #includes
> this header as class is a reversed word.
> Perhaps we could rename it to class_ or something otherwise userspace
> has to shim with a C object and extern it with new identifiers to the
> C++ component, which is awkward.

Edward,

Ah darn, I wish we would have caught this earlier in the series development,
but it's better to do fix it now rather than after the uapi has been included in
a kernel.

Darren,

I think I should adjust the series for this change to
s/class/cmd_class; s/select/cmd_select/
.
As ->class is used in many patches in the series, it will require be better to
resend as v12 rather than a single patch that changes this one thing.

I'll send it later this afternoon.

Thanks,




  reply	other threads:[~2017-11-01 16:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20 17:40 [PATCH v11 00/15] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 01/15] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 02/15] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 03/15] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 04/15] platform/x86: dell-wmi: don't check length returned Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello
2017-10-30 11:46   ` Pali Rohár
2017-10-30 13:32     ` Mario.Limonciello
2017-10-30 13:32       ` Mario.Limonciello
2017-10-31 23:31       ` Darren Hart
2017-11-01  8:19         ` Pali Rohár
2017-11-01 16:42           ` Mario.Limonciello
2017-11-01 16:42             ` Mario.Limonciello
2017-10-20 17:40 ` [PATCH v11 06/15] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 07/15] platform/x86: dell-smbios: only run if proper oem string is detected Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-10-30 11:56   ` Pali Rohár
2017-10-30 13:36     ` Mario.Limonciello
2017-10-30 13:36       ` Mario.Limonciello
2017-10-31 15:24       ` Darren Hart
2017-10-20 17:40 ` [PATCH v11 09/15] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 10/15] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 11/15] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 12/15] platform/x86: dell-smbios: Add filtering support Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 13/15] platform/x86: wmi: create userspace interface for drivers Mario Limonciello
2017-10-20 17:40 ` [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello
2017-10-28 13:18   ` Darren Hart
2017-11-01  0:27   ` Edward O'Callaghan
2017-11-01 16:15     ` Mario.Limonciello [this message]
2017-11-01 16:15       ` Mario.Limonciello
2017-10-20 17:40 ` [PATCH v11 15/15] tools/wmi: add a sample for dell smbios communication over WMI Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de1db88b582447e7a32a2825a656147b@ausx13mpc120.AMER.DELL.COM \
    --to=mario.limonciello@dell.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mjg59@google.com \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=quasisec@google.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.