From: Randy Dunlap <rdunlap@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>,
"dvhart@infradead.org" <dvhart@infradead.org>,
"fengguang.wu@intel.com" <fengguang.wu@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>
Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
Date: Mon, 24 Oct 2016 10:11:27 -0700 [thread overview]
Message-ID: <de3cb2b3-6c04-ab79-3fd6-0e0f9af9080f@infradead.org> (raw)
In-Reply-To: <AM5PR0501MB20976E48C946BD3DB3A79143A2A90@AM5PR0501MB2097.eurprd05.prod.outlook.com>
On 10/23/16 22:41, Vadim Pasternak wrote:
>
>
>> -----Original Message-----
>> From: Randy Dunlap [mailto:rdunlap@infradead.org]
>> Sent: Sunday, October 23, 2016 7:57 PM
>> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
>> fengguang.wu@intel.com
>> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
>> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
>> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
>> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
>> andriy.shevchenko@linux.intel.com
>> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
>> hotplug driver in Kconfig
>>
>> On 10/23/16 05:45, vadimp@mellanox.com wrote:
>>> From: Vadim Pasternak <vadimp@mellanox.com>
>>>
>>> Add select HWMON for mlxcpld-hotplug driver config, since it requires
>>> hwmon APIs.
>>>
>>> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
>>> ---
>>> drivers/platform/x86/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/Kconfig
>>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>>> tristate "Mellanox platform hotplug driver support"
>>> default n
>>> depends on MLX_PLATFORM
>>> + select HWMON
>>> select I2C
>>> ---help---
>>> This driver handles hot-plug events for the power suppliers, power
>>>
>>
>> Hi,
>> did you test this? I would expect it to cause a kconfig warning, something about
>> HWMON having a dependency on HAS_IOMEM.
>
> Hi Randy,
>
> Yes,
> I built tree with this fix with the attached .config file.
> Didn't see kconfig warnings.
> I can have a look again.
No need. lib/Kconfig handles it:
config HAS_IOMEM
bool
depends on !NO_IOMEM
select GENERIC_IO
default y
thanks.
--
~Randy
next prev parent reply other threads:[~2016-10-24 17:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 12:45 [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig vadimp
2016-10-23 14:51 ` Darren Hart
2016-10-24 5:33 ` Vadim Pasternak
2016-10-24 5:33 ` Vadim Pasternak
2016-10-23 16:57 ` Randy Dunlap
2016-10-24 5:41 ` Vadim Pasternak
2016-10-24 5:41 ` Vadim Pasternak
2016-10-24 17:11 ` Randy Dunlap [this message]
2016-10-24 17:11 ` Randy Dunlap
2016-10-24 18:10 ` Darren Hart
2016-10-24 18:10 ` Darren Hart
2016-10-24 6:01 ` Vadim Pasternak
2016-10-24 6:01 ` Vadim Pasternak
2016-10-24 8:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de3cb2b3-6c04-ab79-3fd6-0e0f9af9080f@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dvhart@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.