From: Matthias Brugger <matthias.bgg@gmail.com> To: Tiffany Lin <tiffany.lin@mediatek.com>, Hans Verkuil <hans.verkuil@cisco.com>, daniel.thompson@linaro.org, Rob Herring <robh+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, Daniel Kurtz <djkurtz@chromium.org>, Pawel Osciak <posciak@chromium.org> Cc: Eddie Huang <eddie.huang@mediatek.com>, Yingjoe Chen <yingjoe.chen@mediatek.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, PoChun.Lin@mediatek.com Subject: Re: [PATCH v4 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173 Date: Thu, 11 Aug 2016 17:44:27 +0200 [thread overview] Message-ID: <de51caf8-6db5-4754-0683-d3390dd2ac09@gmail.com> (raw) In-Reply-To: <1470840534-4788-10-git-send-email-tiffany.lin@mediatek.com> On 10/08/16 16:48, Tiffany Lin wrote: > Add video decoder node for MT8173 > > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 10f638f..2872cd7 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -974,6 +974,50 @@ > #clock-cells = <1>; > }; > > + vcodec_dec: vcodec@16000000 { > + compatible = "mediatek,mt8173-vcodec-dec"; > + reg = <0 0x16000000 0 0x100>, /* VDEC_SYS */ > + <0 0x16020000 0 0x1000>, /* VDEC_MISC */ > + <0 0x16021000 0 0x800>, /* VDEC_LD */ > + <0 0x16021800 0 0x800>, /* VDEC_TOP */ > + <0 0x16022000 0 0x1000>, /* VDEC_CM */ > + <0 0x16023000 0 0x1000>, /* VDEC_AD */ > + <0 0x16024000 0 0x1000>, /* VDEC_AV */ > + <0 0x16025000 0 0x1000>, /* VDEC_PP */ > + <0 0x16026800 0 0x800>, /* VDEC_HWD */ > + <0 0x16027000 0 0x800>, /* VDEC_HWQ */ > + <0 0x16027800 0 0x800>, /* VDEC_HWB */ > + <0 0x16028400 0 0x400>; /* VDEC_HWG */ > + interrupts = <GIC_SPI 204 IRQ_TYPE_LEVEL_LOW>; > + mediatek,larb = <&larb1>; > + iommus = <&iommu M4U_PORT_HW_VDEC_MC_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PP_EXT>, > + <&iommu M4U_PORT_HW_VDEC_AVC_MV_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PRED_RD_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PRED_WR_EXT>, > + <&iommu M4U_PORT_HW_VDEC_UFO_EXT>, > + <&iommu M4U_PORT_HW_VDEC_VLD_EXT>, > + <&iommu M4U_PORT_HW_VDEC_VLD2_EXT>; > + mediatek,vpu = <&vpu>; > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VDEC>; > + clocks = <&apmixedsys CLK_APMIXED_VCODECPLL>, > + <&topckgen CLK_TOP_UNIVPLL_D2>, > + <&topckgen CLK_TOP_CCI400_SEL>, > + <&topckgen CLK_TOP_VDEC_SEL>, > + <&topckgen CLK_TOP_VCODECPLL>, > + <&apmixedsys CLK_APMIXED_VENCPLL>, > + <&topckgen CLK_TOP_VENC_LT_SEL>, > + <&topckgen CLK_TOP_VCODECPLL_370P5>; > + clock-names = "vcodecpll", > + "univpll_d2", > + "clk_cci400_sel", > + "vdec_sel", > + "vdecpll", > + "vencpll", > + "venc_lt_sel", > + "vdec_bus_clk_src"; > + }; > + Shouldn't we set here: status = "disabled"; To save power on headless systems? Regards, Matthias > larb1: larb@16010000 { > compatible = "mediatek,mt8173-smi-larb"; > reg = <0 0x16010000 0 0x1000>; >
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173 Date: Thu, 11 Aug 2016 17:44:27 +0200 [thread overview] Message-ID: <de51caf8-6db5-4754-0683-d3390dd2ac09@gmail.com> (raw) In-Reply-To: <1470840534-4788-10-git-send-email-tiffany.lin@mediatek.com> On 10/08/16 16:48, Tiffany Lin wrote: > Add video decoder node for MT8173 > > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 10f638f..2872cd7 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -974,6 +974,50 @@ > #clock-cells = <1>; > }; > > + vcodec_dec: vcodec at 16000000 { > + compatible = "mediatek,mt8173-vcodec-dec"; > + reg = <0 0x16000000 0 0x100>, /* VDEC_SYS */ > + <0 0x16020000 0 0x1000>, /* VDEC_MISC */ > + <0 0x16021000 0 0x800>, /* VDEC_LD */ > + <0 0x16021800 0 0x800>, /* VDEC_TOP */ > + <0 0x16022000 0 0x1000>, /* VDEC_CM */ > + <0 0x16023000 0 0x1000>, /* VDEC_AD */ > + <0 0x16024000 0 0x1000>, /* VDEC_AV */ > + <0 0x16025000 0 0x1000>, /* VDEC_PP */ > + <0 0x16026800 0 0x800>, /* VDEC_HWD */ > + <0 0x16027000 0 0x800>, /* VDEC_HWQ */ > + <0 0x16027800 0 0x800>, /* VDEC_HWB */ > + <0 0x16028400 0 0x400>; /* VDEC_HWG */ > + interrupts = <GIC_SPI 204 IRQ_TYPE_LEVEL_LOW>; > + mediatek,larb = <&larb1>; > + iommus = <&iommu M4U_PORT_HW_VDEC_MC_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PP_EXT>, > + <&iommu M4U_PORT_HW_VDEC_AVC_MV_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PRED_RD_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PRED_WR_EXT>, > + <&iommu M4U_PORT_HW_VDEC_UFO_EXT>, > + <&iommu M4U_PORT_HW_VDEC_VLD_EXT>, > + <&iommu M4U_PORT_HW_VDEC_VLD2_EXT>; > + mediatek,vpu = <&vpu>; > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VDEC>; > + clocks = <&apmixedsys CLK_APMIXED_VCODECPLL>, > + <&topckgen CLK_TOP_UNIVPLL_D2>, > + <&topckgen CLK_TOP_CCI400_SEL>, > + <&topckgen CLK_TOP_VDEC_SEL>, > + <&topckgen CLK_TOP_VCODECPLL>, > + <&apmixedsys CLK_APMIXED_VENCPLL>, > + <&topckgen CLK_TOP_VENC_LT_SEL>, > + <&topckgen CLK_TOP_VCODECPLL_370P5>; > + clock-names = "vcodecpll", > + "univpll_d2", > + "clk_cci400_sel", > + "vdec_sel", > + "vdecpll", > + "vencpll", > + "venc_lt_sel", > + "vdec_bus_clk_src"; > + }; > + Shouldn't we set here: status = "disabled"; To save power on headless systems? Regards, Matthias > larb1: larb at 16010000 { > compatible = "mediatek,mt8173-smi-larb"; > reg = <0 0x16010000 0 0x1000>; >
next prev parent reply other threads:[~2016-08-11 15:44 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-10 14:48 [PATCH v4 0/9] Add MT8173 Video Decoder Driver Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin 2016-08-10 14:48 ` [PATCH v4 1/9] VPU: mediatek: Add decode support Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin [not found] ` <1470840534-4788-2-git-send-email-tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2016-08-10 14:48 ` [PATCH v4 2/9] v4l: add Mediatek compressed video block format Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin [not found] ` <1470840534-4788-3-git-send-email-tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2016-08-10 14:48 ` [PATCH v4 3/9] docs-rst: Add compressed video formats used on MT8173 codec driver Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin [not found] ` <1470840534-4788-4-git-send-email-tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2016-08-10 14:48 ` [PATCH v4 4/9] dt-bindings: Add a binding for Mediatek Video Decoder Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin [not found] ` <1470840534-4788-5-git-send-email-tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2016-08-10 14:48 ` [PATCH v4 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin [not found] ` <1470840534-4788-6-git-send-email-tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2016-08-10 14:48 ` [PATCH v4 6/9] vcodec: mediatek: Add Mediatek H264 " Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin 2016-08-10 14:48 ` [PATCH v4 7/9] vcodec: mediatek: Add Mediatek VP8 " Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin 2016-08-10 14:48 ` [PATCH v4 8/9] vcodec: mediatek: Add Mediatek VP9 " Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin 2016-08-10 14:48 ` [PATCH v4 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173 Tiffany Lin 2016-08-10 14:48 ` Tiffany Lin 2016-08-11 15:44 ` Matthias Brugger [this message] 2016-08-11 15:44 ` Matthias Brugger 2016-08-12 9:21 ` Tiffany Lin 2016-08-12 9:21 ` Tiffany Lin 2016-08-12 9:21 ` Tiffany Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=de51caf8-6db5-4754-0683-d3390dd2ac09@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=PoChun.Lin@mediatek.com \ --cc=daniel.thompson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=djkurtz@chromium.org \ --cc=eddie.huang@mediatek.com \ --cc=hans.verkuil@cisco.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mchehab@osg.samsung.com \ --cc=posciak@chromium.org \ --cc=robh+dt@kernel.org \ --cc=tiffany.lin@mediatek.com \ --cc=yingjoe.chen@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.