All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Chulski <stefanc@marvell.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
	Andrew Lunn <andrew@lunn.ch>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"kishon@ti.com" <kishon@ti.com>,
	"jason@lakedaemon.net" <jason@lakedaemon.net>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>,
	"gregory.clement@free-electrons.com" 
	<gregory.clement@free-electrons.com>,
	"thomas.petazzoni@free-electrons.com" 
	<thomas.petazzoni@free-electrons.com>,
	Nadav Haklai <nadavh@marvell.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mw@semihalf.com" <mw@semihalf.com>,
	"miquel.raynal@free-electrons.com"
	<miquel.raynal@free-electrons.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode
Date: Thu, 24 Aug 2017 17:08:29 +0000	[thread overview]
Message-ID: <de67e234a7ff43b49346be5cea2466eb@IL-EXCH01.marvell.com> (raw)
In-Reply-To: <20170824161945.GG28443@kwain>

> > Imagine phylib is using the copper Ethernet PHY, but the MAC is using
> > the SFP port. Somebody pulls out the copper cable, phylib says the
> > link is down, turns the carrier off and calls the callback. Not good,
> > since your SFP cable is still plugged in...  Ethtool is
> > returning/setting stuff in the Copper Ethernet PHY, when in fact you
> > intend to be setting SFP settings.
> 
> I see what could be the issue but I do not understand one aspect though:
> how could we switch from one PHY to another, as there's only one output
> between the SoC (and so a given GoP#) and the board. So if a given PHY can
> handle multiple modes I see, but in the other case a muxing somewhere would
> be needed? Or did I miss something?

I think PHY name and PHY mode struct that describe here both MAC to PHY and PHY to PHY connection create confusion...
Serdes IP lane doesn't care if connector is SFP, RJ45 or direct attached cable. mvpp22_comphy_init only configures MAC to PHY
connection. SFI for 10G(KR in mainline), SGMII for 1G and HS_SGMII for 2.5G.

Regards,
Stefan.

  parent reply	other threads:[~2017-08-24 17:08 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  8:38 [PATCH net-next 00/13] net: mvpp2: comphy configuration Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the phy_mode enum Antoine Tenart
2017-08-24 13:19   ` Andrew Lunn
2017-08-24 13:31     ` Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart
2017-08-24 13:39   ` Andrew Lunn
2017-08-24 13:44     ` Antoine Tenart
2017-08-24 13:51       ` Andrew Lunn
2017-08-24 13:57         ` Stefan Chulski
2017-08-24 13:57           ` Stefan Chulski
2017-08-24 14:01           ` Antoine Tenart
2017-08-24 14:01             ` Antoine Tenart
2017-08-24 14:02           ` Andrew Lunn
2017-08-24 14:02             ` Andrew Lunn
2017-08-24 13:45   ` Andrew Lunn
2017-08-24 13:58     ` Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 03/13] Documentation/bindings: phy: document the Marvell " Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 04/13] net: mvpp2: initialize the comphy Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 05/13] net: mvpp2: do not force the link mode Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 06/13] net: mvpp2: simplify the link_event function Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 07/13] net: mvpp2: improve the link management function Antoine Tenart
2017-08-24 14:06   ` Andrew Lunn
2017-08-24 14:14     ` Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 08/13] net: mvpp2: check the netif is running in the link_event function Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart
2017-08-24 14:56   ` Andrew Lunn
2017-08-24 15:52     ` Antoine Tenart
2017-08-24 16:01       ` Andrew Lunn
2017-08-24 16:19         ` Antoine Tenart
2017-08-24 16:57           ` Andrew Lunn
2017-08-24 17:04             ` Russell King - ARM Linux
2017-08-24 17:13               ` Antoine Tenart
2017-08-24 17:25                 ` [EXT] " Stefan Chulski
2017-08-24 17:25                   ` Stefan Chulski
2017-08-24 17:08           ` Stefan Chulski [this message]
2017-08-24 17:08             ` Stefan Chulski
2017-08-24 17:14             ` Antoine Tenart
2017-08-24 17:14               ` Antoine Tenart
2017-08-24 17:16               ` Stefan Chulski
2017-08-24 17:16                 ` Stefan Chulski
2017-08-25  8:19               ` Russell King - ARM Linux
2017-08-25  8:19                 ` Russell King - ARM Linux
2017-08-24 16:59     ` Russell King - ARM Linux
2017-08-24 17:45       ` Andrew Lunn
2017-08-24 22:16         ` Russell King - ARM Linux
2017-08-24  8:38 ` [PATCH net-next 10/13] arm64: dts: marvell: extend the cp110 syscon register area length Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 11/13] arm64: dts: marvell: add comphy nodes on cp110 master and slave Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 12/13] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart
2017-08-24 13:58   ` Andrew Lunn
2017-08-24 14:03     ` Antoine Tenart
2017-08-24  8:38 ` [PATCH net-next 13/13] arm64: defconfig: enable Marvell CP110 comphy Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de67e234a7ff43b49346be5cea2466eb@IL-EXCH01.marvell.com \
    --to=stefanc@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@free-electrons.com \
    --cc=davem@davemloft.net \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=miquel.raynal@free-electrons.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.