All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <dunlapg@umich.edu>
To: Ananth <cbananth@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Issues while running Xen with new RR scheduler
Date: Mon, 27 Apr 2009 21:41:43 +0100	[thread overview]
Message-ID: <de76405a0904271341m2114d923ge0fc645d3ac97854@mail.gmail.com> (raw)
In-Reply-To: <bdf293de0904271139q7e1b9f61u546226ff8e62b70@mail.gmail.com>

You need to pass the arguments to xen on the xen command line, not the
dom0 kernel command line.  So the following line should be:

kernel /boot/xen.gz sched=rrobin

(I haven't checked to make sure that "sched" is the right parameter.)

 -George

On Mon, Apr 27, 2009 at 7:39 PM, Ananth <cbananth@gmail.com> wrote:
> Hi,
> In continuation with my previous post, I am able to login to the compiled
> Xen. But it is continuing to run on credit scheduler even if i modify the
> kernel parameters to run using round robin scheduler.
> I have pasted the contents of the /boot/grub/menu.lst file.
>
> title Xen -- openSUSE 11.0 - 2.6.18.8 manually compiled AGAIN
> root (hd0,4)
> kernel /boot/xen.gz
> module /boot/vmlinuz-2.6.18.8-xen0
> root=/dev/disk/by-id/scsi-SATA_Hitachi_HTS5416_SB2D04E4CE7YEE-part5 showopts
> sched=rrobin vga=0x314
> module /boot/initrd-2.6.18-xen0
>
> Incidentally, even if i give sched=sedf, it still runs only on credit
> scheduler. Please let me know your feedback on this issue. My aim is to
> study the performance statistics of credit, sedf and new RR scheduler. It
> would be great if you could give me any pointers to measure scheduler
> performance or get statistics from the system.
>
> Thanks & Regards
> Ananth
>
> ---------- Forwarded message ----------
> From: Ananth <cbananth@gmail.com>
> Date: Mon, Apr 27, 2009 at 6:45 PM
> Subject: Re: [Xen-devel] Fwd: Error while compiling with new RR scheduler
> To: George Dunlap <dunlapg@umich.edu>
> Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
>
>
> Hello,
> Thank you so much for pointing it out. How could I miss something so
> obvious. I am able to compile it now. I will get back to you in case I get
> into any issues during run time.
>
> Thank you.
>
> Regards
> Ananth
>
> On Mon, Apr 27, 2009 at 6:29 PM, George Dunlap <dunlapg@umich.edu> wrote:
>>
>> The message says it pretty clearly:  you return the value of ret, but
>> there are control paths in the function for which ret.task is not set.
>>  Namely, if list_empty(runq) is true, then you will return an
>> uninitialized value, which may be anything (garbage on the stack,
>> NULL, &c).  This will most likely cause Xen to crash, as
>> xen/common/schedule.c assumes that ret.task will be a valid, non-NULL
>> pointer.
>>
>> If you happen to know that runq is never empty, then you don't need
>> the if statement.  If it may be empty, then you need an else clause to
>> return the idle vcpu for that processor.
>>
>>  -George
>>
>> 2009/4/24 Ananth <cbananth@gmail.com>:
>> > Hi,
>> > I figured out that the error was because of a missing ' ; ' . This has
>> > been fixed now. I have attached the modified code.
>> > While compiling I am getting the below error message.
>> >
>> > cc1: warnings being treated as errors
>> > sched_rrobin.c: In function ‘rrobin_schedule’:
>> > sched_rrobin.c:74: error: ‘ret.task’ may be used uninitialized in this
>> > function
>> >
>> > Please guide.
>> >
>> > Thanks & Regards
>> > Ananth
>> >
>> >
>> > ---------- Forwarded message ----------
>> > From: Ananth <cbananth@gmail.com>
>> > Date: Fri, Apr 24, 2009 at 7:25 PM
>> > Subject: Error while compiling with new RR scheduler
>> > To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
>> >
>> >
>> > Hi,
>> > Please find attached the source code of Round Robin scheduler which I am
>> > trying to add to Xen 3.3.1.
>> > I am facing the following error messages while compiling the same.
>> >
>> > sched_rrobin.c:31: error: two or more data types in declaration
>> > specifiers
>> >
>> > sched_rrobin.c: In function ‘rrobin_vcpu_init’:
>> >
>> > sched_rrobin.c:34: error: incompatible types in return
>> >
>> > sched_rrobin.c:51: error: incompatible types in return
>> >
>> > sched_rrobin.c:94: error: initialization from incompatible pointer type
>> >
>> > I believe the error in line 94 is causing the rest of the error
>> > messages. I have checked with the structure definition in sched-if.h as well
>> > as the implementation of the same in other schedulers such as SEDF and
>> > Credit.
>> >
>> > Request you to kindly provide your feedback regarding the same.
>> >
>> > Thanks & Regards
>> > Ananth
>> >
>> >
>> > _______________________________________________
>> > Xen-devel mailing list
>> > Xen-devel@lists.xensource.com
>> > http://lists.xensource.com/xen-devel
>> >
>> >
>
>
>

  reply	other threads:[~2009-04-27 20:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 18:39 Issues while running Xen with new RR scheduler Ananth
2009-04-27 20:41 ` George Dunlap [this message]
2009-04-27 22:39   ` Ananth
2009-04-28 14:19     ` George Dunlap
2009-04-30 22:00       ` Ananth
2009-05-01 10:25         ` George Dunlap
2009-05-01 10:27           ` George Dunlap
2009-05-01 14:48           ` Ian Jackson
2009-05-01 14:53             ` George Dunlap
2009-05-01 14:59               ` Ian Jackson
2009-05-01 15:03                 ` George Dunlap
2009-05-04  9:59                   ` Ananth
2009-05-08 20:55                     ` Ananth
2009-05-08 21:41                       ` Ananth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de76405a0904271341m2114d923ge0fc645d3ac97854@mail.gmail.com \
    --to=dunlapg@umich.edu \
    --cc=cbananth@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.