[kdave-btrfs-devel:misc-next 100/110] fs/btrfs/sysfs.c:1355:5: warning: no previous prototype for function 'btrfs_sysfs_add_fs_devices'

[kdave-btrfs-devel:misc-next 100/110] fs/btrfs/sysfs.c:1355:5: warning: no previous prototype for function 'btrfs_sysfs_add_fs_devices'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2331 bytes --]

tree:   https://github.com/kdave/btrfs-devel.git misc-next
head:   9b50c486dc82ed5ccdbea8b467b0244a57365aad
commit: fd8e11fb8ffcb957a87dd0897b2e8c8535167391 [100/110] btrfs: simplify parameters of btrfs_sysfs_add_devices_dir
config: x86_64-randconfig-a013-20200909 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 0a5dc7effb191eff740e0e7ae7bd8e1f6bdb3ad9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git checkout fd8e11fb8ffcb957a87dd0897b2e8c8535167391
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/btrfs/sysfs.c:1355:5: warning: no previous prototype for function 'btrfs_sysfs_add_fs_devices' [-Wmissing-prototypes]
   int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
       ^
   fs/btrfs/sysfs.c:1355:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
   ^
   static 
   1 warning generated.

# https://github.com/kdave/btrfs-devel/commit/fd8e11fb8ffcb957a87dd0897b2e8c8535167391
git remote add kdave-btrfs-devel https://github.com/kdave/btrfs-devel.git
git fetch --no-tags kdave-btrfs-devel misc-next
git checkout fd8e11fb8ffcb957a87dd0897b2e8c8535167391
vim +/btrfs_sysfs_add_fs_devices +1355 fs/btrfs/sysfs.c

  1354	
> 1355	int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
  1356	{
  1357		int ret;
  1358		struct btrfs_device *device;
  1359	
  1360		list_for_each_entry(device, &fs_devices->devices, dev_list) {
  1361			ret = btrfs_sysfs_add_device(device);
  1362			if (ret)
  1363				return ret;
  1364		}
  1365	
  1366		return 0;
  1367	}
  1368	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33508 bytes --]

[PATCH] fixup: btrfs: simplify parameters of btrfs_sysfs_add_devices_dir

[Anand Jain]

Add static to btrfs_sysfs_add_fs_devices()

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
Can you please roll this into the commit fd8e11fb8ffc
  btrfs: simplify parameters of btrfs_sysfs_add_devices_dir
on misc-next

 fs/btrfs/sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index 1f14b08cc04f..bc341560dc69 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -1352,7 +1352,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
 	return ret;
 }
 
-int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
+static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
 {
 	int ret;
 	struct btrfs_device *device;
-- 
2.25.1

Re: [PATCH] fixup: btrfs: simplify parameters of btrfs_sysfs_add_devices_dir

[David Sterba]

On Fri, Sep 11, 2020 at 06:09:27AM +0800, Anand Jain wrote:
> Add static to btrfs_sysfs_add_fs_devices()
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> Can you please roll this into the commit fd8e11fb8ffc
>   btrfs: simplify parameters of btrfs_sysfs_add_devices_dir
> on misc-next

Folded in, thanks.