* [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs
@ 2017-11-01 19:21 Daniel Henrique Barboza
2017-11-01 19:32 ` Daniel Henrique Barboza
2017-11-01 19:34 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Henrique Barboza @ 2017-11-01 19:21 UTC (permalink / raw)
To: qemu-devel; +Cc: mdroth, peter.maydell
When executing 'configure' in a fresh QEMU clone, in a fresh
OS install running in a ppc64le host, this is the error
shown:
-----
../configure --enable-trace-backend=simple --enable-debug
--target-list=ppc64-softmmu
ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter
-----
This isn't true, ppc64le host CPU is supported. This happens because,
in a fresh install, we don't have a C compiler to autodetect
the $cpu variable to "ppc64".
Since we need a C compiler to properly get the value of $cpu
in this and other cases, this patch changes the location of the C
compiler check right after setting the preferred CC.
Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
---
configure | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/configure b/configure
index 285d123dbf..a641bf18b6 100755
--- a/configure
+++ b/configure
@@ -467,6 +467,23 @@ else
cc="${CC-${cross_prefix}gcc}"
fi
+write_c_skeleton() {
+ cat > $TMPC <<EOF
+int main(void) { return 0; }
+EOF
+}
+
+# check that the C compiler works.
+write_c_skeleton;
+if compile_object ; then
+ : C compiler works ok
+else
+ error_exit "\"$cc\" either does not exist or does not work"
+fi
+if ! compile_prog ; then
+ error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
+fi
+
if test -z "${CXX}${cross_prefix}"; then
cxx="c++"
else
@@ -537,12 +554,6 @@ EOF
compile_object
}
-write_c_skeleton() {
- cat > $TMPC <<EOF
-int main(void) { return 0; }
-EOF
-}
-
if check_define __linux__ ; then
targetos="Linux"
elif check_define _WIN32 ; then
@@ -1593,17 +1604,6 @@ if test -z "$werror" ; then
fi
fi
-# check that the C compiler works.
-write_c_skeleton;
-if compile_object ; then
- : C compiler works ok
-else
- error_exit "\"$cc\" either does not exist or does not work"
-fi
-if ! compile_prog ; then
- error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
-fi
-
if test "$bogus_os" = "yes"; then
# Now that we know that we're not printing the help and that
# the compiler works (so the results of the check_defines we used
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs
2017-11-01 19:21 [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs Daniel Henrique Barboza
@ 2017-11-01 19:32 ` Daniel Henrique Barboza
2017-11-01 19:34 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Henrique Barboza @ 2017-11-01 19:32 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, mdroth
The commit title/subject is misleading. I'll resend with a better commit
title.
On 11/01/2017 05:21 PM, Daniel Henrique Barboza wrote:
> When executing 'configure' in a fresh QEMU clone, in a fresh
> OS install running in a ppc64le host, this is the error
> shown:
>
> -----
>
> ../configure --enable-trace-backend=simple --enable-debug
> --target-list=ppc64-softmmu
>
> ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter
>
> -----
>
> This isn't true, ppc64le host CPU is supported. This happens because,
> in a fresh install, we don't have a C compiler to autodetect
> the $cpu variable to "ppc64".
>
> Since we need a C compiler to properly get the value of $cpu
> in this and other cases, this patch changes the location of the C
> compiler check right after setting the preferred CC.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
> ---
> configure | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/configure b/configure
> index 285d123dbf..a641bf18b6 100755
> --- a/configure
> +++ b/configure
> @@ -467,6 +467,23 @@ else
> cc="${CC-${cross_prefix}gcc}"
> fi
>
> +write_c_skeleton() {
> + cat > $TMPC <<EOF
> +int main(void) { return 0; }
> +EOF
> +}
> +
> +# check that the C compiler works.
> +write_c_skeleton;
> +if compile_object ; then
> + : C compiler works ok
> +else
> + error_exit "\"$cc\" either does not exist or does not work"
> +fi
> +if ! compile_prog ; then
> + error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
> +fi
> +
> if test -z "${CXX}${cross_prefix}"; then
> cxx="c++"
> else
> @@ -537,12 +554,6 @@ EOF
> compile_object
> }
>
> -write_c_skeleton() {
> - cat > $TMPC <<EOF
> -int main(void) { return 0; }
> -EOF
> -}
> -
> if check_define __linux__ ; then
> targetos="Linux"
> elif check_define _WIN32 ; then
> @@ -1593,17 +1604,6 @@ if test -z "$werror" ; then
> fi
> fi
>
> -# check that the C compiler works.
> -write_c_skeleton;
> -if compile_object ; then
> - : C compiler works ok
> -else
> - error_exit "\"$cc\" either does not exist or does not work"
> -fi
> -if ! compile_prog ; then
> - error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
> -fi
> -
> if test "$bogus_os" = "yes"; then
> # Now that we know that we're not printing the help and that
> # the compiler works (so the results of the check_defines we used
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs
2017-11-01 19:21 [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs Daniel Henrique Barboza
2017-11-01 19:32 ` Daniel Henrique Barboza
@ 2017-11-01 19:34 ` Philippe Mathieu-Daudé
2017-11-01 19:39 ` Daniel Henrique Barboza
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-11-01 19:34 UTC (permalink / raw)
To: Daniel Henrique Barboza, qemu-devel; +Cc: peter.maydell, mdroth
Hi Daniel,
On 11/01/2017 04:21 PM, Daniel Henrique Barboza wrote:
> When executing 'configure' in a fresh QEMU clone, in a fresh
> OS install running in a ppc64le host, this is the error
> shown:
>
> -----
>
> ../configure --enable-trace-backend=simple --enable-debug
> --target-list=ppc64-softmmu
>
> ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter
>
> -----
>
> This isn't true, ppc64le host CPU is supported. This happens because,
> in a fresh install, we don't have a C compiler to autodetect
> the $cpu variable to "ppc64".
>
> Since we need a C compiler to properly get the value of $cpu
> in this and other cases, this patch changes the location of the C
> compiler check right after setting the preferred CC.
Can you add the output of the new behavior?
Also please update the subject, then:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
> ---
> configure | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/configure b/configure
> index 285d123dbf..a641bf18b6 100755
> --- a/configure
> +++ b/configure
> @@ -467,6 +467,23 @@ else
> cc="${CC-${cross_prefix}gcc}"
> fi
>
> +write_c_skeleton() {
> + cat > $TMPC <<EOF
> +int main(void) { return 0; }
> +EOF
> +}
> +
> +# check that the C compiler works.
> +write_c_skeleton;
> +if compile_object ; then
> + : C compiler works ok
> +else
> + error_exit "\"$cc\" either does not exist or does not work"
> +fi
> +if ! compile_prog ; then
> + error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
> +fi
> +
> if test -z "${CXX}${cross_prefix}"; then
> cxx="c++"
> else
> @@ -537,12 +554,6 @@ EOF
> compile_object
> }
>
> -write_c_skeleton() {
> - cat > $TMPC <<EOF
> -int main(void) { return 0; }
> -EOF
> -}
> -
> if check_define __linux__ ; then
> targetos="Linux"
> elif check_define _WIN32 ; then
> @@ -1593,17 +1604,6 @@ if test -z "$werror" ; then
> fi
> fi
>
> -# check that the C compiler works.
> -write_c_skeleton;
> -if compile_object ; then
> - : C compiler works ok
> -else
> - error_exit "\"$cc\" either does not exist or does not work"
> -fi
> -if ! compile_prog ; then
> - error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
> -fi
> -
> if test "$bogus_os" = "yes"; then
> # Now that we know that we're not printing the help and that
> # the compiler works (so the results of the check_defines we used
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs
2017-11-01 19:34 ` Philippe Mathieu-Daudé
@ 2017-11-01 19:39 ` Daniel Henrique Barboza
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Henrique Barboza @ 2017-11-01 19:39 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: peter.maydell, mdroth
On 11/01/2017 05:34 PM, Philippe Mathieu-Daudé wrote:
> Hi Daniel,
>
> On 11/01/2017 04:21 PM, Daniel Henrique Barboza wrote:
>> When executing 'configure' in a fresh QEMU clone, in a fresh
>> OS install running in a ppc64le host, this is the error
>> shown:
>>
>> -----
>>
>> ../configure --enable-trace-backend=simple --enable-debug
>> --target-list=ppc64-softmmu
>>
>> ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter
>>
>> -----
>>
>> This isn't true, ppc64le host CPU is supported. This happens because,
>> in a fresh install, we don't have a C compiler to autodetect
>> the $cpu variable to "ppc64".
>>
>> Since we need a C compiler to properly get the value of $cpu
>> in this and other cases, this patch changes the location of the C
>> compiler check right after setting the preferred CC.
> Can you add the output of the new behavior?
>
> Also please update the subject, then:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Hey!
I've updated the subject in the v4 already.
The output didn't change: in my test scenario (fresh OS with no
CC installed in a ppc64le host), if I try to run configure I get:
../configure --enable-trace-backend=simple --enable-debug
--target-list=ppc64-softmmu
ERROR: "cc" either does not exist or does not work
Instead of an error message saying that ppc64le isn't supported.
Daniel
>
>> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
>> ---
>> configure | 34 +++++++++++++++++-----------------
>> 1 file changed, 17 insertions(+), 17 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 285d123dbf..a641bf18b6 100755
>> --- a/configure
>> +++ b/configure
>> @@ -467,6 +467,23 @@ else
>> cc="${CC-${cross_prefix}gcc}"
>> fi
>>
>> +write_c_skeleton() {
>> + cat > $TMPC <<EOF
>> +int main(void) { return 0; }
>> +EOF
>> +}
>> +
>> +# check that the C compiler works.
>> +write_c_skeleton;
>> +if compile_object ; then
>> + : C compiler works ok
>> +else
>> + error_exit "\"$cc\" either does not exist or does not work"
>> +fi
>> +if ! compile_prog ; then
>> + error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
>> +fi
>> +
>> if test -z "${CXX}${cross_prefix}"; then
>> cxx="c++"
>> else
>> @@ -537,12 +554,6 @@ EOF
>> compile_object
>> }
>>
>> -write_c_skeleton() {
>> - cat > $TMPC <<EOF
>> -int main(void) { return 0; }
>> -EOF
>> -}
>> -
>> if check_define __linux__ ; then
>> targetos="Linux"
>> elif check_define _WIN32 ; then
>> @@ -1593,17 +1604,6 @@ if test -z "$werror" ; then
>> fi
>> fi
>>
>> -# check that the C compiler works.
>> -write_c_skeleton;
>> -if compile_object ; then
>> - : C compiler works ok
>> -else
>> - error_exit "\"$cc\" either does not exist or does not work"
>> -fi
>> -if ! compile_prog ; then
>> - error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
>> -fi
>> -
>> if test "$bogus_os" = "yes"; then
>> # Now that we know that we're not printing the help and that
>> # the compiler works (so the results of the check_defines we used
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-01 19:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-01 19:21 [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs Daniel Henrique Barboza
2017-11-01 19:32 ` Daniel Henrique Barboza
2017-11-01 19:34 ` Philippe Mathieu-Daudé
2017-11-01 19:39 ` Daniel Henrique Barboza
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.