From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> To: Matthew Brost <matthew.brost@intel.com> Cc: <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>, <daniel.vetter@ffwll.ch> Subject: Re: [PATCH 13/27] drm/i915/guc: Take context ref when cancelling request Date: Tue, 24 Aug 2021 18:21:54 -0700 [thread overview] Message-ID: <deada6f9-ba3c-e976-3d22-1a1ff7d59e24@intel.com> (raw) In-Reply-To: <20210824154241.GA9672@jons-linux-dev-box> On 8/24/2021 8:42 AM, Matthew Brost wrote: > On Fri, Aug 20, 2021 at 05:07:27PM -0700, Daniele Ceraolo Spurio wrote: >> >> On 8/18/2021 11:16 PM, Matthew Brost wrote: >>> A context can get destroyed after cancelling a request so take a >>> reference to context when cancelling a request. >> What's the exact race? AFAICS __i915_request_skip does not have a >> context_put(). > This commit message isn't quite right, it is really a context reset or a > GT reset which could result in the context getting destroyed. I haven't > actually seen this happen but this just being paranoid about ref > counting. Can fix up the commit message. ok, with an updated commit message: Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Daniele > > Matt > >> Daniele >> >>> Fixes: 62eaf0ae217d ("drm/i915/guc: Support request cancellation") >>> Signed-off-by: Matthew Brost <matthew.brost@intel.com> >>> --- >>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> index e0e85e4ad512..85f96d325048 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> @@ -1620,8 +1620,10 @@ static void guc_context_cancel_request(struct intel_context *ce, >>> struct i915_request *rq) >>> { >>> if (i915_sw_fence_signaled(&rq->submit)) { >>> - struct i915_sw_fence *fence = guc_context_block(ce); >>> + struct i915_sw_fence *fence; >>> + intel_context_get(ce); >>> + fence = guc_context_block(ce); >>> i915_sw_fence_wait(fence); >>> if (!i915_request_completed(rq)) { >>> __i915_request_skip(rq); >>> @@ -1636,6 +1638,7 @@ static void guc_context_cancel_request(struct intel_context *ce, >>> flush_work(&ce_to_guc(ce)->ct.requests.worker); >>> guc_context_unblock(ce); >>> + intel_context_put(ce); >>> } >>> }
WARNING: multiple messages have this Message-ID (diff)
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> To: Matthew Brost <matthew.brost@intel.com> Cc: <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>, <daniel.vetter@ffwll.ch> Subject: Re: [Intel-gfx] [PATCH 13/27] drm/i915/guc: Take context ref when cancelling request Date: Tue, 24 Aug 2021 18:21:54 -0700 [thread overview] Message-ID: <deada6f9-ba3c-e976-3d22-1a1ff7d59e24@intel.com> (raw) In-Reply-To: <20210824154241.GA9672@jons-linux-dev-box> On 8/24/2021 8:42 AM, Matthew Brost wrote: > On Fri, Aug 20, 2021 at 05:07:27PM -0700, Daniele Ceraolo Spurio wrote: >> >> On 8/18/2021 11:16 PM, Matthew Brost wrote: >>> A context can get destroyed after cancelling a request so take a >>> reference to context when cancelling a request. >> What's the exact race? AFAICS __i915_request_skip does not have a >> context_put(). > This commit message isn't quite right, it is really a context reset or a > GT reset which could result in the context getting destroyed. I haven't > actually seen this happen but this just being paranoid about ref > counting. Can fix up the commit message. ok, with an updated commit message: Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Daniele > > Matt > >> Daniele >> >>> Fixes: 62eaf0ae217d ("drm/i915/guc: Support request cancellation") >>> Signed-off-by: Matthew Brost <matthew.brost@intel.com> >>> --- >>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> index e0e85e4ad512..85f96d325048 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> @@ -1620,8 +1620,10 @@ static void guc_context_cancel_request(struct intel_context *ce, >>> struct i915_request *rq) >>> { >>> if (i915_sw_fence_signaled(&rq->submit)) { >>> - struct i915_sw_fence *fence = guc_context_block(ce); >>> + struct i915_sw_fence *fence; >>> + intel_context_get(ce); >>> + fence = guc_context_block(ce); >>> i915_sw_fence_wait(fence); >>> if (!i915_request_completed(rq)) { >>> __i915_request_skip(rq); >>> @@ -1636,6 +1638,7 @@ static void guc_context_cancel_request(struct intel_context *ce, >>> flush_work(&ce_to_guc(ce)->ct.requests.worker); >>> guc_context_unblock(ce); >>> + intel_context_put(ce); >>> } >>> }
next prev parent reply other threads:[~2021-08-25 1:22 UTC|newest] Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-19 6:16 [PATCH 00/27] Clean up GuC CI failures, simplify locking, and kernel DOC Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-19 6:16 ` [PATCH 01/27] drm/i915/guc: Fix blocked context accounting Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-24 23:24 ` Daniele Ceraolo Spurio 2021-08-24 23:24 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 02/27] drm/i915/guc: Fix outstanding G2H accounting Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-19 21:31 ` Daniele Ceraolo Spurio 2021-08-19 21:30 ` Matthew Brost 2021-08-19 6:16 ` [PATCH 03/27] drm/i915/guc: Unwind context requests in reverse order Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-19 23:54 ` Daniele Ceraolo Spurio 2021-08-19 23:53 ` Matthew Brost 2021-08-20 0:03 ` Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 04/27] drm/i915/guc: Don't drop ce->guc_active.lock when unwinding context Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-20 0:01 ` Daniele Ceraolo Spurio 2021-08-19 23:58 ` Matthew Brost 2021-08-19 6:16 ` [PATCH 05/27] drm/i915/guc: Process all G2H message at once in work queue Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-20 0:06 ` Daniele Ceraolo Spurio 2021-08-20 0:06 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 06/27] drm/i915/guc: Workaround reset G2H is received after schedule done G2H Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-24 23:31 ` Daniele Ceraolo Spurio 2021-08-25 4:05 ` Matthew Brost 2021-08-19 6:16 ` [PATCH 07/27] Revert "drm/i915/gt: Propagate change in error status to children on unhold" Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-20 19:47 ` Jason Ekstrand 2021-08-20 19:47 ` [Intel-gfx] " Jason Ekstrand 2021-08-19 6:16 ` [PATCH 08/27] drm/i915/selftests: Add a cancel request selftest that triggers a reset Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-19 6:16 ` [PATCH 09/27] drm/i915/guc: Kick tasklet after queuing a request Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-20 18:31 ` Daniele Ceraolo Spurio 2021-08-20 18:36 ` Matthew Brost 2021-08-19 6:16 ` [PATCH 10/27] drm/i915/guc: Don't enable scheduling on a banned context, guc_id invalid, not registered Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-20 18:42 ` Daniele Ceraolo Spurio 2021-08-20 18:42 ` Matthew Brost 2021-08-19 6:16 ` [PATCH 11/27] drm/i915/selftests: Fix memory corruption in live_lrc_isolation Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-25 0:07 ` Daniele Ceraolo Spurio 2021-08-25 20:03 ` Matthew Brost 2021-08-19 6:16 ` [PATCH 12/27] drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-25 0:58 ` Daniele Ceraolo Spurio 2021-08-25 0:58 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 13/27] drm/i915/guc: Take context ref when cancelling request Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-21 0:07 ` Daniele Ceraolo Spurio 2021-08-21 0:07 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-24 15:42 ` Matthew Brost 2021-08-24 15:42 ` [Intel-gfx] " Matthew Brost 2021-08-25 1:21 ` Daniele Ceraolo Spurio [this message] 2021-08-25 1:21 ` Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 14/27] drm/i915/guc: Don't touch guc_state.sched_state without a lock Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-25 1:20 ` Daniele Ceraolo Spurio 2021-08-25 1:44 ` Matthew Brost 2021-08-25 1:51 ` Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 15/27] drm/i915/guc: Reset LRC descriptor if register returns -ENODEV Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-21 0:14 ` Daniele Ceraolo Spurio 2021-08-21 0:14 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 16/27] drm/i915: Allocate error capture in nowait context Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-19 6:16 ` [PATCH 17/27] drm/i915/guc: Flush G2H work queue during reset Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-21 0:25 ` Daniele Ceraolo Spurio 2021-08-21 0:25 ` Daniele Ceraolo Spurio 2021-08-24 15:44 ` Matthew Brost 2021-08-24 15:44 ` [Intel-gfx] " Matthew Brost 2021-08-25 1:22 ` Daniele Ceraolo Spurio 2021-08-25 1:22 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 18/27] drm/i915/guc: Release submit fence from an irq_work Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-25 1:44 ` Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 19/27] drm/i915/guc: Move guc_blocked fence to struct guc_state Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-21 0:30 ` Daniele Ceraolo Spurio 2021-08-21 0:30 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 20/27] drm/i915/guc: Rework and simplify locking Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-25 16:52 ` Daniele Ceraolo Spurio 2021-08-25 19:22 ` Matthew Brost 2021-08-19 6:16 ` [PATCH 21/27] drm/i915/guc: Proper xarray usage for contexts_lookup Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-26 0:44 ` Daniele Ceraolo Spurio 2021-08-26 0:41 ` Matthew Brost 2021-08-26 0:48 ` Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 22/27] drm/i915/guc: Drop pin count check trick between sched_disable and re-pin Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-26 0:50 ` Daniele Ceraolo Spurio 2021-08-26 0:50 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 23/27] drm/i915/guc: Move GuC priority fields in context under guc_active Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-25 21:51 ` Daniele Ceraolo Spurio 2021-08-25 22:53 ` Matthew Brost 2021-08-25 23:04 ` Matthew Brost 2021-08-19 6:16 ` [PATCH 24/27] drm/i915/guc: Move fields protected by guc->contexts_lock into sub structure Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-25 2:00 ` Daniele Ceraolo Spurio 2021-08-25 2:00 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 25/27] drm/i915/guc: Drop guc_active move everything into guc_state Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-26 0:54 ` Daniele Ceraolo Spurio 2021-08-26 0:54 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 26/27] drm/i915/guc: Add GuC kernel doc Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-26 1:03 ` Daniele Ceraolo Spurio 2021-08-19 6:16 ` [PATCH 27/27] drm/i915/guc: Drop static inline functions intel_guc_submission.c Matthew Brost 2021-08-19 6:16 ` [Intel-gfx] " Matthew Brost 2021-08-19 7:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clean up GuC CI failures, simplify locking, and kernel DOC (rev3) Patchwork 2021-08-19 7:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-08-19 7:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-08-19 9:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-08-26 3:23 [PATCH 00/27] Clean up GuC CI failures, simplify locking, and kernel DOC Matthew Brost 2021-08-26 3:23 ` [PATCH 13/27] drm/i915/guc: Take context ref when cancelling request Matthew Brost
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=deada6f9-ba3c-e976-3d22-1a1ff7d59e24@intel.com \ --to=daniele.ceraolospurio@intel.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=matthew.brost@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.