From: Haren Myneni <haren@linux.ibm.com> To: Nicholas Piggin <npiggin@gmail.com>, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Cc: haren@us.ibm.com, hbabu@us.ibm.com Subject: Re: [V3 PATCH 15/16] crypto/nx: Get NX capabilities for GZIP coprocessor type Date: Mon, 10 May 2021 13:44:43 -0700 [thread overview] Message-ID: <deca09ae6704e3a9bf9dabb2b9e3ffff1ab00843.camel@linux.ibm.com> (raw) In-Reply-To: <1620628516.4xglqwl3t1.astroid@bobo.none> On Mon, 2021-05-10 at 16:38 +1000, Nicholas Piggin wrote: > Excerpts from Haren Myneni's message of April 18, 2021 7:12 am: > > phyp provides NX capabilities which gives recommended minimum > > compression / decompression length and maximum request buffer size > > in bytes. > > > > Changes to get NX overall capabilities which points to the specific > > features phyp supports. Then retrieve NXGZIP specific capabilities. > > > > Signed-off-by: Haren Myneni <haren@linux.ibm.com> > > --- > > drivers/crypto/nx/nx-common-pseries.c | 83 > > +++++++++++++++++++++++++++ > > 1 file changed, 83 insertions(+) > > > > diff --git a/drivers/crypto/nx/nx-common-pseries.c > > b/drivers/crypto/nx/nx-common-pseries.c > > index 9a40fca8a9e6..49224870d05e 100644 > > --- a/drivers/crypto/nx/nx-common-pseries.c > > +++ b/drivers/crypto/nx/nx-common-pseries.c > > @@ -9,6 +9,7 @@ > > */ > > > > #include <asm/vio.h> > > +#include <asm/hvcall.h> > > #include <asm/vas.h> > > > > #include "nx-842.h" > > @@ -20,6 +21,24 @@ MODULE_DESCRIPTION("842 H/W Compression driver > > for IBM Power processors"); > > MODULE_ALIAS_CRYPTO("842"); > > MODULE_ALIAS_CRYPTO("842-nx"); > > > > +struct nx_ct_capabs_be { > > What does "ct" mean? I've seen it in a few other places too. ct means coprocessor type such as 842 and GZIP. phyp provides only GZIP capabilities right now. But this struct may be extended to other types in future. > > > + __be64 descriptor; > > + __be64 req_max_processed_len; /* Max bytes in one GZIP > > request */ > > + __be64 min_compress_len; /* Min compression size in > > bytes */ > > + __be64 min_decompress_len; /* Min decompression size > > in bytes */ > > +} __packed __aligned(0x1000); > > + > > +struct nx_ct_capabs { > > + char name[VAS_DESCR_LEN + 1]; > > + u64 descriptor; > > + u64 req_max_processed_len; /* Max bytes in one GZIP request */ > > + u64 min_compress_len; /* Min compression in bytes */ > > + u64 min_decompress_len; /* Min decompression in bytes */ > > +}; > > + > > +u64 capab_feat = 0; > > Why is this here and not a local variable? capab_feat is used to add / delete sysfs entries. > > > +struct nx_ct_capabs nx_ct_capab; > > It's okay and generally better to use the same name as the struct > name > in this situation, i.e., > > "struct nx_ct_capabs nx_ct_capabs" > > (modulo static / caps / etc) Sure, will change. > > Thanks, > Nick
WARNING: multiple messages have this Message-ID (diff)
From: Haren Myneni <haren@linux.ibm.com> To: Nicholas Piggin <npiggin@gmail.com>, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Subject: Re: [V3 PATCH 15/16] crypto/nx: Get NX capabilities for GZIP coprocessor type Date: Mon, 10 May 2021 13:44:43 -0700 [thread overview] Message-ID: <deca09ae6704e3a9bf9dabb2b9e3ffff1ab00843.camel@linux.ibm.com> (raw) In-Reply-To: <1620628516.4xglqwl3t1.astroid@bobo.none> On Mon, 2021-05-10 at 16:38 +1000, Nicholas Piggin wrote: > Excerpts from Haren Myneni's message of April 18, 2021 7:12 am: > > phyp provides NX capabilities which gives recommended minimum > > compression / decompression length and maximum request buffer size > > in bytes. > > > > Changes to get NX overall capabilities which points to the specific > > features phyp supports. Then retrieve NXGZIP specific capabilities. > > > > Signed-off-by: Haren Myneni <haren@linux.ibm.com> > > --- > > drivers/crypto/nx/nx-common-pseries.c | 83 > > +++++++++++++++++++++++++++ > > 1 file changed, 83 insertions(+) > > > > diff --git a/drivers/crypto/nx/nx-common-pseries.c > > b/drivers/crypto/nx/nx-common-pseries.c > > index 9a40fca8a9e6..49224870d05e 100644 > > --- a/drivers/crypto/nx/nx-common-pseries.c > > +++ b/drivers/crypto/nx/nx-common-pseries.c > > @@ -9,6 +9,7 @@ > > */ > > > > #include <asm/vio.h> > > +#include <asm/hvcall.h> > > #include <asm/vas.h> > > > > #include "nx-842.h" > > @@ -20,6 +21,24 @@ MODULE_DESCRIPTION("842 H/W Compression driver > > for IBM Power processors"); > > MODULE_ALIAS_CRYPTO("842"); > > MODULE_ALIAS_CRYPTO("842-nx"); > > > > +struct nx_ct_capabs_be { > > What does "ct" mean? I've seen it in a few other places too. ct means coprocessor type such as 842 and GZIP. phyp provides only GZIP capabilities right now. But this struct may be extended to other types in future. > > > + __be64 descriptor; > > + __be64 req_max_processed_len; /* Max bytes in one GZIP > > request */ > > + __be64 min_compress_len; /* Min compression size in > > bytes */ > > + __be64 min_decompress_len; /* Min decompression size > > in bytes */ > > +} __packed __aligned(0x1000); > > + > > +struct nx_ct_capabs { > > + char name[VAS_DESCR_LEN + 1]; > > + u64 descriptor; > > + u64 req_max_processed_len; /* Max bytes in one GZIP request */ > > + u64 min_compress_len; /* Min compression in bytes */ > > + u64 min_decompress_len; /* Min decompression in bytes */ > > +}; > > + > > +u64 capab_feat = 0; > > Why is this here and not a local variable? capab_feat is used to add / delete sysfs entries. > > > +struct nx_ct_capabs nx_ct_capab; > > It's okay and generally better to use the same name as the struct > name > in this situation, i.e., > > "struct nx_ct_capabs nx_ct_capabs" > > (modulo static / caps / etc) Sure, will change. > > Thanks, > Nick
next prev parent reply other threads:[~2021-05-10 20:45 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-17 20:52 [V3 PATCH 00/16] Enable VAS and NX-GZIP support on powerVM Haren Myneni 2021-04-17 20:52 ` Haren Myneni 2021-04-17 21:00 ` [V3 PATCH 01/16] powerpc/powernv/vas: Rename register/unregister functions Haren Myneni 2021-04-17 21:00 ` Haren Myneni 2021-05-10 5:10 ` Nicholas Piggin 2021-05-10 5:10 ` Nicholas Piggin 2021-05-10 16:59 ` Haren Myneni 2021-05-10 16:59 ` Haren Myneni 2021-04-17 21:02 ` [PATCH V3 02/16] powerpc/vas: Move VAS API to common book3s platform Haren Myneni 2021-04-17 21:02 ` Haren Myneni 2021-05-10 5:19 ` Nicholas Piggin 2021-05-10 5:19 ` Nicholas Piggin 2021-05-10 17:12 ` Haren Myneni 2021-05-10 17:12 ` Haren Myneni 2021-05-11 1:50 ` Michael Ellerman 2021-05-11 1:50 ` Michael Ellerman 2021-04-17 21:03 ` [V3 PATCH 03/16] powerpc/vas: Create take/drop task reference functions Haren Myneni 2021-04-17 21:03 ` Haren Myneni 2021-05-10 5:28 ` Nicholas Piggin 2021-05-10 5:28 ` Nicholas Piggin 2021-05-10 20:32 ` Haren Myneni 2021-05-10 20:32 ` Haren Myneni 2021-04-17 21:03 ` [V3 PATCH 04/16] powerpc/vas: Move update_csb/dump_crb to common book3s platform Haren Myneni 2021-04-17 21:03 ` Haren Myneni 2021-05-10 5:37 ` Nicholas Piggin 2021-05-10 5:37 ` Nicholas Piggin 2021-04-17 21:04 ` [V3 PATCH 05/16] powerpc/vas: Define and use common vas_window struct Haren Myneni 2021-04-17 21:04 ` Haren Myneni 2021-05-10 5:37 ` Nicholas Piggin 2021-05-10 5:37 ` Nicholas Piggin 2021-05-10 17:02 ` Haren Myneni 2021-05-10 17:02 ` Haren Myneni 2021-04-17 21:05 ` [V3 PATCH 06/16] powerpc/pseries/vas: Define VAS/NXGZIP HCALLs and structs Haren Myneni 2021-04-17 21:05 ` Haren Myneni 2021-05-10 5:49 ` Nicholas Piggin 2021-05-10 5:49 ` Nicholas Piggin 2021-05-11 2:18 ` Haren Myneni 2021-05-11 2:18 ` Haren Myneni 2021-04-17 21:06 ` [V3 PATCH 07/16] powerpc/vas: Define QoS credit flag to allocate window Haren Myneni 2021-04-17 21:06 ` Haren Myneni 2021-05-10 5:54 ` Nicholas Piggin 2021-05-10 5:54 ` Nicholas Piggin 2021-05-11 2:12 ` Haren Myneni 2021-05-11 2:12 ` Haren Myneni 2021-04-17 21:07 ` [V3 PATCH 08/16] powerpc/pseries/VAS: Implement allocate/modify/deallocate HCALLS Haren Myneni 2021-04-17 21:07 ` Haren Myneni 2021-05-10 6:01 ` Nicholas Piggin 2021-05-10 6:01 ` Nicholas Piggin 2021-04-17 21:08 ` [V3 PATCH 09/16] powerpc/pseries/vas: Implement to get all capabilities Haren Myneni 2021-04-17 21:08 ` Haren Myneni 2021-05-10 6:13 ` Nicholas Piggin 2021-05-10 6:13 ` Nicholas Piggin 2021-05-11 2:08 ` Haren Myneni 2021-05-11 2:08 ` Haren Myneni 2021-04-17 21:08 ` [V3 PATCH 10/16] powerpc/pseries/vas: Integrate API with open/close windows Haren Myneni 2021-04-17 21:08 ` Haren Myneni 2021-05-10 6:18 ` Nicholas Piggin 2021-05-10 6:18 ` Nicholas Piggin 2021-05-10 6:28 ` Nicholas Piggin 2021-05-10 6:28 ` Nicholas Piggin 2021-04-17 21:09 ` [V3 PATCH 11/16] powerpc/pseries/vas: Setup IRQ and fault handling Haren Myneni 2021-04-17 21:09 ` Haren Myneni 2021-04-17 21:10 ` [V3 PATCH 12/16] powerpc/pseries/vas: sysfs interface to export capabilities Haren Myneni 2021-04-17 21:10 ` Haren Myneni 2021-05-10 6:34 ` Nicholas Piggin 2021-05-10 6:34 ` Nicholas Piggin 2021-05-10 20:52 ` Haren Myneni 2021-05-10 20:52 ` Haren Myneni 2021-04-17 21:11 ` [V3 PATCH 13/16] crypto/nx: Rename nx-842-pseries file name to nx-common-pseries Haren Myneni 2021-04-17 21:11 ` Haren Myneni 2021-04-22 6:55 ` Herbert Xu 2021-04-22 6:55 ` Herbert Xu 2021-04-17 21:12 ` [V3 PATCH 14/16] crypto/nx: Register and unregister VAS interface Haren Myneni 2021-04-17 21:12 ` Haren Myneni 2021-04-22 6:56 ` Herbert Xu 2021-04-22 6:56 ` Herbert Xu 2021-04-17 21:12 ` [V3 PATCH 15/16] crypto/nx: Get NX capabilities for GZIP coprocessor type Haren Myneni 2021-04-17 21:12 ` Haren Myneni 2021-04-22 6:56 ` Herbert Xu 2021-04-22 6:56 ` Herbert Xu 2021-05-10 6:38 ` Nicholas Piggin 2021-05-10 6:38 ` Nicholas Piggin 2021-05-10 20:44 ` Haren Myneni [this message] 2021-05-10 20:44 ` Haren Myneni 2021-04-17 21:13 ` [V3 PATCH 16/16] crypto/nx: Add sysfs interface to export NX capabilities Haren Myneni 2021-04-17 21:13 ` Haren Myneni 2021-04-22 6:56 ` Herbert Xu 2021-04-22 6:56 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=deca09ae6704e3a9bf9dabb2b9e3ffff1ab00843.camel@linux.ibm.com \ --to=haren@linux.ibm.com \ --cc=haren@us.ibm.com \ --cc=hbabu@us.ibm.com \ --cc=herbert@gondor.apana.org.au \ --cc=linux-crypto@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=npiggin@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.