* [PATCH 03/10] atmel: hide unused procfs helpers
@ 2018-07-13 6:46 YueHaibing
2018-07-13 9:31 ` YueHaibing
2018-07-31 7:21 ` Kalle Valo
0 siblings, 2 replies; 7+ messages in thread
From: YueHaibing @ 2018-07-13 6:46 UTC (permalink / raw)
To: simon, kvalo; +Cc: linux-kernel, netdev, linux-wireless, davem, YueHaibing
When CONFIG_PROC_FS isn't set, gcc warning this:
drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
static int atmel_proc_show(struct seq_file *m, void *v)
^
fix this by adding #ifdef around it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/atmel/atmel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c
index b01dc34..3940876 100644
--- a/drivers/net/wireless/atmel/atmel.c
+++ b/drivers/net/wireless/atmel/atmel.c
@@ -1399,6 +1399,7 @@ static int atmel_validate_channel(struct atmel_private *priv, int channel)
return 0;
}
+#ifdef CONFIG_PROC_FS
static int atmel_proc_show(struct seq_file *m, void *v)
{
struct atmel_private *priv = m->private;
@@ -1481,6 +1482,7 @@ static int atmel_proc_show(struct seq_file *m, void *v)
seq_printf(m, "Current state:\t\t%s\n", s);
return 0;
}
+#endif
static const struct net_device_ops atmel_netdev_ops = {
.ndo_open = atmel_open,
--
2.7.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 03/10] atmel: hide unused procfs helpers
2018-07-13 6:46 [PATCH 03/10] atmel: hide unused procfs helpers YueHaibing
@ 2018-07-13 9:31 ` YueHaibing
2018-07-27 9:24 ` Kalle Valo
2018-07-31 7:21 ` Kalle Valo
1 sibling, 1 reply; 7+ messages in thread
From: YueHaibing @ 2018-07-13 9:31 UTC (permalink / raw)
To: simon, kvalo; +Cc: linux-kernel, netdev, linux-wireless, davem
pls ignore this,my bad.
On 2018/7/13 14:46, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
> static int atmel_proc_show(struct seq_file *m, void *v)
> ^
> fix this by adding #ifdef around it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/atmel/atmel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c
> index b01dc34..3940876 100644
> --- a/drivers/net/wireless/atmel/atmel.c
> +++ b/drivers/net/wireless/atmel/atmel.c
> @@ -1399,6 +1399,7 @@ static int atmel_validate_channel(struct atmel_private *priv, int channel)
> return 0;
> }
>
> +#ifdef CONFIG_PROC_FS
> static int atmel_proc_show(struct seq_file *m, void *v)
> {
> struct atmel_private *priv = m->private;
> @@ -1481,6 +1482,7 @@ static int atmel_proc_show(struct seq_file *m, void *v)
> seq_printf(m, "Current state:\t\t%s\n", s);
> return 0;
> }
> +#endif
>
> static const struct net_device_ops atmel_netdev_ops = {
> .ndo_open = atmel_open,
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 03/10] atmel: hide unused procfs helpers
2018-07-13 9:31 ` YueHaibing
@ 2018-07-27 9:24 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2018-07-27 9:24 UTC (permalink / raw)
To: YueHaibing; +Cc: simon, linux-kernel, netdev, linux-wireless, davem, rdunlap
(fixing top posting)
YueHaibing <yuehaibing@huawei.com> writes:
> On 2018/7/13 14:46, YueHaibing wrote:
>> When CONFIG_PROC_FS isn't set, gcc warning this:
>>=20
>> drivers/net/wireless/atmel/atmel.c:1402:12: warning: =E2=80=98atmel_proc=
_show=E2=80=99 defined but not used [-Wunused-function]
>> static int atmel_proc_show(struct seq_file *m, void *v)
>> ^
>> fix this by adding #ifdef around it.
>>=20
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> pls ignore this,my bad.
Why should I drop this? Does the patch have something wrong which I'm
missing?
I'm asking because I prefer this over Randy's version:
https://patchwork.kernel.org/patch/10512913/
--=20
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 03/10] atmel: hide unused procfs helpers
@ 2018-07-27 9:24 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2018-07-27 9:24 UTC (permalink / raw)
To: YueHaibing; +Cc: simon, linux-kernel, netdev, linux-wireless, davem, rdunlap
(fixing top posting)
YueHaibing <yuehaibing@huawei.com> writes:
> On 2018/7/13 14:46, YueHaibing wrote:
>> When CONFIG_PROC_FS isn't set, gcc warning this:
>>
>> drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
>> static int atmel_proc_show(struct seq_file *m, void *v)
>> ^
>> fix this by adding #ifdef around it.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> pls ignore this,my bad.
Why should I drop this? Does the patch have something wrong which I'm
missing?
I'm asking because I prefer this over Randy's version:
https://patchwork.kernel.org/patch/10512913/
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 03/10] atmel: hide unused procfs helpers
2018-07-27 9:24 ` Kalle Valo
(?)
@ 2018-07-27 10:02 ` YueHaibing
-1 siblings, 0 replies; 7+ messages in thread
From: YueHaibing @ 2018-07-27 10:02 UTC (permalink / raw)
To: Kalle Valo; +Cc: simon, linux-kernel, netdev, linux-wireless, davem, rdunlap
On 2018/7/27 17:24, Kalle Valo wrote:
> (fixing top posting)
>
> YueHaibing <yuehaibing@huawei.com> writes:
>
>> On 2018/7/13 14:46, YueHaibing wrote:
>>> When CONFIG_PROC_FS isn't set, gcc warning this:
>>>
>>> drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
>>> static int atmel_proc_show(struct seq_file *m, void *v)
>>> ^
>>> fix this by adding #ifdef around it.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> pls ignore this,my bad.
>
> Why should I drop this? Does the patch have something wrong which I'm
> missing?
No,the patch is ok,just because I find this issue has a fix patch from Randy.
>
> I'm asking because I prefer this over Randy's version:
>
> https://patchwork.kernel.org/patch/10512913/
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 03/10] atmel: hide unused procfs helpers
2018-07-27 9:24 ` Kalle Valo
(?)
(?)
@ 2018-07-27 15:44 ` Randy Dunlap
-1 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2018-07-27 15:44 UTC (permalink / raw)
To: Kalle Valo, YueHaibing; +Cc: simon, linux-kernel, netdev, linux-wireless, davem
On 07/27/2018 02:24 AM, Kalle Valo wrote:
> (fixing top posting)
>
> YueHaibing <yuehaibing@huawei.com> writes:
>
>> On 2018/7/13 14:46, YueHaibing wrote:
>>> When CONFIG_PROC_FS isn't set, gcc warning this:
>>>
>>> drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
>>> static int atmel_proc_show(struct seq_file *m, void *v)
>>> ^
>>> fix this by adding #ifdef around it.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> pls ignore this,my bad.
>
> Why should I drop this? Does the patch have something wrong which I'm
> missing?
>
> I'm asking because I prefer this over Randy's version:
>
> https://patchwork.kernel.org/patch/10512913/
Take it. I don't mind.
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 03/10] atmel: hide unused procfs helpers
2018-07-13 6:46 [PATCH 03/10] atmel: hide unused procfs helpers YueHaibing
2018-07-13 9:31 ` YueHaibing
@ 2018-07-31 7:21 ` Kalle Valo
1 sibling, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2018-07-31 7:21 UTC (permalink / raw)
To: YueHaibing; +Cc: simon, linux-kernel, netdev, linux-wireless, davem, YueHaibing
YueHaibing <yuehaibing@huawei.com> wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
> static int atmel_proc_show(struct seq_file *m, void *v)
> ^
> fix this by adding #ifdef around it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
8b8f3278d241 atmel: hide unused procfs helpers
--
https://patchwork.kernel.org/patch/10522647/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-07-31 9:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 6:46 [PATCH 03/10] atmel: hide unused procfs helpers YueHaibing
2018-07-13 9:31 ` YueHaibing
2018-07-27 9:24 ` Kalle Valo
2018-07-27 9:24 ` Kalle Valo
2018-07-27 10:02 ` YueHaibing
2018-07-27 15:44 ` Randy Dunlap
2018-07-31 7:21 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.