From: Daniel Borkmann <daniel@iogearbox.net>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>
Cc: bpf@vger.kernel.org, Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH bpf] selftests/bpf: fix test_cgroup_storage on s390
Date: Wed, 21 Aug 2019 17:09:40 +0200 [thread overview]
Message-ID: <deeb83e8-d33d-9a97-88a9-304a174a1e37@iogearbox.net> (raw)
In-Reply-To: <20190820141804.88799-1-iii@linux.ibm.com>
On 8/20/19 4:18 PM, Ilya Leoshkevich wrote:
> test_cgroup_storage fails on s390 with an assertion failure: packets are
> dropped when they shouldn't. The problem is that BPF_DW packet count is
> accessed as BPF_W with an offset of 0, which is not correct on
> big-endian machines.
>
> Since the point of this test is not to verify narrow loads/stores,
> simply use BPF_DW when working with packet counts.
>
> Fixes: 68cfa3ac6b8d ("selftests/bpf: add a cgroup storage test")
> Fixes: 919646d2a3a9 ("selftests/bpf: extend the storage test to test per-cpu cgroup storage")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Applied, thanks!
prev parent reply other threads:[~2019-08-21 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 14:18 [PATCH bpf] selftests/bpf: fix test_cgroup_storage on s390 Ilya Leoshkevich
2019-08-21 15:09 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deeb83e8-d33d-9a97-88a9-304a174a1e37@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iii@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.