All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] axel: bump to version 2.14.1
Date: Mon, 25 Sep 2017 21:50:13 +0200	[thread overview]
Message-ID: <deebfc62-f291-0a31-43ff-a6a174e60169@mind.be> (raw)
In-Reply-To: <20170925174107.GC25135@pirotess.bf.iodev.co.uk>



On 25-09-17 19:41, Ismael Luceno wrote:
> On 25/Sep/2017 18:44, Arnout Vandecappelle wrote:
>>
>>
>> On 25-09-17 16:27, Ismael Luceno wrote:
>>> Thanks for the feedback.
>>>
>>> On 24/Sep/2017 16:09, Arnout Vandecappelle wrote:
>>> <...>
>>>> If upstream has a v in their version, you should also have it. So
>>>>
>>>> AXEL_VERSION = v2.14.1
>>>>
>>>> Note that as of today, the github helper no longer requires the third
>>>> argument.
>>>
>>> The "v" is not part of the version number, so I would prefer to leave it
>>> out of AXEL_VERSION...
>>
>>  No, the v *is* part of the version number. If you use the github helper, the
>> _VERSION variable must be identical to the upstream tag.
> 
> Well, that's a matter of interpretation, the project considers it a
> prefix, and Github agrees with common practice and removes the "v"
> prefix when building the archive...
> 
> So if using the github macro, AXEL_VERSION must be a tag or commit id?

 Quoting [1]:

"The FOO_VERSION can either be a tag or a commit ID."


 Regards,
 Arnout


[1] https://buildroot.org/downloads/manual/manual.html#github-download-url


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2017-09-25 19:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22  4:45 [Buildroot] [PATCH] axel: bump to version 2.14.1 Ismael Luceno
2017-09-24 14:09 ` Arnout Vandecappelle
2017-09-25 14:27   ` Ismael Luceno
2017-09-25 16:44     ` Arnout Vandecappelle
2017-09-25 17:41       ` Ismael Luceno
2017-09-25 19:50         ` Arnout Vandecappelle [this message]
2017-09-25 14:36   ` [Buildroot] [PATCH v2] " Ismael Luceno
2017-09-25 15:17     ` Ismael Luceno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=deebfc62-f291-0a31-43ff-a6a174e60169@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.