linux-next: build warning after merge of the gpio-brgl tree

linux-next: build warning after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

Hi Bartosz,

After merging the gpio-brgl tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpio/gpio-davinci.c: In function 'davinci_gpio_get_irq_chip':
drivers/gpio/gpio-davinci.c:472:9: warning: function returns address of local variable [-Wreturn-local-addr]
  return &gpio_unbanked.chip;
         ^~~~~~~~~~~~~~~~~~~
drivers/gpio/gpio-davinci.c: In function 'keystone_gpio_get_irq_chip':
drivers/gpio/gpio-davinci.c:480:9: warning: function returns address of local variable [-Wreturn-local-addr]
  return &gpio_unbanked;
         ^~~~~~~~~~~~~~

Introduced by commit

  ee5e87158e63 ("gpio: davinci: drop pointless static qualifier")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the gpio-brgl tree

[YueHaibing]

On 2019/1/24 12:18, Stephen Rothwell wrote:
> Hi Bartosz,
> 
> After merging the gpio-brgl tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/gpio/gpio-davinci.c: In function 'davinci_gpio_get_irq_chip':
> drivers/gpio/gpio-davinci.c:472:9: warning: function returns address of local variable [-Wreturn-local-addr]
>   return &gpio_unbanked.chip;
>          ^~~~~~~~~~~~~~~~~~~
> drivers/gpio/gpio-davinci.c: In function 'keystone_gpio_get_irq_chip':
> drivers/gpio/gpio-davinci.c:480:9: warning: function returns address of local variable [-Wreturn-local-addr]
>   return &gpio_unbanked;
>          ^~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   ee5e87158e63 ("gpio: davinci: drop pointless static qualifier")

I'm very sorry for this.

I misread the code, Pls revert this.

> 

Re: linux-next: build warning after merge of the gpio-brgl tree

[Bartosz Golaszewski]

czw., 24 sty 2019 o 06:42 YueHaibing <yuehaibing@huawei.com> napisał(a):
>
> On 2019/1/24 12:18, Stephen Rothwell wrote:
> > Hi Bartosz,
> >
> > After merging the gpio-brgl tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/gpio/gpio-davinci.c: In function 'davinci_gpio_get_irq_chip':
> > drivers/gpio/gpio-davinci.c:472:9: warning: function returns address of local variable [-Wreturn-local-addr]
> >   return &gpio_unbanked.chip;
> >          ^~~~~~~~~~~~~~~~~~~
> > drivers/gpio/gpio-davinci.c: In function 'keystone_gpio_get_irq_chip':
> > drivers/gpio/gpio-davinci.c:480:9: warning: function returns address of local variable [-Wreturn-local-addr]
> >   return &gpio_unbanked;
> >          ^~~~~~~~~~~~~~
> >
> > Introduced by commit
> >
> >   ee5e87158e63 ("gpio: davinci: drop pointless static qualifier")
>
> I'm very sorry for this.
>
> I misread the code, Pls revert this.
>
> >
>

I backed out this one.

Thanks,
Bartosz