[meta-networking][PATCH] openconnect: fix parallel compilation failure

[meta-networking][PATCH] openconnect: fix parallel compilation failure

[Qi.Chen]

From: Chen Qi <Qi.Chen@windriver.com>

This patch solves the following error which appears now and then because of
parallel building.

  ../git/main.c:78:21: fatal error: version.c: No such file or directory

version.c is generated at build time. And it's needed by some objects. So
it needs to be generated first to avoid compilation failure.

This patch fix the problem by generating version.c first before building others.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta-networking/recipes-connectivity/openconnect/openconnect_git.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
index 3a1f0f3..4242aa5 100644
--- a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
+++ b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
@@ -25,3 +25,7 @@ inherit autotools pkgconfig
 
 EXTRA_OECONF += "--with-vpnc-script=${SYSROOT_DESTDIR}${sysconfdir}/vpnc/vpnc-script \
                  --disable-static"
+
+do_compile_prepend() {
+    make version.c
+}
-- 
1.9.1

Re: [meta-networking][PATCH] openconnect: fix parallel compilation failure

[Jussi Kukkonen]

On 23 August 2017 at 13:08, <Qi.Chen@windriver.com> wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
>
> This patch solves the following error which appears now and then because of
> parallel building.
>
>   ../git/main.c:78:21: fatal error: version.c: No such file or directory
>
> version.c is generated at build time. And it's needed by some objects. So
> it needs to be generated first to avoid compilation failure.
>
> This patch fix the problem by generating version.c first before building
> others.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta-networking/recipes-connectivity/openconnect/openconnect_git.bb | 4
> ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta-networking/recipes-connectivity/openconnect/openc
> onnect_git.bb b/meta-networking/recipes-connectivity/openconnect/openc
> onnect_git.bb
> index 3a1f0f3..4242aa5 100644
> --- a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
> +++ b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
> @@ -25,3 +25,7 @@ inherit autotools pkgconfig
>
>  EXTRA_OECONF += "--with-vpnc-script=${SYSROOT_DESTDIR}${sysconfdir}/vpnc/vpnc-script
> \
>                   --disable-static"
> +
> +do_compile_prepend() {
> +    make version.c
> +}
>

Upstream has had a proper Makefile.am fix for this since August 2016. I
think the recipe should just be upgraded -- VPN software from 2015 is a bad
idea.

Jussi

Re: [meta-networking][PATCH] openconnect: fix parallel compilation failure

[ChenQi]

On 08/23/2017 06:46 PM, Jussi Kukkonen wrote:
> On 23 August 2017 at 13:08, <Qi.Chen@windriver.com 
> <mailto:Qi.Chen@windriver.com>> wrote:
>
>     From: Chen Qi <Qi.Chen@windriver.com <mailto:Qi.Chen@windriver.com>>
>
>     This patch solves the following error which appears now and then
>     because of
>     parallel building.
>
>       ../git/main.c:78:21: fatal error: version.c: No such file or
>     directory
>
>     version.c is generated at build time. And it's needed by some
>     objects. So
>     it needs to be generated first to avoid compilation failure.
>
>     This patch fix the problem by generating version.c first before
>     building others.
>
>     Signed-off-by: Chen Qi <Qi.Chen@windriver.com
>     <mailto:Qi.Chen@windriver.com>>
>     ---
>      meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
>     <http://openconnect_git.bb> | 4 ++++
>      1 file changed, 4 insertions(+)
>
>     diff --git
>     a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
>     <http://openconnect_git.bb>
>     b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
>     <http://openconnect_git.bb>
>     index 3a1f0f3..4242aa5 100644
>     ---
>     a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
>     <http://openconnect_git.bb>
>     +++
>     b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
>     <http://openconnect_git.bb>
>     @@ -25,3 +25,7 @@ inherit autotools pkgconfig
>
>      EXTRA_OECONF +=
>     "--with-vpnc-script=${SYSROOT_DESTDIR}${sysconfdir}/vpnc/vpnc-script \
>                       --disable-static"
>     +
>     +do_compile_prepend() {
>     +    make version.c
>     +}
>
>
> Upstream has had a proper Makefile.am fix for this since August 2016. 
> I think the recipe should just be upgraded -- VPN software from 2015 
> is a bad idea.
>
> Jussi


Thanks a lot. I'll send out a patch to upgrade it.

Best Regards,

Chen Qi