* [PATCH 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support
@ 2022-10-21 17:16 ` Sebastian Reichel
0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2022-10-21 17:16 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski
Cc: Jisheng Zhang, linux-mmc, linux-rockchip, devicetree,
Sebastian Reichel, kernel
Properly describe reset related properties in the binding.
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
.../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
index 71f8e726d641..162c1a4abf3c 100644
--- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
@@ -45,6 +45,18 @@ properties:
- const: block
- const: timer
+ resets:
+ minItems: 5
+ maxItems: 5
+
+ reset-names:
+ items:
+ - const: core
+ - const: bus
+ - const: axi
+ - const: block
+ - const: timer
+
rockchip,txclk-tapnum:
description: Specify the number of delay for tx sampling.
$ref: /schemas/types.yaml#/definitions/uint8
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support
@ 2022-10-21 17:16 ` Sebastian Reichel
0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2022-10-21 17:16 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski
Cc: Jisheng Zhang, linux-mmc, linux-rockchip, devicetree,
Sebastian Reichel, kernel
Properly describe reset related properties in the binding.
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
.../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
index 71f8e726d641..162c1a4abf3c 100644
--- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
@@ -45,6 +45,18 @@ properties:
- const: block
- const: timer
+ resets:
+ minItems: 5
+ maxItems: 5
+
+ reset-names:
+ items:
+ - const: core
+ - const: bus
+ - const: axi
+ - const: block
+ - const: timer
+
rockchip,txclk-tapnum:
description: Specify the number of delay for tx sampling.
$ref: /schemas/types.yaml#/definitions/uint8
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support
2022-10-21 17:16 ` Sebastian Reichel
@ 2022-10-22 16:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-22 16:06 UTC (permalink / raw)
To: Sebastian Reichel, Ulf Hansson, Rob Herring, Krzysztof Kozlowski
Cc: Jisheng Zhang, linux-mmc, linux-rockchip, devicetree, kernel
On 21/10/2022 13:16, Sebastian Reichel wrote:
> Properly describe reset related properties in the binding.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 71f8e726d641..162c1a4abf3c 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -45,6 +45,18 @@ properties:
> - const: block
> - const: timer
>
> + resets:
> + minItems: 5
No need for minItems, drop.
> + maxItems: 5
> +
> + reset-names:
> + items:
> + - const: core
> + - const: bus
> + - const: axi
> + - const: block
> + - const: timer
> +
The reset names have exactly the same names as clocks. Are these
responsible for some blocks on the device? Seems so... but I want to be
sure it wasn't copy-paste :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support
@ 2022-10-22 16:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-22 16:06 UTC (permalink / raw)
To: Sebastian Reichel, Ulf Hansson, Rob Herring, Krzysztof Kozlowski
Cc: Jisheng Zhang, linux-mmc, linux-rockchip, devicetree, kernel
On 21/10/2022 13:16, Sebastian Reichel wrote:
> Properly describe reset related properties in the binding.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 71f8e726d641..162c1a4abf3c 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -45,6 +45,18 @@ properties:
> - const: block
> - const: timer
>
> + resets:
> + minItems: 5
No need for minItems, drop.
> + maxItems: 5
> +
> + reset-names:
> + items:
> + - const: core
> + - const: bus
> + - const: axi
> + - const: block
> + - const: timer
> +
The reset names have exactly the same names as clocks. Are these
responsible for some blocks on the device? Seems so... but I want to be
sure it wasn't copy-paste :)
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-22 16:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-21 17:16 [PATCH 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support Sebastian Reichel
2022-10-21 17:16 ` Sebastian Reichel
2022-10-22 16:06 ` Krzysztof Kozlowski
2022-10-22 16:06 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.